Re: [PATCH v3 4/7] PCI: dwc: Use common pci_host_common_link_train_delay() helper

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Improper cross-controller coupling by including `../pci-host-common.h` in the DesignWare core.
--

commit f5801e5d9e35ace16e87610771ef7a5939957245
Author: Hans Zhang <18255117159@163.com>

PCI: dwc: Use common pci_host_common_link_train_delay() helper

This commit replaces the open-coded 100 ms PCIe spec delay in the
DesignWare driver with the pci_host_common_link_train_delay() helper
to reduce code duplication.

> diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
> index c11cf61b8319e..7021d21bb6011 100644
> --- a/drivers/pci/controller/dwc/pcie-designware.c
> +++ b/drivers/pci/controller/dwc/pcie-designware.c
> @@ -22,6 +22,7 @@
>  #include <linux/sizes.h>
>  #include <linux/types.h>
>  
> +#include "../pci-host-common.h"

Does including this header create an architectural entanglement between the
DesignWare library and the generic PCI ECAM host controller library?

Since the delay implements a generic PCIe specification requirement (PCIe r6.0
sec 6.6.1) applicable to all Downstream Ports > 5.0 GT/s, should this helper
be placed in a shared subsystem-wide header (like drivers/pci/pci.h or
include/linux/pci.h) with a generic name, rather than relying on another
controller's header?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260511055923.37117-1-18255117159@163.com?part=4