From: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: Hans Zhang <18255117159@163.com>,
bhelgaas@google.com, lpieralisi@kernel.org, vigneshr@ti.com,
jingoohan1@gmail.com, thomas.petazzoni@bootlin.com,
pali@kernel.org, ryder.lee@mediatek.com,
claudiu.beznea.uj@bp.renesas.com, mpillai@cadence.com,
robh@kernel.org, s-vadapalli@ti.com, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, claudiu.beznea@tuxon.dev,
linux-mediatek@lists.infradead.org,
linux-renesas-soc@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/7] PCI: dwc: Use common pci_host_common_link_train_delay() helper
Date: Tue, 12 May 2026 16:14:55 +0900 [thread overview]
Message-ID: <20260512071423.GB3606279@rocinante> (raw)
In-Reply-To: <6xcq6e6c2jc7wxhvv3kjwp5d2ik62ed7kukb3e62yogf3phtxk@6besox4h2v4n>
Hello,
> > > - /*
> > > - * As per PCIe r6.0, sec 6.6.1, a Downstream Port that supports Link
> > > - * speeds greater than 5.0 GT/s, software must wait a minimum of 100 ms
> > > - * after Link training completes before sending a Configuration Request.
> > > - */
> > > - if (pci->max_link_speed > 2)
> > > - msleep(PCIE_RESET_CONFIG_WAIT_MS);
> > > + pci_host_common_link_train_delay(pci->max_link_speed);
> >
> > This comment could move to the helper you added.
> >
>
> Not required, as the macro definition in drivers/pci/pci.h already has an
> elaborative comment with spec citation.
So it does, indeed. Thank you for checking!
Krzysztof
next prev parent reply other threads:[~2026-05-12 7:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 5:59 [PATCH v3 0/7] PCI: Add common helper for 100 ms delay after link training Hans Zhang
2026-05-11 5:59 ` [PATCH v3 1/7] PCI: Add pci_host_common_link_train_delay() helper Hans Zhang
2026-05-12 0:07 ` sashiko-bot
2026-05-12 0:45 ` Hans Zhang
2026-05-12 7:05 ` Claudiu Beznea
2026-05-12 10:06 ` Hans Zhang
2026-05-11 5:59 ` [PATCH v3 2/7] PCI: cadence: Add post-link delay for LGA and j721e glue driver Hans Zhang
2026-05-12 0:24 ` sashiko-bot
2026-05-12 0:44 ` Hans Zhang
2026-05-11 5:59 ` [PATCH v3 3/7] PCI: cadence: HPA: Add post-link delay Hans Zhang
2026-05-12 0:44 ` sashiko-bot
2026-05-11 5:59 ` [PATCH v3 4/7] PCI: dwc: Use common pci_host_common_link_train_delay() helper Hans Zhang
2026-05-11 7:02 ` Krzysztof Wilczyński
2026-05-12 0:43 ` Hans Zhang
2026-05-12 7:14 ` Krzysztof Wilczyński
2026-05-12 10:06 ` Hans Zhang
2026-05-12 6:45 ` Manivannan Sadhasivam
2026-05-12 7:14 ` Krzysztof Wilczyński [this message]
2026-05-12 1:00 ` sashiko-bot
2026-05-11 5:59 ` [PATCH v3 5/7] PCI: aardvark: Add 100 ms delay after link training Hans Zhang
2026-05-12 1:31 ` sashiko-bot
2026-05-11 5:59 ` [PATCH v3 6/7] PCI: mediatek-gen3: Add 100 ms delay after link up Hans Zhang
2026-05-12 1:59 ` sashiko-bot
2026-05-11 5:59 ` [PATCH v3 7/7] PCI: rzg3s-host: Use common pci_host_common_link_train_delay() helper Hans Zhang
2026-05-12 2:15 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260512071423.GB3606279@rocinante \
--to=kwilczynski@kernel.org \
--cc=18255117159@163.com \
--cc=bhelgaas@google.com \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=jingoohan1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=mpillai@cadence.com \
--cc=pali@kernel.org \
--cc=robh@kernel.org \
--cc=ryder.lee@mediatek.com \
--cc=s-vadapalli@ti.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox