[pci:endpoint-test 16/18] drivers/pci/controller/dwc/pcie-dw-rockchip.c:316:3: error: field designator 'intx_capable' does not refer to any field in type 'const struct dw_pcie_ep_ops'

[pci:endpoint-test 16/18] drivers/pci/controller/dwc/pcie-dw-rockchip.c:316:3: error: field designator 'intx_capable' does not refer to any field in type 'const struct dw_pcie_ep_ops'

[kernel test robot]

Hi Niklas,

FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git endpoint-test
head:   d87a0e7ac55245a3f75ca5c646ffdf0cfa36e749
commit: da8628c06a7f08cb3402d02040d7a6195949772c [16/18] PCI: dw-rockchip: Endpoint mode cannot raise INTx interrupts
config: s390-randconfig-001-20250311 (https://download.01.org/0day-ci/archive/20250311/202503110151.vQXf5yof-lkp@intel.com/config)
compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250311/202503110151.vQXf5yof-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503110151.vQXf5yof-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/pci/controller/dwc/pcie-dw-rockchip.c:316:3: error: field designator 'intx_capable' does not refer to any field in type 'const struct dw_pcie_ep_ops'
           .intx_capable = false,
            ^
   drivers/pci/controller/dwc/pcie-dw-rockchip.c:530:33: warning: shift count >= width of type [-Wshift-count-overflow]
           dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
                                          ^~~~~~~~~~~~~~~~
   include/linux/dma-mapping.h:73:54: note: expanded from macro 'DMA_BIT_MASK'
   #define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1))
                                                        ^ ~~~
   1 warning and 1 error generated.


vim +316 drivers/pci/controller/dwc/pcie-dw-rockchip.c

   313	
   314	static const struct dw_pcie_ep_ops rockchip_pcie_ep_ops = {
   315		.init = rockchip_pcie_ep_init,
 > 316		.intx_capable = false,
   317		.raise_irq = rockchip_pcie_raise_irq,
   318		.get_features = rockchip_pcie_get_features,
   319	};
   320	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [pci:endpoint-test 16/18] drivers/pci/controller/dwc/pcie-dw-rockchip.c:316:3: error: field designator 'intx_capable' does not refer to any field in type 'const struct dw_pcie_ep_ops'

[Niklas Cassel]

Hello Krzysztof,

On Tue, Mar 11, 2025 at 02:02:12AM +0800, kernel test robot wrote:
> Hi Niklas,
> 
> FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git endpoint-test
> head:   d87a0e7ac55245a3f75ca5c646ffdf0cfa36e749
> commit: da8628c06a7f08cb3402d02040d7a6195949772c [16/18] PCI: dw-rockchip: Endpoint mode cannot raise INTx interrupts
> config: s390-randconfig-001-20250311 (https://download.01.org/0day-ci/archive/20250311/202503110151.vQXf5yof-lkp@intel.com/config)
> compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250311/202503110151.vQXf5yof-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202503110151.vQXf5yof-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
> >> drivers/pci/controller/dwc/pcie-dw-rockchip.c:316:3: error: field designator 'intx_capable' does not refer to any field in type 'const struct dw_pcie_ep_ops'
>            .intx_capable = false,
>             ^
>    drivers/pci/controller/dwc/pcie-dw-rockchip.c:530:33: warning: shift count >= width of type [-Wshift-count-overflow]
>            dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
>                                           ^~~~~~~~~~~~~~~~
>    include/linux/dma-mapping.h:73:54: note: expanded from macro 'DMA_BIT_MASK'
>    #define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1))
>                                                         ^ ~~~
>    1 warning and 1 error generated.
> 
> 
> vim +316 drivers/pci/controller/dwc/pcie-dw-rockchip.c
> 
>    313	
>    314	static const struct dw_pcie_ep_ops rockchip_pcie_ep_ops = {
>    315		.init = rockchip_pcie_ep_init,
>  > 316		.intx_capable = false,
>    317		.raise_irq = rockchip_pcie_raise_irq,
>    318		.get_features = rockchip_pcie_get_features,
>    319	};
>    320	
>

This is not how the patch that I sent out looked like.

See:
https://lore.kernel.org/all/20250310111016.859445-14-cassel@kernel.org/

My guess is that you modified it before applying
(without adding [kwilczynski: ]).
If you undo your modifications, it should compile :)


Kind regards,
Niklas

Re: [pci:endpoint-test 16/18] drivers/pci/controller/dwc/pcie-dw-rockchip.c:316:3: error: field designator 'intx_capable' does not refer to any field in type 'const struct dw_pcie_ep_ops'

[Krzysztof Wilczyński]

Hello,

[...]
> vim +316 drivers/pci/controller/dwc/pcie-dw-rockchip.c
> 
>    313	
>    314	static const struct dw_pcie_ep_ops rockchip_pcie_ep_ops = {
>    315		.init = rockchip_pcie_ep_init,
>  > 316		.intx_capable = false,
>    317		.raise_irq = rockchip_pcie_raise_irq,
>    318		.get_features = rockchip_pcie_get_features,
>    319	};
>    320	

I moved setting the .intx_capable property to false to the pci_epc_features
struct definition for RK3568, which is what I believe the intention was.

Have a look at:

  https://web.git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=endpoint-test&id=cb349262d9770e6478a7e91bdf438122b8cda44d

Let me know if this is OK with you.

	Krzysztof

Re: [pci:endpoint-test 16/18] drivers/pci/controller/dwc/pcie-dw-rockchip.c:316:3: error: field designator 'intx_capable' does not refer to any field in type 'const struct dw_pcie_ep_ops'

[Krzysztof Wilczyński]

Hello,

> [...]
> > vim +316 drivers/pci/controller/dwc/pcie-dw-rockchip.c
> > 
> >    313	
> >    314	static const struct dw_pcie_ep_ops rockchip_pcie_ep_ops = {
> >    315		.init = rockchip_pcie_ep_init,
> >  > 316		.intx_capable = false,
> >    317		.raise_irq = rockchip_pcie_raise_irq,
> >    318		.get_features = rockchip_pcie_get_features,
> >    319	};
> >    320	
> 
> I moved setting the .intx_capable property to false to the pci_epc_features
> struct definition for RK3568, which is what I believe the intention was.
> 
> Have a look at:
> 
>   https://web.git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=endpoint-test&id=cb349262d9770e6478a7e91bdf438122b8cda44d
> 
> Let me know if this is OK with you.

Niklas, I saw your reply to this failure report.

Based on it, I fixed the patch and dropped any annotations added (since
there was no need to do anything aside from retroing the code to its
orignal form).


That said, I didn't do any edits when applying the patch that I can recall,
so I think something got its knickers in a twist when I was applying the
patches.

However, I did miss that it got applied incorrectly when reviewing the
changes before pushing them.  My bad.

Anyway.  Sorry for the commotion.  I am glad the fix was trivial here.

Thank you!

	Krzysztof

Re: [pci:endpoint-test 16/18] drivers/pci/controller/dwc/pcie-dw-rockchip.c:316:3: error: field designator 'intx_capable' does not refer to any field in type 'const struct dw_pcie_ep_ops'

[Niklas Cassel]

Hello Krzysztof,

On Tue, Mar 11, 2025 at 03:49:04AM +0900, Krzysztof Wilczyński wrote:
> Hello,
> 
> > [...]
> > > vim +316 drivers/pci/controller/dwc/pcie-dw-rockchip.c
> > > 
> > >    313	
> > >    314	static const struct dw_pcie_ep_ops rockchip_pcie_ep_ops = {
> > >    315		.init = rockchip_pcie_ep_init,
> > >  > 316		.intx_capable = false,
> > >    317		.raise_irq = rockchip_pcie_raise_irq,
> > >    318		.get_features = rockchip_pcie_get_features,
> > >    319	};
> > >    320	
> > 
> > I moved setting the .intx_capable property to false to the pci_epc_features
> > struct definition for RK3568, which is what I believe the intention was.
> > 
> > Have a look at:
> > 
> >   https://web.git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=endpoint-test&id=cb349262d9770e6478a7e91bdf438122b8cda44d
> > 
> > Let me know if this is OK with you.
> 
> Niklas, I saw your reply to this failure report.
> 
> Based on it, I fixed the patch and dropped any annotations added (since
> there was no need to do anything aside from retroing the code to its
> orignal form).
> 
> 
> That said, I didn't do any edits when applying the patch that I can recall,
> so I think something got its knickers in a twist when I was applying the
> patches.
> 
> However, I did miss that it got applied incorrectly when reviewing the
> changes before pushing them.  My bad.
> 
> Anyway.  Sorry for the commotion.  I am glad the fix was trivial here.

The patch looks correct on the endpoint-test branch.

Thank you for fixing it up so quickly!


Kind regards,
Niklas