public inbox for linux-pci@vger.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, Niklas Schnelle <niks@kernel.org>,
	Ilpo Jarvinen <ilpo.jarvinen@linux.intel.com>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	"Maciej W. Rozycki" <macro@orcam.me.uk>,
	Mario Limonciello <mario.limonciello@amd.com>
Subject: [PATCH for-linus v3 0/2] Fix bwctrl boot hang
Date: Tue, 17 Dec 2024 10:51:00 +0100	[thread overview]
Message-ID: <cover.1734428762.git.lukas@wunner.de> (raw)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=UTF-8, Size: 1127 bytes --]

In response to v2, Ilpo gave a heads-up that the first patch in the series
was problematic:  A zero Max Link Speed is common in particular on Root
Complex Integrated Endpoints, so there's no reason to emit a warning
or assume 2.5 GT/s.

In the interest of resolving the regression before the holidays,
I'm respinning already after two days and I'm reverting back to my
original proposal to use 0 as lowest bit in the GENMASK() macro.
I've amended the commit message with an explanation to address Ilpo's
concern that the 0 may cause confusion because Supported Link Speeds
ends at bit 1.

So patch [1/2] in this series is identical to what's already queued up
on pci.git/for-linus, save for the extended commit message.

And patch [2/2] is unchanged vis-à-vis v2.

Link to v2:
https://lore.kernel.org/all/cover.1734257330.git.lukas@wunner.de/


Lukas Wunner (2):
  PCI: Honor Max Link Speed when determining supported speeds
  PCI/bwctrl: Enable only if more than one speed is supported

 drivers/pci/pci.c          | 6 ++++--
 drivers/pci/pcie/portdrv.c | 4 +++-
 2 files changed, 7 insertions(+), 3 deletions(-)

-- 
2.43.0


             reply	other threads:[~2024-12-17  9:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-17  9:51 Lukas Wunner [this message]
2024-12-17  9:51 ` [PATCH for-linus v3 1/2] PCI: Honor Max Link Speed when determining supported speeds Lukas Wunner
2024-12-17 11:33   ` Ilpo Järvinen
2024-12-18 23:43     ` Krzysztof Wilczyński
2024-12-19  7:41       ` Lukas Wunner
2024-12-19 11:05         ` Ilpo Järvinen
2024-12-19 16:37           ` Krzysztof Wilczy??ski
     [not found]             ` <CABhMZUWP1LN2ZX7oAaW4oJywC+Zfo4Y0p4ep7NJkkgGcVsM+hg@mail.gmail.com>
2024-12-20  8:57               ` Lukas Wunner
2024-12-17  9:51 ` [PATCH for-linus v3 2/2] PCI/bwctrl: Enable only if more than one speed is supported Lukas Wunner
2024-12-17 11:35   ` Ilpo Järvinen
2024-12-18 23:48 ` [PATCH for-linus v3 0/2] Fix bwctrl boot hang Krzysztof Wilczyński

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1734428762.git.lukas@wunner.de \
    --to=lukas@wunner.de \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=helgaas@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=macro@orcam.me.uk \
    --cc=mario.limonciello@amd.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=niks@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox