From: Krzysztof Wilczy??ski <kw@linux.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Lukas Wunner <lukas@wunner.de>,
Bjorn Helgaas <helgaas@kernel.org>,
linux-pci@vger.kernel.org, Niklas Schnelle <niks@kernel.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
"Maciej W. Rozycki" <macro@orcam.me.uk>,
Mario Limonciello <mario.limonciello@amd.com>
Subject: Re: [PATCH for-linus v3 1/2] PCI: Honor Max Link Speed when determining supported speeds
Date: Fri, 20 Dec 2024 01:37:05 +0900 [thread overview]
Message-ID: <20241219163705.GA623969@rocinante> (raw)
In-Reply-To: <f4b43cee-b029-1c78-2412-7a952e8e83a1@linux.intel.com>
Hello,
[...]
> > > > Thanks for adding this extra information.
> > > >
> > > > I'd also add reference to r6.2 section 7.5.3 which states those registers
> > > > are required for RPs, Switch Ports, Bridges, and Endpoints _that are not
> > > > RCiEPs_. My reading is that implies they're not required from RCiEPs.
> > >
> > > Let me know how you would like to update the commit message. I will do it
> > > directly on the branch.
> >
> > FWIW, I edited the commit message like this on my local branch:
> >
> > -Endpoints in particular, so it does occur in practice.
> > +Endpoints in particular, so it does occur in practice. (The Link
> > +Capabilities Register is optional on RCiEPs per PCIe r6.2 sec 7.5.3.)
> >
> > In other words, I just added the sentence in parentheses.
> > But maybe Ilpo has another wording preference... :)
>
> Your wording is good summary for the real substance that is the spec
> itself. :-)
Updated. Thank you both!
Krzysztof
next prev parent reply other threads:[~2024-12-19 16:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 9:51 [PATCH for-linus v3 0/2] Fix bwctrl boot hang Lukas Wunner
2024-12-17 9:51 ` [PATCH for-linus v3 1/2] PCI: Honor Max Link Speed when determining supported speeds Lukas Wunner
2024-12-17 11:33 ` Ilpo Järvinen
2024-12-18 23:43 ` Krzysztof Wilczyński
2024-12-19 7:41 ` Lukas Wunner
2024-12-19 11:05 ` Ilpo Järvinen
2024-12-19 16:37 ` Krzysztof Wilczy??ski [this message]
[not found] ` <CABhMZUWP1LN2ZX7oAaW4oJywC+Zfo4Y0p4ep7NJkkgGcVsM+hg@mail.gmail.com>
2024-12-20 8:57 ` Lukas Wunner
2024-12-17 9:51 ` [PATCH for-linus v3 2/2] PCI/bwctrl: Enable only if more than one speed is supported Lukas Wunner
2024-12-17 11:35 ` Ilpo Järvinen
2024-12-18 23:48 ` [PATCH for-linus v3 0/2] Fix bwctrl boot hang Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241219163705.GA623969@rocinante \
--to=kw@linux.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=helgaas@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=macro@orcam.me.uk \
--cc=mario.limonciello@amd.com \
--cc=mika.westerberg@linux.intel.com \
--cc=niks@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox