Re: [PATCH v8 05/17] perf machine: Use perf_env e_machine rather than arch

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit changes the visibility and signature of `machine__is()` (making it static and changing its second parameter from `const char *` to `uint16_t e_machine`), but fails to update callers in `tools/perf/util/symbol.c` (which still pass a string like `"x86_64"`), causing a build breakage.
--

commit 43e3a53fa61bf39d387266ed813f417208baa8e5
Author: Ian Rogers <irogers@google.com>

perf machine: Use perf_env e_machine rather than arch

This commit modifies machine__is to use ELF machine constant comparisons
instead of string comparisons and reduces its scope by making it static. It
updates callers within machine.c.

> diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
> --- a/tools/perf/util/machine.c
> +++ b/tools/perf/util/machine.c
[ ... ]
> @@ -1611,10 +1611,15 @@ static bool machine__uses_kcore(struct machine *machine)
>  	return dsos__for_each_dso(&machine->dsos, machine__uses_kcore_cb, NULL) != 0 ? true : false;
>  }
>  
> +static bool machine__is(struct machine *machine, uint16_t e_machine)
> +{
> +	return machine && perf_env__e_machine(machine->env, NULL) == e_machine;
> +}
> +

Does changing machine__is() to be static and altering its signature break
the build?

It appears callers in tools/perf/util/symbol.c still pass a string
argument like "x86_64" to this function.

I notice this is addressed later in the series by commit ae1a01cb2104
(perf symbol: Avoid use of machine__is), but leaving this intermediate
state might cause bisection failures.

[ ... ]
> diff --git a/tools/perf/util/machine.h b/tools/perf/util/machine.h
> --- a/tools/perf/util/machine.h
> +++ b/tools/perf/util/machine.h
> @@ -227,8 +227,6 @@ static inline bool machine__is_host(struct machine *machine)
>  }
>  
>  bool machine__is_lock_function(struct machine *machine, u64 addr);
> -bool machine__is(struct machine *machine, const char *arch);
> -bool machine__normalized_is(struct machine *machine, const char *arch);
>  int machine__nr_cpus_avail(struct machine *machine);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260502065935.291960-1-irogers@google.com?part=5