Re: [PATCH v9 16/18] perf env: Add helper to lazily compute the os_release

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Lazy initialization in `perf_env__os_release` assumes a NULL `os_release` implies 'live mode', permanently polluting offline trace environments with the analysis host's kernel version.
--

commit d62418e881e036f2b1905f5ed81dd67b105e5fb8
Author: Ian Rogers <irogers@google.com>

perf env: Add helper to lazily compute the os_release

This commit introduces a lazy initialization helper for os_release. It
assumes that if os_release is uninitialized, the tool is running in live
mode, and populates it using uname().

[ ... ]

> diff --git a/tools/perf/util/env.c b/tools/perf/util/env.c
> index 29d5fe37528b..45dde40042b5 100644
> --- a/tools/perf/util/env.c
> +++ b/tools/perf/util/env.c
> @@ -351,6 +351,27 @@ bool perf_arch_is_big_endian(const char *arch)
>  	return false;
>  }
>  
> +const char *perf_env__os_release(struct perf_env *env)
> +{
> +	struct utsname uts;
> +	int ret;
> +
> +	if (!env)
> +		return perf_version_string;
> +
> +	if (env->os_release)
> +		return env->os_release;
> +
> +	/*
> +	 * The os_release is being accessed but wasn't initialized from a data
> +	 * file, assume this is 'live' mode and use the release from uname. If
> +	 * uname or strdup fails then use the current perf tool version.
> +	 */
> +	ret = uname(&uts);
> +	env->os_release = strdup(ret < 0 ? perf_version_string : uts.release);

If an offline perf.data file was recorded without the HEADER_OSRELEASE feature
(for example, using --no-feature osrelease), won't env->os_release be NULL?

If so, does this permanently overwrite the target's environment metadata with
the analysis host's kernel version?

If this occurs, it seems vmlinux_path__init() will search for the analysis
host's kernel path instead of the target's. If the offline trace also lacks
build-ids, could perf silently load the host's kernel symbol table and apply
it to the target's profile, corrupting symbol resolution?

Similarly, could tools like perf data convert silently export the host's OS
release into the new trace data as if it belonged to the target system?

> +	return env->os_release ?: perf_version_string;
> +}
> +
>  int perf_env__set_cmdline(struct perf_env *env, int argc, const char *argv[])
>  {
>  	int i;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260503002248.1040791-1-irogers@google.com?part=16