Re: [PATCH v7] perf jevents.py: Make generated C code more kernel style

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Unmatched `/* clang-format on */` directive and failure to bypass clang-format for generated tables.
--

commit 0066c92b375735ccaca89b6a548251dee83b70d0
Author: Ian Rogers <irogers@google.com>

perf jevents.py: Make generated C code more kernel style

This commit updates jevents.py to generate C code that complies with
kernel formatting tools. It adds /* clang-format off/on */ directives around
large generated tables to bypass them while checking functions and early
structs. It also fixes comments and indentation in initializers.

> diff --git a/tools/perf/pmu-events/jevents.py b/tools/perf/pmu-events/jevents.py
> --- a/tools/perf/pmu-events/jevents.py
> +++ b/tools/perf/pmu-events/jevents.py
[ ... ]
> @@ -1466,6 +1463,7 @@ struct pmu_table_entry {
>  
>    _bcs.compute()
>    if not _args.output_string_file:
> +    _args.output_file.write('/* clang-format off */\n')
>      _args.output_file.write('static const char *const big_c_string =\n')
>      for s in _bcs.big_string:
>        _args.output_file.write(s)
[ ... ]
> @@ -1487,6 +1485,7 @@ struct pmu_table_entry {
>  
>    print_mapping_table(archs)
>    print_system_mapping_table()
> +  _args.output_file.write('/* clang-format on */\n')

[Severity: Low]
Is it possible to end up with an unmatched /* clang-format on */ directive?

If the script is executed with output_string_file specified, the
/* clang-format off */ directive won't be written, but the on directive is
unconditionally written here. This could also fail the commit's goal of
bypassing clang-format for the generated tables.

>    print_metricgroups()
>    _args.output_file.close()
>    if _args.output_string_file:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260602073132.2653307-3-irogers@google.com?part=1