Re: [PATCH v7] perf test: Add shell test to validate JUnit XML reporting output

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The shell test unconditionally fails because it relies on an unimplemented `-j`/`--junit` option in `perf test`.
--

commit 31f6e510d9bd4b022fd2d85031ceb012fba13be3
Author: Ian Rogers <irogers@google.com>

perf test: Add shell test to validate JUnit XML reporting output

This commit adds a shell test script to execute perf test with the
-j/--junit option. It then uses Python's ElementTree parser to validate
that the generated report complies with standard XML formatting.

> diff --git a/tools/perf/tests/shell/test_test_junit_output.sh b/tools/perf/tests/shell/test_test_junit_output.sh
> new file mode 100755
> index 0000000000000..5104ac1e1e6de
> --- /dev/null
> +++ b/tools/perf/tests/shell/test_test_junit_output.sh

[ ... ]

> +test_junit_output()
> +{
> +	echo "Testing perf test JUnit XML output command"
> +	perf test -v -j"$result" util || true
> +	if [ -s "$result" ] ; then

[Severity: Medium]
Is the -j/--junit option currently implemented in perf test?

Looking at cmd_test() in tools/perf/tests/builtin-test.c, it appears
the -j option is missing from the option parser:

tools/perf/tests/builtin-test.c:cmd_test() {
        const struct option test_options[] = {
        OPT_STRING('s', "skip", &skip, "tests", "tests to skip"),
        ...
}

If perf test fails to parse the argument, the command exits early and leaves
the temporary $result file empty. The size check will evaluate to false,
and the subsequent Python XML parsing step will fail.

Does this test rely on a separate patch in the series to add the -j option?

> +		echo "perf test JUnit XML output command [SUCCESS]"
> +	else
> +		echo "perf test JUnit XML output command [FAILED]"
> +		err=1
> +	fi
> +}

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260602073132.2653307-16-irogers@google.com?part=1