Re: [PATCH v7 6/6] perf ui hists: Remove duplicated thread in popup_action

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The symbol filter string is not reset and freed when exiting the browser, causing silent filter persistence and a memory leak.
--

--- Patch [6]: [PATCH v7 6/6] perf ui hists: Remove duplicated thread in popup_action ---
commit 0930d22bfe566125dece911349b0d1a0a381a8df
Author: Ian Rogers <irogers@google.com>

perf ui hists: Remove duplicated thread in popup_action

struct popup_action has a thread but this is duplicated in the
map_symbol. Remove the non-map_symbol version so that there's only ever
1 thread with a popup_action.

> diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
> index 39d83f15f23c6..c15874a491b43 100644
> --- a/tools/perf/ui/browsers/hists.c
> +++ b/tools/perf/ui/browsers/hists.c
> @@ -2359,7 +2359,6 @@ static int hists_browser__scnprintf_title(struct hist_browser *browser, char *bf
>  
>  struct popup_action {
>  	unsigned long		time;
> -	struct thread		*thread;
>  	int (*fn)(struct hist_browser *browser, struct popup_action *act);
>  	struct map_symbol	ms;
>  	int			socket;

tools/perf/ui/browsers/hists.c:evsel__hists_browse() {
...
out_free_stack:
	pstack__delete(browser->pstack);
	free_popup_actions(actions, MAX_OPTIONS);
	thread__zput(hists->thread_filter);
	dso__put((struct dso *)hists->dso_filter);
	hists->dso_filter = NULL;
	perf_hpp__set_elide(HISTC_DSO, false);
	perf_hpp__set_elide(HISTC_THREAD, false);
	hists__filter_by_dso(hists);
	hists__filter_by_thread(hists);
out:
...
}

[Severity: Medium]
Does this exit cleanup path leak the symbol filter string?

It appears the dso and thread filters are properly reset here, but
hists->symbol_filter_str is completely omitted from the cleanup.

Could this result in a memory leak and silent filter persistence state? If a
user applies a symbol filter via the '/' hotkey and then exits the view,
the view might become silently filtered without UI indication in the stack
when switching browser tabs.

The commit message for 'perf ui hists: Fix stack use-after-return in
symbol_filter_str' explicitly promised to 'cleanly reset and free the symbol
filter string upon exiting the browser', but does this code fail to do so?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260723045949.988740-1-irogers@google.com?part=6