Re: [Patch v8 16/23] perf/x86: Support OPMASK sampling using sample_simd_pred_reg_* fields

["Mi, Dapeng" <dapeng1.mi@linux.intel.com>]

On 5/29/2026 5:21 PM, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] The UAPI header `arch/x86/include/uapi/asm/perf_regs.h` uses the `__GENMASK` macro without including `<linux/bits.h>`.
> --
>
> commit 105b880ba965bb46db4e0202af5a989492cd6220
> Author: Dapeng Mi <dapeng1.mi@linux.intel.com>
>
> perf/x86: Support OPMASK sampling using sample_simd_pred_reg_* fields
>
> This commit adds support for sampling OPMASK registers via the
> sample_simd_pred_reg_* fields. It updates x86_pmu_hw_config to check for
> OPMASK capabilities and modifies perf_simd_reg_value and
> perf_simd_reg_validate to handle the new registers.
>
>> diff --git a/arch/x86/include/uapi/asm/perf_regs.h b/arch/x86/include/uapi/asm/perf_regs.h
>> index 3aacdd4e2764c..24c981ba8bae2 100644
>> --- a/arch/x86/include/uapi/asm/perf_regs.h
>> +++ b/arch/x86/include/uapi/asm/perf_regs.h
> [ ... ]
>> @@ -60,14 +60,19 @@ enum {
>>  	PERF_X86_SIMD_YMM_REGS      = 16,
>>  	PERF_X86_SIMD_ZMM_REGS      = 32,
>>  	PERF_X86_SIMD_VEC_REGS_MAX  = PERF_X86_SIMD_ZMM_REGS,
>> +
>> +	PERF_X86_SIMD_OPMASK_REGS   = 8,
>> +	PERF_X86_SIMD_PRED_REGS_MAX = PERF_X86_SIMD_OPMASK_REGS,
>>  };
>>  
>> +#define PERF_X86_SIMD_PRED_MASK	__GENMASK(PERF_X86_SIMD_PRED_REGS_MAX - 1, 0)
> [Severity: Low]
> Does this uapi header need to include <linux/bits.h> for the __GENMASK
> macro?
>
> Without the include, userspace applications directly including
> <asm/perf_regs.h> might fail to compile due to an implicitly defined macro.

Sure. 


>
>>  #define PERF_X86_SIMD_VEC_MASK	__GENMASK_ULL(PERF_X86_SIMD_VEC_REGS_MAX - 1, 0)