Re: [RFC PATCH 1/5] perf/kselftest: convert prefix.pl to Python

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] selftests: prefix.py is unused and not installed by Makefile or runner.sh
- [Low] selftests: missing trailing newline at end of prefix.py
--

commit f99bbafab30726cd18857c0cc9a21eeae2499158
Author: Breno Rodrigues Alves <breno3011alves@gmail.com>

perf/kselftest: convert prefix.pl to Python

This commit adds a Python 3 re-implementation of
tools/testing/selftests/kselftest/prefix.pl to prefix input lines with
"# " in an unbuffered manner.

> diff --git a/tools/testing/selftests/kselftest/prefix.py b/tools/testing/selftests/kselftest/prefix.py
> new file mode 100755
> index 0000000000000..2bf16b37dee63
> --- /dev/null
> +++ b/tools/testing/selftests/kselftest/prefix.py
> @@ -0,0 +1,24 @@
> +#!/usr/bin/env python3
> +# SPDX-License-Identifier: GPL-2.0
> +# Prefix all lines with "# ", unbuffered.
> +
> +import sys
> +
> +
> +def main():

[Severity: Medium]
Should tools/testing/selftests/kselftest/runner.sh and
tools/testing/selftests/Makefile also be updated to use and install
prefix.py, and remove prefix.pl?

Currently, tap_prefix() in tools/testing/selftests/kselftest/runner.sh
still checks for /usr/bin/perl and invokes prefix.pl:

tap_prefix()
{
	if [ ! -x /usr/bin/perl ]; then
		sed -e 's/^/# /'
	else
		"$BASE_DIR"/kselftest/prefix.pl
	fi
}

And the install target in tools/testing/selftests/Makefile still only
installs prefix.pl:

	install -m 744 kselftest/prefix.pl $(INSTALL_PATH)/kselftest/

Without updating those callers, prefix.py is never executed or installed.

> +    needed = True
> +    while True:
> +        char = sys.stdin.buffer.read(1)
> +        if not char:
> +            return 0
> +        if needed:
> +            sys.stdout.buffer.write(b"# ")
> +            needed = False
> +        sys.stdout.buffer.write(char)
> +        sys.stdout.buffer.flush()
> +        if char == b"\n":
> +            needed = True
> +
> +
> +if __name__ == "__main__":
> +    sys.exit(main())
> \ No newline at end of file

[Severity: Low]
Could a trailing newline be added at the end of
tools/testing/selftests/kselftest/prefix.py?

[]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261018125641.23064-1-breno3011alves@gmail.com?part=1