Re: [RFC PATCH v2 1/2] perf/kselftest: convert prefix.pl to Python

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] selftests: accidental deletion of tap_timeout() header in runner.sh
--

commit 3307ba1d73611e0bd22bd59e12d190de9b29a3a2
Author: Breno Rodrigues Alves <breno3011alves@gmail.com>

perf/kselftest: convert prefix.pl to Python

This commit replaces tools/testing/selftests/kselftest/prefix.pl with a
Python 3 implementation (prefix.py) and updates runner.sh and the
selftests Makefile to use and install the new script.

> diff --git a/tools/testing/selftests/kselftest/runner.sh b/tools/testing/selftests/kselftest/runner.sh
> index 311811dc55a07..b61ea6c2de89d 100644
> --- a/tools/testing/selftests/kselftest/runner.sh
> +++ b/tools/testing/selftests/kselftest/runner.sh
> @@ -29,15 +29,12 @@ TR_CMD=$(command -v tr)
>  # with sed instead of unbuffered output.
>  tap_prefix()
>  {
> -	if [ ! -x /usr/bin/perl ]; then
> +	if [ ! -x /usr/bin/python3 ]; then
>  		sed -e 's/^/# /'
>  	else
> -		"$BASE_DIR"/kselftest/prefix.pl
> +		"$BASE_DIR"/kselftest/prefix.py
>  	fi
>  }
> -
> -tap_timeout()
> -{
>  	# Make sure tests will time out if utility is available.
>  	if [ -x /usr/bin/timeout ] ; then
>  		/usr/bin/timeout --foreground "$kselftest_timeout" \

[Severity: Medium]
Was the removal of the tap_timeout() function header and opening brace here
unintentional?

Without it, the body of tap_timeout() is left at top-level scope followed by
an unmatched closing brace:

tools/testing/selftests/kselftest/runner.sh:
	# Make sure tests will time out if utility is available.
	if [ -x /usr/bin/timeout ] ; then
		/usr/bin/timeout --foreground "$kselftest_timeout" \
			/usr/bin/timeout "$kselftest_timeout" $1
	else
		$1
	fi
}

When tools/testing/selftests/kselftest/runner.sh is sourced (for example via
RUN_TESTS in tools/testing/selftests/lib.mk or
tools/testing/selftests/run_kselftest.sh), the shell executes the timeout
logic immediately and fails with a syntax error on the closing brace.

In addition, tap_timeout() is no longer defined when run_one() invokes it:

tools/testing/selftests/kselftest/runner.sh:run_one() {
	...
		(((( tap_timeout "$cmd" 2>&1; echo $? >&3) |
			tap_prefix >&4) 3>&1) |
			(read xs; exit $xs)) 4>>"$logfile"
	...
}

—
AI reviewed your patch. Please follow the URL below to transplant the feedback or give kudos to the AI:
https://github.com/kernel-patches/vmtest/wiki

계가

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261018133032.24467-1-breno3011alves@gmail.com?part=1