Re: [RFC PATCH 3/5] perf/tests: convert check_no_patterns_found.pl to Python

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] perf tests: check_no_patterns_found.py is unused and not installed
- [Low] perf tests: missing EOF newline in check_no_patterns_found.py breaks PYLINT=1
--

commit d6b15fdc56a31f78fa7365cb6aafd5034b2a393d
Author: Breno Rodrigues Alves <breno3011alves@gmail.com>

perf/tests: convert check_no_patterns_found.pl to Python

This commit adds a Python 3 implementation of check_no_patterns_found.pl
under tools/perf/tests/shell/common/check_no_patterns_found.py.

> diff --git a/tools/perf/tests/shell/common/check_no_patterns_found.py b/tools/perf/tests/shell/common/check_no_patterns_found.py
> new file mode 100755
> index 0000000000000..0e5d931b903a2
> --- /dev/null
> +++ b/tools/perf/tests/shell/common/check_no_patterns_found.py
> @@ -0,0 +1,35 @@
> +#!/usr/bin/env python3
> +# SPDX-License-Identifier: GPL-2.0

[Severity: Medium]
Should this commit also update the existing callers, remove
tools/perf/tests/shell/common/check_no_patterns_found.pl, and install the new
script?

All existing call sites in the test suite still invoke
check_no_patterns_found.pl:

tools/perf/tests/shell/base_probe/test_adding_kernel.sh:
	"$DIR_PATH/../common/check_no_patterns_found.pl" \
		"$RE_SEGFAULT" < $LOGS_DIR/adding_kernel_nonexisting.err

tools/perf/tests/shell/base_probe/test_basic.sh:
	"$DIR_PATH/../common/check_no_patterns_found.pl" \
		"No manual entry for" < $LOGS_DIR/basic_helpmsg.err

tools/perf/tests/shell/base_report/test_basic.sh:
	"$DIR_PATH/../common/check_no_patterns_found.pl" \
		"No manual entry for" < $LOGS_DIR/basic_helpmsg.err

In addition, the install-tests target in tools/perf/Makefile.perf only
installs *.sh and *.pl files from tests/shell/common:

tools/perf/Makefile.perf:
		$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/shell/common'; \
		$(INSTALL) tests/shell/common/*.sh '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/shell/common'; \
		$(INSTALL) tests/shell/common/*.pl '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/shell/common'; \

Without updating the callers and Makefile.perf, check_no_patterns_found.py is
never executed or installed.

[ ... ]

> +if __name__ == "__main__":
> +    sys.exit(main(sys.argv[1:]))
> \ No newline at end of file

[Severity: Low]
Does the missing trailing newline at the end of check_no_patterns_found.py
cause a build failure when building perf with PYLINT=1?

In tools/perf/tests/Build, PY_TESTS collects all *.py files under tests/shell
to run pylint:

tools/perf/tests/Build:
ifdef PYLINT
  PY_TESTS := $(shell find tests/shell -type f -name '*.py')
  PYLINT_TEST_LOGS := $(PY_TESTS:tests/shell/%=shell/%.pylint_log)

Because main() in tools/perf/tests/shell/common/check_no_patterns_found.py
ends without a final newline (and without pylint directives or docstrings),
pylint reports C0304 (missing-final-newline) and fails the build when
PYLINT=1 is enabled.

Can a trailing newline be added at the end of the file?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261018125641.23064-1-breno3011alves@gmail.com?part=3