Re: [RFC PATCH 5/5] perf/tests: convert check_errors_whitelisted.pl to Python

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] perf/tests: check_errors_whitelisted.py is unused and not installed
- [Low] perf/tests: missing trailing newline in check_errors_whitelisted.py
--

commit f4ac81889a756943e8a2c98f2bfeb3dd3b8cd1a1
Author: Breno Rodrigues Alves <breno3011alves@gmail.com>

perf/tests: convert check_errors_whitelisted.pl to Python

This patch adds a Python 3 implementation of the error whitelist checker
script in tools/perf/tests/shell/common/check_errors_whitelisted.py.

> diff --git a/tools/perf/tests/shell/common/check_errors_whitelisted.py b/tools/perf/tests/shell/common/check_errors_whitelisted.py
> new file mode 100755
> index 0000000000000..352eb1a9dd06b
> --- /dev/null
> +++ b/tools/perf/tests/shell/common/check_errors_whitelisted.py
> @@ -0,0 +1,55 @@
> +#!/usr/bin/env python3
> +# SPDX-License-Identifier: GPL-2.0
> +
> +import os
> +import re
> +import sys
> +
> +
> +def main(argv):

[Severity: Medium]
Is this conversion complete? While this patch adds check_errors_whitelisted.py,
none of the callers in tools/perf/tests/shell/base_report/test_basic.sh are
updated to use it, and instead still invoke check_errors_whitelisted.pl:

    "$DIR_PATH/../common/check_errors_whitelisted.pl" \
        "$DIR_PATH/stderr-whitelist.txt" < $LOGS_DIR/basic_basic.err

In addition, the install-tests target in tools/perf/Makefile.perf only installs
*.sh and *.pl files from tests/shell/common/ and omits *.py files:

    $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/shell/common'; \
    $(INSTALL) tests/shell/common/*.sh '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/shell/common'; \
    $(INSTALL) tests/shell/common/*.pl '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/shell/common'; \

Should test_basic.sh and Makefile.perf be updated to use and install
check_errors_whitelisted.py, and should the old
tools/perf/tests/shell/common/check_errors_whitelisted.pl file be removed?

[ ... ]

> +    return 0 if passed else 1
> +
> +
> +if __name__ == "__main__":
> +    sys.exit(main(sys.argv[1:]))
> \ No newline at end of file

[Severity: Low]
Could a trailing newline be added to the end of
tools/perf/tests/shell/common/check_errors_whitelisted.py?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261018125641.23064-1-breno3011alves@gmail.com?part=5