Linux-PHY Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Nitin Rawat <quic_nitirawa@quicinc.com>,
	vkoul@kernel.org, kishon@kernel.org,
	manivannan.sadhasivam@linaro.org,
	James.Bottomley@HansenPartnership.com,
	martin.petersen@oracle.com, bvanassche@acm.org,
	bjorande@quicinc.com, neil.armstrong@linaro.org
Cc: quic_rdwivedi@quicinc.com, linux-arm-msm@vger.kernel.org,
	linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org
Subject: Re: [PATCH V3 6/9] phy: qcom-qmp-ufs: Refactor qmp_ufs_exit callback.
Date: Wed, 23 Apr 2025 13:29:39 +0200	[thread overview]
Message-ID: <052fe049-a17f-4fa7-80f3-a198de21b3c1@oss.qualcomm.com> (raw)
In-Reply-To: <20250410090102.20781-7-quic_nitirawa@quicinc.com>

On 4/10/25 11:00 AM, Nitin Rawat wrote:
> Rename qmp_ufs_disable to qmp_ufs_power_off and refactor
> the code to move all the power off sequence to qmp_ufs_power_off.
> 
> Co-developed-by: Ram Kumar Dwivedi <quic_rdwivedi@quicinc.com>
> Signed-off-by: Ram Kumar Dwivedi <quic_rdwivedi@quicinc.com>
> Signed-off-by: Nitin Rawat <quic_nitirawa@quicinc.com>
> ---

So this patch does quite a lot without explaining the context
that isn't visible in just the diff below

- .power_on is altered to no longer reset the PHY (but it only did so
   on docs with !no_pcs_sw_reset?)
- partially inlines com_exit (dropping the reset assert)
- removes .disable in favor of .power_off that we can't tell
  what it does just by looking at this patch in the middle of the
  series

Please improve the commit message and consider splitting this change
in two

Konrad

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  reply	other threads:[~2025-04-23 13:05 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-10  9:00 [PATCH V3 0/9] Refactor phy powerup sequence Nitin Rawat
2025-04-10  9:00 ` [PATCH V3 1/9] scsi: ufs: qcom: add a new phy calibrate API call Nitin Rawat
2025-04-23 10:42   ` Konrad Dybcio
2025-04-23 11:01     ` Nitin Rawat
2025-04-10  9:00 ` [PATCH V3 2/9] phy: qcom-qmp-ufs: Rename qmp_ufs_enable and qmp_ufs_power_on Nitin Rawat
2025-04-10 20:05   ` Dmitry Baryshkov
2025-04-10  9:00 ` [PATCH V3 3/9] phy: qcom-qmp-ufs: Refactor phy_power_on and phy_calibrate callbacks Nitin Rawat
2025-04-10 20:06   ` Dmitry Baryshkov
2025-04-10  9:00 ` [PATCH V3 4/9] phy: qcom-qmp-ufs: Refactor UFS PHY reset Nitin Rawat
2025-04-10 20:08   ` Dmitry Baryshkov
2025-04-11 10:50     ` Nitin Rawat
2025-04-11 11:08       ` Dmitry Baryshkov
2025-04-14 20:34         ` Nitin Rawat
2025-04-15  9:29           ` Dmitry Baryshkov
2025-04-16  9:08             ` Nitin Rawat
2025-04-16 12:13               ` Dmitry Baryshkov
2025-04-16 12:26                 ` Nitin Rawat
2025-04-23 11:09                   ` Konrad Dybcio
2025-04-23 11:21                     ` Konrad Dybcio
2025-04-23 11:43                       ` Nitin Rawat
2025-04-23 13:47         ` Konrad Dybcio
2025-04-23 13:51           ` Dmitry Baryshkov
2025-04-10  9:00 ` [PATCH V3 5/9] phy: qcom-qmp-ufs: Remove qmp_ufs_com_init() Nitin Rawat
2025-04-10 20:09   ` Dmitry Baryshkov
2025-04-11 10:42     ` Nitin Rawat
2025-04-11 10:56       ` Dmitry Baryshkov
2025-04-14  7:28         ` Nitin Rawat
2025-04-14  7:43           ` Dmitry Baryshkov
2025-04-19 20:08             ` Nitin Rawat
2025-04-23 13:34               ` Dmitry Baryshkov
2025-04-10  9:00 ` [PATCH V3 6/9] phy: qcom-qmp-ufs: Refactor qmp_ufs_exit callback Nitin Rawat
2025-04-23 11:29   ` Konrad Dybcio [this message]
2025-04-10  9:01 ` [PATCH V3 7/9] scsi: ufs: qcom : Refactor phy_power_on/off calls Nitin Rawat
2025-04-10  9:01 ` [PATCH V3 8/9] scsi: ufs: qcom : Introduce phy_power_on/off wrapper function Nitin Rawat
2025-04-10  9:01 ` [PATCH V3 9/9] scsi: ufs: qcom: Prevent calling phy_exit before phy_init Nitin Rawat
2025-04-10 20:05 ` [PATCH V3 0/9] Refactor phy powerup sequence Dmitry Baryshkov
2025-04-11 10:35   ` Nitin Rawat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=052fe049-a17f-4fa7-80f3-a198de21b3c1@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=bjorande@quicinc.com \
    --cc=bvanassche@acm.org \
    --cc=kishon@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=martin.petersen@oracle.com \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_nitirawa@quicinc.com \
    --cc=quic_rdwivedi@quicinc.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox