[PATCH v3 0/2 RESEND] phy: renesas: r8a779f0-ether-serdes: driver enhancement

[PATCH v3 0/2 RESEND] phy: renesas: r8a779f0-ether-serdes: driver enhancement

[Michael Dege]

Hi,

This patch set adds the following to the r8a779f0-ether-serdes driver:

 * USXGMII mode support for 2.5GBit/s ethernet Phys
 * A new configuration step suggested by the latest R-Car S4-8 users
   manual V. 1.20.

Changes in v3:
- Fixed wrong macro (reported by kernel test bot).
- Link to v2: https://lore.kernel.org/r/20250527-renesas-serdes-update-v2-0-ef17c71cd94c@renesas.com

Changes from v1:
 - Modify this driver for the R-Car S4-8 only
 - So, this patch set drops the followings:
 -- any dt doc modification
 -- X5H support.
 -- 5GBASER support
 -- Registers' macros

Thanks,

Michael

Michael Dege (2):
  phy: renesas: r8a779f0-ether-serdes: add USXGMII mode
  phy: renesas: r8a779f0-ether-serdes: add new step added to latest
    datasheet

 drivers/phy/renesas/r8a779f0-ether-serdes.c | 97 ++++++++++++++++++---
 1 file changed, 85 insertions(+), 12 deletions(-)

-- 
2.25.1


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

Re: [PATCH v3 0/2 RESEND] phy: renesas: r8a779f0-ether-serdes: driver enhancement

[Vinod Koul]

Hi,

On 26-06-25, 10:17, Michael Dege wrote:
> Hi,
> 
> This patch set adds the following to the r8a779f0-ether-serdes driver:

I have a v3 and v3 resend and both are not threaded properly, Please post
properly as a series which is threaded and not broken... 
> 
>  * USXGMII mode support for 2.5GBit/s ethernet Phys
>  * A new configuration step suggested by the latest R-Car S4-8 users
>    manual V. 1.20.
> 
> Changes in v3:
> - Fixed wrong macro (reported by kernel test bot).
> - Link to v2: https://lore.kernel.org/r/20250527-renesas-serdes-update-v2-0-ef17c71cd94c@renesas.com
> 
> Changes from v1:
>  - Modify this driver for the R-Car S4-8 only
>  - So, this patch set drops the followings:
>  -- any dt doc modification
>  -- X5H support.
>  -- 5GBASER support
>  -- Registers' macros
> 
> Thanks,
> 
> Michael
> 
> Michael Dege (2):
>   phy: renesas: r8a779f0-ether-serdes: add USXGMII mode
>   phy: renesas: r8a779f0-ether-serdes: add new step added to latest
>     datasheet
> 
>  drivers/phy/renesas/r8a779f0-ether-serdes.c | 97 ++++++++++++++++++---
>  1 file changed, 85 insertions(+), 12 deletions(-)
> 
> -- 
> 2.25.1

-- 
~Vinod

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

RE: [PATCH v3 0/2 RESEND] phy: renesas: r8a779f0-ether-serdes: driver enhancement

[Michael Dege]

Hello Vinod,

> -----Original Message-----
> From: Vinod Koul <vkoul@kernel.org>
> Sent: Friday, June 27, 2025 12:59 AM
> To: Michael Dege <michael.dege@renesas.com>
> Cc: Kishon Vijay Abraham I <kishon@kernel.org>; Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>;
> Uwe Kleine-Koenig <u.kleine-koenig@baylibre.com>; linux-phy@lists.infradead.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH v3 0/2 RESEND] phy: renesas: r8a779f0-ether-serdes: driver enhancement
>
>
> Hi,
>
> On 26-06-25, 10:17, Michael Dege wrote:
> > Hi,
> >
> > This patch set adds the following to the r8a779f0-ether-serdes driver:
>
> I have a v3 and v3 resend and both are not threaded properly, Please post properly as a series which
> is threaded and not broken...

Please bear with me this is the first attempt to upstream a patch. I used b4 to produce and send this
patch series. I did have trouble when I tried to use b4 to resend. And ended up using "git send-email"
to resend.
I don't quite understand what you mean by threaded and what is broken. Could you please give
me a hint what is wrong? I am willing to learn and would like to get it right.

Best regards,

Michael

> >
> >  * USXGMII mode support for 2.5GBit/s ethernet Phys
> >  * A new configuration step suggested by the latest R-Car S4-8 users
> >    manual V. 1.20.
> >
> > Changes in v3:
> > - Fixed wrong macro (reported by kernel test bot).
> > - Link to v2:
> > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore
> > .kernel.org%2Fr%2F20250527-renesas-serdes-update-v2-0-ef17c71cd94c%40r
> > enesas.com&data=05%7C02%7Cmichael.dege%40renesas.com%7C7e7e33dfe98345c
> > af5e308ddb5050507%7C53d82571da1947e49cb4625a166a4a2a%7C0%7C0%7C6388657
> > 55354137682%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLj
> > AuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7
> > C&sdata=9sa0DnmyB5rRb4DSOlzz4%2BguzMxaMcP8W40OVS1ABZU%3D&reserved=0
> >
> > Changes from v1:
> >  - Modify this driver for the R-Car S4-8 only
> >  - So, this patch set drops the followings:
> >  -- any dt doc modification
> >  -- X5H support.
> >  -- 5GBASER support
> >  -- Registers' macros
> >
> > Thanks,
> >
> > Michael
> >
> > Michael Dege (2):
> >   phy: renesas: r8a779f0-ether-serdes: add USXGMII mode
> >   phy: renesas: r8a779f0-ether-serdes: add new step added to latest
> >     datasheet
> >
> >  drivers/phy/renesas/r8a779f0-ether-serdes.c | 97
> > ++++++++++++++++++---
> >  1 file changed, 85 insertions(+), 12 deletions(-)
> >
> > --
> > 2.25.1
>
> --
> ~Vinod
________________________________

Renesas Electronics Europe GmbH
Registered Office: Arcadiastrasse 10
DE-40472 Duesseldorf
Commercial Registry: Duesseldorf, HRB 3708
Managing Director: Carsten Jauch
VAT-No.: DE 14978647
Tax-ID-No: 105/5839/1793

Legal Disclaimer: This e-mail communication (and any attachment/s) is confidential and contains proprietary information, some or all of which may be legally privileged. It is intended solely for the use of the individual or entity to which it is addressed. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited and may be unlawful.

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

Re: [PATCH v3 0/2 RESEND] phy: renesas: r8a779f0-ether-serdes: driver enhancement

[Vinod Koul]

Hi Michael,

On 27-06-25, 04:52, Michael Dege wrote:
> > > This patch set adds the following to the r8a779f0-ether-serdes driver:
> >
> > I have a v3 and v3 resend and both are not threaded properly, Please post properly as a series which
> > is threaded and not broken...
> 
> Please bear with me this is the first attempt to upstream a patch. I used b4 to produce and send this
> patch series. I did have trouble when I tried to use b4 to resend. And ended up using "git send-email"
> to resend.
> I don't quite understand what you mean by threaded and what is broken. Could you please give
> me a hint what is wrong? I am willing to learn and would like to get it right.

See Documentation/process/5.Posting.rst
"In general, the second and following parts of a multi-part patch should be
sent as a reply to the first part so that they all thread together at the
receiving end.  Tools like git and quilt have commands to mail out a set of
patches with the proper threading. "

For me, patch 1,2 and cover letter appear as disjoint so hard to
review the patches when they are split in my inbox.
A patch series if threaded, would appear together so easy to look at it.

Said that, if you are using git send-email, easiest way is to supply the
whole patch series to it and not per patch basis
For example:
git send-email ....../dir_of_patches/

would ensure they are threaded and sent together

HTH
-- 
~Vinod

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy