[PATCH v2 0/6] BQ24190 charger fixes

[PATCH v2 0/6] BQ24190 charger fixes

[Liam Breck]

Changes in v2:

#1 reorders:            Fix irq triggering to IRQF_TRIGGER_FALLING
#2 factors out part of: Call power_supply_changed() only for relevant component
#3 replaces:            Call enable_irq() only at the end of probe()
#4 reorders:            Call power_supply_changed() only for relevant component
#5 unscrambles:         Don't read fault register outside irq_handle_thread()
#6 factors out part of: Don't read fault register outside irq_handle_thread()

These are dropped; Tony will resubmit them in new patchset:
  Check the interrupt status on resume
  Use PM runtime autosuspend

Re: [PATCH v2 0/6] BQ24190 charger fixes

[Tony Lindgren]

* Liam Breck <liam@networkimprov.net> [170115 22:06]:
> Changes in v2:
> 
> #1 reorders:            Fix irq triggering to IRQF_TRIGGER_FALLING
> #2 factors out part of: Call power_supply_changed() only for relevant component
> #3 replaces:            Call enable_irq() only at the end of probe()
> #4 reorders:            Call power_supply_changed() only for relevant component
> #5 unscrambles:         Don't read fault register outside irq_handle_thread()
> #6 factors out part of: Don't read fault register outside irq_handle_thread()

All look good to me thanks:

Acked-by: Tony Lindgren <tony@atomide.com>

> These are dropped; Tony will resubmit them in new patchset:
>   Check the interrupt status on resume
>   Use PM runtime autosuspend

Yes I'll repost those after no more comments on these.

Regards,

Tony

Re: [PATCH v2 0/6] BQ24190 charger fixes

[Mark Greer]

On Sun, Jan 15, 2017 at 10:05:26PM -0800, Liam Breck wrote:
> Changes in v2:
> 
> #1 reorders:            Fix irq triggering to IRQF_TRIGGER_FALLING
> #2 factors out part of: Call power_supply_changed() only for relevant component
> #3 replaces:            Call enable_irq() only at the end of probe()
> #4 reorders:            Call power_supply_changed() only for relevant component
> #5 unscrambles:         Don't read fault register outside irq_handle_thread()
> #6 factors out part of: Don't read fault register outside irq_handle_thread()
> 
> These are dropped; Tony will resubmit them in new patchset:
>   Check the interrupt status on resume
>   Use PM runtime autosuspend

Hi Liam - a couple notes:
- please include the full original text from v1 with the text above
  added to it;
- please thread the emails like you did with v1

Thanks,

Mark
--

Re: [PATCH v2 0/6] BQ24190 charger fixes

[Mark Greer]

On Mon, Jan 16, 2017 at 10:30:44AM -0700, Mark Greer wrote:
> On Sun, Jan 15, 2017 at 10:05:26PM -0800, Liam Breck wrote:
> > Changes in v2:
> > 
> > #1 reorders:            Fix irq triggering to IRQF_TRIGGER_FALLING
> > #2 factors out part of: Call power_supply_changed() only for relevant component
> > #3 replaces:            Call enable_irq() only at the end of probe()
> > #4 reorders:            Call power_supply_changed() only for relevant component
> > #5 unscrambles:         Don't read fault register outside irq_handle_thread()
> > #6 factors out part of: Don't read fault register outside irq_handle_thread()
> > 
> > These are dropped; Tony will resubmit them in new patchset:
> >   Check the interrupt status on resume
> >   Use PM runtime autosuspend
> 
> Hi Liam - a couple notes:
> - please include the full original text from v1 with the text above
>   added to it;
> - please thread the emails like you did with v1

- put patches inline

Re: [PATCH v2 0/6] BQ24190 charger fixes

[Liam Breck]

On Mon, Jan 16, 2017 at 9:30 AM, Mark Greer <mgreer@animalcreek.com> wrote:
> On Sun, Jan 15, 2017 at 10:05:26PM -0800, Liam Breck wrote:
>> Changes in v2:
>>
>> #1 reorders:            Fix irq triggering to IRQF_TRIGGER_FALLING
>> #2 factors out part of: Call power_supply_changed() only for relevant component
>> #3 replaces:            Call enable_irq() only at the end of probe()
>> #4 reorders:            Call power_supply_changed() only for relevant component
>> #5 unscrambles:         Don't read fault register outside irq_handle_thread()
>> #6 factors out part of: Don't read fault register outside irq_handle_thread()
>>
>> These are dropped; Tony will resubmit them in new patchset:
>>   Check the interrupt status on resume
>>   Use PM runtime autosuspend
>
> Hi Liam - a couple notes:
> - please include the full original text from v1 with the text above
>   added to it;
> - please thread the emails like you did with v1

Hi Mark. There was no v1 0/n preamble. It would have read:

"v1: Misc fixes, tested on a custom OMAP3 board."

Re: [PATCH v2 0/6] BQ24190 charger fixes

[Mark Greer]

On Mon, Jan 16, 2017 at 11:42:06AM -0800, Liam Breck wrote:
> On Mon, Jan 16, 2017 at 9:30 AM, Mark Greer <mgreer@animalcreek.com> wrote:
> > On Sun, Jan 15, 2017 at 10:05:26PM -0800, Liam Breck wrote:
> >> Changes in v2:
> >>
> >> #1 reorders:            Fix irq triggering to IRQF_TRIGGER_FALLING
> >> #2 factors out part of: Call power_supply_changed() only for relevant component
> >> #3 replaces:            Call enable_irq() only at the end of probe()
> >> #4 reorders:            Call power_supply_changed() only for relevant component
> >> #5 unscrambles:         Don't read fault register outside irq_handle_thread()
> >> #6 factors out part of: Don't read fault register outside irq_handle_thread()
> >>
> >> These are dropped; Tony will resubmit them in new patchset:
> >>   Check the interrupt status on resume
> >>   Use PM runtime autosuspend
> >
> > Hi Liam - a couple notes:
> > - please include the full original text from v1 with the text above
> >   added to it;
> > - please thread the emails like you did with v1
> 
> Hi Mark. There was no v1 0/n preamble. It would have read:
> 
> "v1: Misc fixes, tested on a custom OMAP3 board."

Okay, I assumed it was v2 following up on Tony's patch series which did
have a 0/6.  For some reason, I don't have your v1 series in my inbox -
sometimes I'm too quick with the delete button so I may have deleted it
accidentally.

Mark
--

Re: [PATCH v2 0/6] BQ24190 charger fixes

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 912 bytes --]

Hi Liam,

On Sun, Jan 15, 2017 at 10:05:26PM -0800, Liam Breck wrote:
> Changes in v2:
> 
> #1 reorders:            Fix irq triggering to IRQF_TRIGGER_FALLING
> #2 factors out part of: Call power_supply_changed() only for relevant component
> #3 replaces:            Call enable_irq() only at the end of probe()
> #4 reorders:            Call power_supply_changed() only for relevant component
> #5 unscrambles:         Don't read fault register outside irq_handle_thread()
> #6 factors out part of: Don't read fault register outside irq_handle_thread()
> 
> These are dropped; Tony will resubmit them in new patchset:
>   Check the interrupt status on resume
>   Use PM runtime autosuspend

I have no additional review comments to the ones you already
received. When you resend the patch series with Mark's comments
fixed, please don't forget to add the Acks to your patches.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]