* Re: [PATCH -next] PM / OPP: Make local function ti_opp_supply_set_opp() static
2017-12-20 5:44 [PATCH -next] PM / OPP: Make local function ti_opp_supply_set_opp() static Wei Yongjun
@ 2017-12-20 5:42 ` Viresh Kumar
2017-12-21 1:19 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Viresh Kumar @ 2017-12-20 5:42 UTC (permalink / raw)
To: Wei Yongjun, d-gerlach
Cc: Viresh Kumar, Nishanth Menon, Stephen Boyd, linux-pm, rjw
+Dave/Rafael,
On 20-12-17, 05:44, Wei Yongjun wrote:
> Fixes the following sparse warning:
>
> drivers/opp/ti-opp-supply.c:276:5: warning:
> symbol 'ti_opp_supply_set_opp' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/opp/ti-opp-supply.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/opp/ti-opp-supply.c b/drivers/opp/ti-opp-supply.c
> index 44dae3e..370eff3 100644
> --- a/drivers/opp/ti-opp-supply.c
> +++ b/drivers/opp/ti-opp-supply.c
> @@ -273,7 +273,7 @@ static int _opp_set_voltage(struct device *dev,
> *
> * Return: If successful, 0, else appropriate error value.
> */
> -int ti_opp_supply_set_opp(struct dev_pm_set_opp_data *data)
> +static int ti_opp_supply_set_opp(struct dev_pm_set_opp_data *data)
> {
> struct dev_pm_opp_supply *old_supply_vdd = &data->old_opp.supplies[0];
> struct dev_pm_opp_supply *old_supply_vbb = &data->old_opp.supplies[1];
Maybe this should be folded to the original patch ?
--
viresh
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH -next] PM / OPP: Make local function ti_opp_supply_set_opp() static
@ 2017-12-20 5:44 Wei Yongjun
2017-12-20 5:42 ` Viresh Kumar
0 siblings, 1 reply; 4+ messages in thread
From: Wei Yongjun @ 2017-12-20 5:44 UTC (permalink / raw)
To: Viresh Kumar, Nishanth Menon, Stephen Boyd; +Cc: Wei Yongjun, linux-pm
Fixes the following sparse warning:
drivers/opp/ti-opp-supply.c:276:5: warning:
symbol 'ti_opp_supply_set_opp' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/opp/ti-opp-supply.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/opp/ti-opp-supply.c b/drivers/opp/ti-opp-supply.c
index 44dae3e..370eff3 100644
--- a/drivers/opp/ti-opp-supply.c
+++ b/drivers/opp/ti-opp-supply.c
@@ -273,7 +273,7 @@ static int _opp_set_voltage(struct device *dev,
*
* Return: If successful, 0, else appropriate error value.
*/
-int ti_opp_supply_set_opp(struct dev_pm_set_opp_data *data)
+static int ti_opp_supply_set_opp(struct dev_pm_set_opp_data *data)
{
struct dev_pm_opp_supply *old_supply_vdd = &data->old_opp.supplies[0];
struct dev_pm_opp_supply *old_supply_vbb = &data->old_opp.supplies[1];
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] PM / OPP: Make local function ti_opp_supply_set_opp() static
2017-12-20 5:42 ` Viresh Kumar
@ 2017-12-21 1:19 ` Rafael J. Wysocki
2017-12-21 5:47 ` Viresh Kumar
0 siblings, 1 reply; 4+ messages in thread
From: Rafael J. Wysocki @ 2017-12-21 1:19 UTC (permalink / raw)
To: Viresh Kumar
Cc: Wei Yongjun, Dave Gerlach, Viresh Kumar, Nishanth Menon,
Stephen Boyd, Linux PM, Rafael J. Wysocki
On Wed, Dec 20, 2017 at 6:42 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> +Dave/Rafael,
>
> On 20-12-17, 05:44, Wei Yongjun wrote:
>> Fixes the following sparse warning:
>>
>> drivers/opp/ti-opp-supply.c:276:5: warning:
>> symbol 'ti_opp_supply_set_opp' was not declared. Should it be static?
>>
>> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>> ---
>> drivers/opp/ti-opp-supply.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/opp/ti-opp-supply.c b/drivers/opp/ti-opp-supply.c
>> index 44dae3e..370eff3 100644
>> --- a/drivers/opp/ti-opp-supply.c
>> +++ b/drivers/opp/ti-opp-supply.c
>> @@ -273,7 +273,7 @@ static int _opp_set_voltage(struct device *dev,
>> *
>> * Return: If successful, 0, else appropriate error value.
>> */
>> -int ti_opp_supply_set_opp(struct dev_pm_set_opp_data *data)
>> +static int ti_opp_supply_set_opp(struct dev_pm_set_opp_data *data)
>> {
>> struct dev_pm_opp_supply *old_supply_vdd = &data->old_opp.supplies[0];
>> struct dev_pm_opp_supply *old_supply_vbb = &data->old_opp.supplies[1];
>
> Maybe this should be folded to the original patch ?
That is against the latest series from Dave, right?
I can apply it.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] PM / OPP: Make local function ti_opp_supply_set_opp() static
2017-12-21 1:19 ` Rafael J. Wysocki
@ 2017-12-21 5:47 ` Viresh Kumar
0 siblings, 0 replies; 4+ messages in thread
From: Viresh Kumar @ 2017-12-21 5:47 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Wei Yongjun, Dave Gerlach, Viresh Kumar, Nishanth Menon,
Stephen Boyd, Linux PM, Rafael J. Wysocki
On 21-12-17, 02:19, Rafael J. Wysocki wrote:
> On Wed, Dec 20, 2017 at 6:42 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > +Dave/Rafael,
> >
> > On 20-12-17, 05:44, Wei Yongjun wrote:
> >> Fixes the following sparse warning:
> >>
> >> drivers/opp/ti-opp-supply.c:276:5: warning:
> >> symbol 'ti_opp_supply_set_opp' was not declared. Should it be static?
> >>
> >> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> >> ---
> >> drivers/opp/ti-opp-supply.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/opp/ti-opp-supply.c b/drivers/opp/ti-opp-supply.c
> >> index 44dae3e..370eff3 100644
> >> --- a/drivers/opp/ti-opp-supply.c
> >> +++ b/drivers/opp/ti-opp-supply.c
> >> @@ -273,7 +273,7 @@ static int _opp_set_voltage(struct device *dev,
> >> *
> >> * Return: If successful, 0, else appropriate error value.
> >> */
> >> -int ti_opp_supply_set_opp(struct dev_pm_set_opp_data *data)
> >> +static int ti_opp_supply_set_opp(struct dev_pm_set_opp_data *data)
> >> {
> >> struct dev_pm_opp_supply *old_supply_vdd = &data->old_opp.supplies[0];
> >> struct dev_pm_opp_supply *old_supply_vbb = &data->old_opp.supplies[1];
> >
> > Maybe this should be folded to the original patch ?
>
> That is against the latest series from Dave, right?
>
> I can apply it.
Yes.
--
viresh
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-12-21 5:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-20 5:44 [PATCH -next] PM / OPP: Make local function ti_opp_supply_set_opp() static Wei Yongjun
2017-12-20 5:42 ` Viresh Kumar
2017-12-21 1:19 ` Rafael J. Wysocki
2017-12-21 5:47 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox