Linux Power Management development
 help / color / mirror / Atom feed
From: Lukasz Luba <lukasz.luba@arm.com>
To: linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org,
	rafael@kernel.org
Cc: linux-pm@vger.kernel.org, rui.zhang@intel.com, lukasz.luba@arm.com
Subject: [PATCH 5/7] thermal: gov_power_allocator: Use shorter variable when possible
Date: Wed, 25 Oct 2023 20:22:23 +0100	[thread overview]
Message-ID: <20231025192225.468228-6-lukasz.luba@arm.com> (raw)
In-Reply-To: <20231025192225.468228-1-lukasz.luba@arm.com>

The 'cdev' pointer is initialed, so there is no need to use
'instance->cdev'.

This change is not expected to alter the general functionality.

Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
---
 drivers/thermal/gov_power_allocator.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/thermal/gov_power_allocator.c b/drivers/thermal/gov_power_allocator.c
index 79621b42ead38..0f7f8278eacc5 100644
--- a/drivers/thermal/gov_power_allocator.c
+++ b/drivers/thermal/gov_power_allocator.c
@@ -560,7 +560,7 @@ static void allow_maximum_power(struct thermal_zone_device *tz, bool update)
 			continue;
 
 		instance->target = 0;
-		mutex_lock(&instance->cdev->lock);
+		mutex_lock(&cdev->lock);
 		/*
 		 * Call for updating the cooling devices local stats and avoid
 		 * periods of dozen of seconds when those have not been
@@ -569,9 +569,9 @@ static void allow_maximum_power(struct thermal_zone_device *tz, bool update)
 		cdev->ops->get_requested_power(cdev, &req_power);
 
 		if (update)
-			__thermal_cdev_update(instance->cdev);
+			__thermal_cdev_update(cdev);
 
-		mutex_unlock(&instance->cdev->lock);
+		mutex_unlock(&cdev->lock);
 	}
 }
 
-- 
2.25.1


  parent reply	other threads:[~2023-10-25 19:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-25 19:22 [PATCH 0/7] Minor cleanup for thermal gov power allocator Lukasz Luba
2023-10-25 19:22 ` [PATCH 1/7] thermal: gov_power_allocator: Rename trip_max_desired_temperature Lukasz Luba
2023-10-25 19:22 ` [PATCH 2/7] thermal: gov_power_allocator: Setup trip points earlier Lukasz Luba
2023-10-25 19:22 ` [PATCH 3/7] thermal: gov_power_allocator: Check the cooling devices only for trip_max Lukasz Luba
2023-10-25 19:22 ` [PATCH 4/7] thermal: gov_power_allocator: Rearrange the order of variables Lukasz Luba
2023-10-25 19:22 ` Lukasz Luba [this message]
2023-10-25 19:22 ` [PATCH 6/7] thermal: gov_power_allocator: Remove unneeded local variables Lukasz Luba
2023-10-25 19:22 ` [PATCH 7/7] thermal: gov_power_allocator: Clean needed variables at the beginning Lukasz Luba
2023-10-26  8:54 ` [PATCH 0/7] Minor cleanup for thermal gov power allocator Rafael J. Wysocki
2023-10-26 12:22   ` Lukasz Luba
2023-11-23 15:19     ` Lukasz Luba
2023-11-23 19:50       ` Rafael J. Wysocki
2023-11-24  7:45         ` Lukasz Luba
2023-11-28 15:17           ` Rafael J. Wysocki
2023-11-28 15:32             ` Lukasz Luba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231025192225.468228-6-lukasz.luba@arm.com \
    --to=lukasz.luba@arm.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox