From: Lukasz Luba <lukasz.luba@arm.com>
To: linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org,
rafael@kernel.org
Cc: linux-pm@vger.kernel.org, rui.zhang@intel.com, lukasz.luba@arm.com
Subject: [PATCH 6/7] thermal: gov_power_allocator: Remove unneeded local variables
Date: Wed, 25 Oct 2023 20:22:24 +0100 [thread overview]
Message-ID: <20231025192225.468228-7-lukasz.luba@arm.com> (raw)
In-Reply-To: <20231025192225.468228-1-lukasz.luba@arm.com>
There is no need to keep some variables. We have a shorter name variables
in the governor private structure 'trip_max'. Remove the local 'trip_max'
and 'ret' variables from the allocate_power().
This change is not expected to alter the general functionality.
Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
---
drivers/thermal/gov_power_allocator.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/thermal/gov_power_allocator.c b/drivers/thermal/gov_power_allocator.c
index 0f7f8278eacc5..e6d2f0fe8d2fd 100644
--- a/drivers/thermal/gov_power_allocator.c
+++ b/drivers/thermal/gov_power_allocator.c
@@ -379,17 +379,16 @@ static int allocate_power(struct thermal_zone_device *tz, int control_temp)
u32 total_req_power, max_allocatable_power, total_weighted_req_power;
u32 *req_power, *max_power, *granted_power, *extra_actor_power;
struct power_allocator_params *params = tz->governor_data;
- const struct thermal_trip *trip_max = params->trip_max;
u32 total_granted_power, power_range;
struct thermal_cooling_device *cdev;
struct thermal_instance *instance;
u32 *weighted_req_power;
- int i, weight, ret = 0;
int total_weight = 0;
int num_actors = 0;
+ int i, weight;
list_for_each_entry(instance, &tz->thermal_instances, tz_node) {
- if ((instance->trip == trip_max) &&
+ if ((instance->trip == params->trip_max) &&
cdev_is_power_actor(instance->cdev)) {
num_actors++;
total_weight += instance->weight;
@@ -427,7 +426,7 @@ static int allocate_power(struct thermal_zone_device *tz, int control_temp)
list_for_each_entry(instance, &tz->thermal_instances, tz_node) {
cdev = instance->cdev;
- if (instance->trip != trip_max)
+ if (instance->trip != params->trip_max)
continue;
if (!cdev_is_power_actor(cdev))
@@ -463,7 +462,7 @@ static int allocate_power(struct thermal_zone_device *tz, int control_temp)
total_granted_power = 0;
i = 0;
list_for_each_entry(instance, &tz->thermal_instances, tz_node) {
- if (instance->trip != trip_max)
+ if (instance->trip != params->trip_max)
continue;
if (!cdev_is_power_actor(instance->cdev))
@@ -484,7 +483,7 @@ static int allocate_power(struct thermal_zone_device *tz, int control_temp)
kfree(req_power);
- return ret;
+ return 0;
}
/**
--
2.25.1
next prev parent reply other threads:[~2023-10-25 19:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 19:22 [PATCH 0/7] Minor cleanup for thermal gov power allocator Lukasz Luba
2023-10-25 19:22 ` [PATCH 1/7] thermal: gov_power_allocator: Rename trip_max_desired_temperature Lukasz Luba
2023-10-25 19:22 ` [PATCH 2/7] thermal: gov_power_allocator: Setup trip points earlier Lukasz Luba
2023-10-25 19:22 ` [PATCH 3/7] thermal: gov_power_allocator: Check the cooling devices only for trip_max Lukasz Luba
2023-10-25 19:22 ` [PATCH 4/7] thermal: gov_power_allocator: Rearrange the order of variables Lukasz Luba
2023-10-25 19:22 ` [PATCH 5/7] thermal: gov_power_allocator: Use shorter variable when possible Lukasz Luba
2023-10-25 19:22 ` Lukasz Luba [this message]
2023-10-25 19:22 ` [PATCH 7/7] thermal: gov_power_allocator: Clean needed variables at the beginning Lukasz Luba
2023-10-26 8:54 ` [PATCH 0/7] Minor cleanup for thermal gov power allocator Rafael J. Wysocki
2023-10-26 12:22 ` Lukasz Luba
2023-11-23 15:19 ` Lukasz Luba
2023-11-23 19:50 ` Rafael J. Wysocki
2023-11-24 7:45 ` Lukasz Luba
2023-11-28 15:17 ` Rafael J. Wysocki
2023-11-28 15:32 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231025192225.468228-7-lukasz.luba@arm.com \
--to=lukasz.luba@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox