public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: <perry.yuan@amd.com>, <gautham.shenoy@amd.com>
Cc: Linux PM <linux-pm@vger.kernel.org>,
	Mario Limonciello <mario.limonciello@amd.com>,
	Sibi Sankar <quic_sibis@quicinc.com>,
	"Dietmar Eggemann" <dietmar.eggemann@arm.com>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Dhruva Gole <d-gole@ti.com>, Yipeng Zou <zouyipeng@huawei.com>,
	"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>
Subject: [PATCH v14 5/5] cpufreq: Only disable boost during cpu online when using frequency tables
Date: Mon, 24 Jun 2024 16:34:00 -0500	[thread overview]
Message-ID: <20240624213400.67773-6-mario.limonciello@amd.com> (raw)
In-Reply-To: <20240624213400.67773-1-mario.limonciello@amd.com>

The behavior introduced in commit f37a4d6b4a2c ("cpufreq: Fix per-policy
boost behavior on SoCs using cpufreq_boost_set_sw()") sets up the boost
policy incorrectly when boost has been enabled by the platform firmware
initially even if a driver sets the policy up.

This is because there are no discrete entries in the frequency table.
Update that code to only run when a frequency table is present.

Fixes: f37a4d6b4a2c ("cpufreq: Fix per-policy boost behavior on SoCs using cpufreq_boost_set_sw()")
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
Cc: Sibi Sankar <quic_sibis@quicinc.com>
Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Dhruva Gole <d-gole@ti.com>
Cc: Yipeng Zou <zouyipeng@huawei.com>
Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
 drivers/cpufreq/cpufreq.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 1fdabb660231..32c119614710 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -1430,7 +1430,8 @@ static int cpufreq_online(unsigned int cpu)
 		}
 
 		/* Let the per-policy boost flag mirror the cpufreq_driver boost during init */
-		policy->boost_enabled = cpufreq_boost_enabled() && policy_has_boost_freq(policy);
+		if (policy->freq_table)
+			policy->boost_enabled = cpufreq_boost_enabled() && policy_has_boost_freq(policy);
 
 		/*
 		 * The initialization has succeeded and the policy is online.
-- 
2.43.0


  parent reply	other threads:[~2024-06-24 21:34 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-24 21:33 [PATCH v14 0/5] AMD Pstate Driver Core Performance Boost Mario Limonciello
2024-06-24 21:33 ` [PATCH v14 1/5] cpufreq: acpi: move MSR_K7_HWCR_CPB_DIS_BIT into msr-index.h Mario Limonciello
2024-06-24 21:33 ` [PATCH v14 2/5] cpufreq: amd-pstate: initialize core precision boost state Mario Limonciello
2024-06-24 21:33 ` [PATCH v14 3/5] cpufreq: amd-pstate: Cap the CPPC.max_perf to nominal_perf if CPB is off Mario Limonciello
2024-06-24 21:33 ` [PATCH v14 4/5] Documentation: cpufreq: amd-pstate: update doc for Per CPU boost control method Mario Limonciello
2024-06-25 12:03   ` Gautham R.Shenoy
2024-06-24 21:34 ` Mario Limonciello [this message]
2024-06-25  6:30   ` [PATCH v14 5/5] cpufreq: Only disable boost during cpu online when using frequency tables Viresh Kumar
2024-06-25 12:31     ` Mario Limonciello
2024-06-26  3:11       ` Viresh Kumar
2024-06-26  3:14         ` Mario Limonciello
2024-06-26  3:17           ` Viresh Kumar
2024-06-26  3:20             ` Mario Limonciello
2024-06-26  3:25               ` Viresh Kumar
2024-06-26  3:27                 ` Viresh Kumar
2024-06-26  3:33                   ` Mario Limonciello
2024-06-26  3:44                     ` Viresh Kumar
2024-06-26  3:46                       ` Mario Limonciello
2024-06-25 11:55   ` Gautham R.Shenoy
2024-06-25 12:32     ` Mario Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240624213400.67773-6-mario.limonciello@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=d-gole@ti.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=gautham.shenoy@amd.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=perry.yuan@amd.com \
    --cc=quic_sibis@quicinc.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=viresh.kumar@linaro.org \
    --cc=zouyipeng@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox