From: Mario Limonciello <mario.limonciello@amd.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: perry.yuan@amd.com, gautham.shenoy@amd.com,
Linux PM <linux-pm@vger.kernel.org>,
Sibi Sankar <quic_sibis@quicinc.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Dhruva Gole <d-gole@ti.com>, Yipeng Zou <zouyipeng@huawei.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH v14 5/5] cpufreq: Only disable boost during cpu online when using frequency tables
Date: Tue, 25 Jun 2024 22:33:13 -0500 [thread overview]
Message-ID: <31730330-c0d0-41a0-88e9-6ce2909b6c41@amd.com> (raw)
In-Reply-To: <20240626032702.fai3hlybfe6czmjd@vireshk-i7>
On 6/25/2024 22:27, Viresh Kumar wrote:
> On 26-06-24, 08:55, Viresh Kumar wrote:
>> On 25-06-24, 22:20, Mario Limonciello wrote:
>>> Yeah; that's effectively the same result as Gautham's suggestion. He had
>>> just said to change policy_has_boost_freq() for the same.
>>
>> I know. The problem is policy_has_boost_freq() (as its name suggests)
>> needs to check if the policy supports boost freqs (in a generic way)
>> and it is used at several other places and it would be wrong to hack
>> that routine to fix this problem.
>>
>> All we want here is for the core to not touch boost_enabled if the
>> policy->init() function has already done so.
>>
>>> I'll test it with yours and reconcile the better one to submit back out for
>>> v15.
>>
>> You can send it separately to be honest, and it looks like a fix, so
>> Rafael should be able to get it merged a bit sooner. Add a fixes tag
>> too.
>
> And maybe send patch for acpi-cpufreq and any other platform that is
> broken too..
>
I can take it all through the amd-pstate tree.
I'll put it at the front of the series.
I think as long as we can get it merged before ~rc6 it should be fine
for the 6.11 merge window.
next prev parent reply other threads:[~2024-06-26 3:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 21:33 [PATCH v14 0/5] AMD Pstate Driver Core Performance Boost Mario Limonciello
2024-06-24 21:33 ` [PATCH v14 1/5] cpufreq: acpi: move MSR_K7_HWCR_CPB_DIS_BIT into msr-index.h Mario Limonciello
2024-06-24 21:33 ` [PATCH v14 2/5] cpufreq: amd-pstate: initialize core precision boost state Mario Limonciello
2024-06-24 21:33 ` [PATCH v14 3/5] cpufreq: amd-pstate: Cap the CPPC.max_perf to nominal_perf if CPB is off Mario Limonciello
2024-06-24 21:33 ` [PATCH v14 4/5] Documentation: cpufreq: amd-pstate: update doc for Per CPU boost control method Mario Limonciello
2024-06-25 12:03 ` Gautham R.Shenoy
2024-06-24 21:34 ` [PATCH v14 5/5] cpufreq: Only disable boost during cpu online when using frequency tables Mario Limonciello
2024-06-25 6:30 ` Viresh Kumar
2024-06-25 12:31 ` Mario Limonciello
2024-06-26 3:11 ` Viresh Kumar
2024-06-26 3:14 ` Mario Limonciello
2024-06-26 3:17 ` Viresh Kumar
2024-06-26 3:20 ` Mario Limonciello
2024-06-26 3:25 ` Viresh Kumar
2024-06-26 3:27 ` Viresh Kumar
2024-06-26 3:33 ` Mario Limonciello [this message]
2024-06-26 3:44 ` Viresh Kumar
2024-06-26 3:46 ` Mario Limonciello
2024-06-25 11:55 ` Gautham R.Shenoy
2024-06-25 12:32 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31730330-c0d0-41a0-88e9-6ce2909b6c41@amd.com \
--to=mario.limonciello@amd.com \
--cc=d-gole@ti.com \
--cc=dietmar.eggemann@arm.com \
--cc=gautham.shenoy@amd.com \
--cc=linux-pm@vger.kernel.org \
--cc=perry.yuan@amd.com \
--cc=quic_sibis@quicinc.com \
--cc=rafael.j.wysocki@intel.com \
--cc=viresh.kumar@linaro.org \
--cc=zouyipeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox