From: Dhananjay Ugwekar <Dhananjay.Ugwekar@amd.com>
To: <peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>,
<namhyung@kernel.org>, <mark.rutland@arm.com>,
<alexander.shishkin@linux.intel.com>, <jolsa@kernel.org>,
<irogers@google.com>, <adrian.hunter@intel.com>,
<kan.liang@linux.intel.com>, <tglx@linutronix.de>, <bp@alien8.de>,
<dave.hansen@linux.intel.com>, <x86@kernel.org>,
<kees@kernel.org>, <gustavoars@kernel.org>, <rui.zhang@intel.com>,
<oleksandr@natalenko.name>
Cc: <linux-perf-users@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-hardening@vger.kernel.org>,
<ananth.narayan@amd.com>, <gautham.shenoy@amd.com>,
<kprateek.nayak@amd.com>, <ravi.bangoria@amd.com>,
<sandipan.das@amd.com>, <linux-pm@vger.kernel.org>,
<Dhananjay.Ugwekar@amd.com>
Subject: [PATCH v4 00/11] Add per-core RAPL energy counter support for AMD CPUs
Date: Thu, 11 Jul 2024 10:24:26 +0000 [thread overview]
Message-ID: <20240711102436.4432-1-Dhananjay.Ugwekar@amd.com> (raw)
Currently the energy-cores event in the power PMU aggregates energy
consumption data at a package level. On the other hand the core energy
RAPL counter in AMD CPUs has a core scope (which means the energy
consumption is recorded separately for each core). Earlier efforts to add
the core event in the power PMU had failed [1], due to the difference in
the scope of these two events. Hence, there is a need for a new core scope
PMU.
This patchset adds a new "power_per_core" PMU alongside the existing
"power" PMU, which will be responsible for collecting the new
"energy-per-core" event.
Tested the package level and core level PMU counters with workloads
pinned to different CPUs.
Results with workload pinned to CPU 1 in Core 1 on an AMD Zen4 Genoa
machine:
$ perf stat -a --per-core -e power_per_core/energy-per-core/ -- sleep 1
Performance counter stats for 'system wide':
S0-D0-C0 1 0.02 Joules power_per_core/energy-per-core/
S0-D0-C1 1 5.72 Joules power_per_core/energy-per-core/
S0-D0-C2 1 0.02 Joules power_per_core/energy-per-core/
S0-D0-C3 1 0.02 Joules power_per_core/energy-per-core/
S0-D0-C4 1 0.02 Joules power_per_core/energy-per-core/
S0-D0-C5 1 0.02 Joules power_per_core/energy-per-core/
S0-D0-C6 1 0.02 Joules power_per_core/energy-per-core/
S0-D0-C7 1 0.02 Joules power_per_core/energy-per-core/
S0-D0-C8 1 0.02 Joules power_per_core/energy-per-core/
S0-D0-C9 1 0.02 Joules power_per_core/energy-per-core/
S0-D0-C10 1 0.02 Joules power_per_core/energy-per-core/
[1]: https://lore.kernel.org/lkml/3e766f0e-37d4-0f82-3868-31b14228868d@linux.intel.com/
This patchset applies cleanly on top of v6.10-rc7 as well as latest
tip/master.
v4 changes:
* Add patch 11 which removes the unused function cpu_to_rapl_pmu()
* Add Rui's rb tag for patch 1
* Invert the pmu scope check logic in patch 2 (Peter)
* Add comments explaining the scope check in patch 2 (Peter)
* Use cpumask_var_t instead of cpumask_t in patch 5 (Peter)
* Move renaming code to patch 8 (Rui)
* Reorder the cleanup order of per-core and per-pkg PMU in patch 10 (Rui)
* Add rapl_core_hw_unit variable to store the per-core PMU unit in patch
10 (Rui)
PS: Scope check logic is still kept the same (i.e., all Intel systems being
considered as die scope), Rui will be modifying it to limit the die-scope
only to Cascadelake-AP in a future patch on top of this patchset.
v3 changes:
* Patch 1 added to introduce the logical_core_id which is unique across
the system (Prateek)
* Use the unique topology_logical_core_id() instead of
topology_core_id() (which is only unique within a package on tested
AMD and Intel systems) in Patch 10
v2 changes:
* Patches 6,7,8 added to split some changes out of the last patch
* Use container_of to get the rapl_pmus from event variable (Rui)
* Set PERF_EV_CAP_READ_ACTIVE_PKG flag only for pkg scope PMU (Rui)
* Use event id 0x1 for energy-per-core event (Rui)
* Use PERF_RAPL_PER_CORE bit instead of adding a new flag to check for
per-core counter hw support (Rui)
Dhananjay Ugwekar (10):
perf/x86/rapl: Fix the energy-pkg event for AMD CPUs
perf/x86/rapl: Rename rapl_pmu variables
perf/x86/rapl: Make rapl_model struct global
perf/x86/rapl: Move cpumask variable to rapl_pmus struct
perf/x86/rapl: Add wrapper for online/offline functions
perf/x86/rapl: Add an argument to the cleanup and init functions
perf/x86/rapl: Modify the generic variable names to *_pkg*
perf/x86/rapl: Remove the global variable rapl_msrs
perf/x86/rapl: Add per-core energy counter support for AMD CPUs
perf/x86/rapl: Remove the unused function cpu_to_rapl_pmu
K Prateek Nayak (1):
x86/topology: Introduce topology_logical_core_id()
Documentation/arch/x86/topology.rst | 4 +
arch/x86/events/rapl.c | 454 ++++++++++++++++++--------
arch/x86/include/asm/processor.h | 1 +
arch/x86/include/asm/topology.h | 1 +
arch/x86/kernel/cpu/debugfs.c | 1 +
arch/x86/kernel/cpu/topology_common.c | 1 +
6 files changed, 328 insertions(+), 134 deletions(-)
--
2.34.1
next reply other threads:[~2024-07-11 10:25 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 10:24 Dhananjay Ugwekar [this message]
2024-07-11 10:24 ` [PATCH v4 01/11] x86/topology: Introduce topology_logical_core_id() Dhananjay Ugwekar
2024-07-11 10:24 ` [PATCH v4 02/11] perf/x86/rapl: Fix the energy-pkg event for AMD CPUs Dhananjay Ugwekar
2024-07-12 2:04 ` Zhang, Rui
2024-07-12 3:28 ` Dhananjay Ugwekar
2024-07-16 8:56 ` Dhananjay Ugwekar
2024-07-11 10:24 ` [PATCH v4 03/11] perf/x86/rapl: Rename rapl_pmu variables Dhananjay Ugwekar
2024-07-12 2:14 ` Zhang, Rui
2024-07-11 10:24 ` [PATCH v4 04/11] perf/x86/rapl: Make rapl_model struct global Dhananjay Ugwekar
2024-07-12 3:03 ` Zhang, Rui
2024-07-11 10:24 ` [PATCH v4 05/11] perf/x86/rapl: Move cpumask variable to rapl_pmus struct Dhananjay Ugwekar
2024-07-12 3:07 ` Zhang, Rui
2024-07-12 3:30 ` Dhananjay Ugwekar
2024-07-11 10:24 ` [PATCH v4 06/11] perf/x86/rapl: Add wrapper for online/offline functions Dhananjay Ugwekar
2024-07-12 3:20 ` Zhang, Rui
2024-07-11 10:24 ` [PATCH v4 07/11] perf/x86/rapl: Add an argument to the cleanup and init functions Dhananjay Ugwekar
2024-07-12 3:22 ` Zhang, Rui
2024-07-11 10:24 ` [PATCH v4 08/11] perf/x86/rapl: Modify the generic variable names to *_pkg* Dhananjay Ugwekar
2024-07-12 3:28 ` Zhang, Rui
2024-07-11 10:24 ` [PATCH v4 09/11] perf/x86/rapl: Remove the global variable rapl_msrs Dhananjay Ugwekar
2024-07-12 3:29 ` Zhang, Rui
2024-07-11 10:24 ` [PATCH v4 10/11] perf/x86/rapl: Add per-core energy counter support for AMD CPUs Dhananjay Ugwekar
2024-07-12 6:15 ` Zhang, Rui
2024-07-11 10:24 ` [PATCH v4 11/11] perf/x86/rapl: Remove the unused function cpu_to_rapl_pmu Dhananjay Ugwekar
2024-07-11 22:23 ` [PATCH v4 00/11] Add per-core RAPL energy counter support for AMD CPUs Ian Rogers
2024-07-15 9:35 ` Dhananjay Ugwekar
2024-07-15 15:22 ` Ian Rogers
2024-07-16 8:42 ` Dhananjay Ugwekar
2024-07-16 22:47 ` Ian Rogers
2024-07-17 8:04 ` Dhananjay Ugwekar
2024-07-17 15:36 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240711102436.4432-1-Dhananjay.Ugwekar@amd.com \
--to=dhananjay.ugwekar@amd.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ananth.narayan@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=gautham.shenoy@amd.com \
--cc=gustavoars@kernel.org \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=kees@kernel.org \
--cc=kprateek.nayak@amd.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=oleksandr@natalenko.name \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=rui.zhang@intel.com \
--cc=sandipan.das@amd.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox