public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: Dhananjay Ugwekar <Dhananjay.Ugwekar@amd.com>
To: <peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>,
	<namhyung@kernel.org>, <mark.rutland@arm.com>,
	<alexander.shishkin@linux.intel.com>, <jolsa@kernel.org>,
	<irogers@google.com>, <adrian.hunter@intel.com>,
	<kan.liang@linux.intel.com>, <tglx@linutronix.de>, <bp@alien8.de>,
	<dave.hansen@linux.intel.com>, <x86@kernel.org>,
	<kees@kernel.org>, <gustavoars@kernel.org>, <rui.zhang@intel.com>,
	<oleksandr@natalenko.name>
Cc: <linux-perf-users@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-hardening@vger.kernel.org>,
	<ananth.narayan@amd.com>, <gautham.shenoy@amd.com>,
	<kprateek.nayak@amd.com>, <ravi.bangoria@amd.com>,
	<sandipan.das@amd.com>, <linux-pm@vger.kernel.org>,
	<Dhananjay.Ugwekar@amd.com>
Subject: [PATCH v4 09/11] perf/x86/rapl: Remove the global variable rapl_msrs
Date: Thu, 11 Jul 2024 10:24:37 +0000	[thread overview]
Message-ID: <20240711102436.4432-10-Dhananjay.Ugwekar@amd.com> (raw)
In-Reply-To: <20240711102436.4432-1-Dhananjay.Ugwekar@amd.com>

After making the rapl_model struct global, the rapl_msrs global
variable isn't needed, so remove it.

Also it will be cleaner when new per-core scope PMU is added. As we will
need to maintain two rapl_msrs array(one for per-core scope and one for
package scope PMU), inside the rapl_model struct.

Signed-off-by: Dhananjay Ugwekar <Dhananjay.Ugwekar@amd.com>
---
 arch/x86/events/rapl.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/arch/x86/events/rapl.c b/arch/x86/events/rapl.c
index 9beded3d4a14..7691497042e9 100644
--- a/arch/x86/events/rapl.c
+++ b/arch/x86/events/rapl.c
@@ -145,7 +145,6 @@ static int rapl_pkg_hw_unit[NR_RAPL_PKG_DOMAINS] __read_mostly;
 static struct rapl_pmus *rapl_pmus_pkg;
 static unsigned int rapl_pkg_cntr_mask;
 static u64 rapl_timer_ms;
-static struct perf_msr *rapl_msrs;
 static struct rapl_model *rapl_model;
 
 /*
@@ -387,7 +386,7 @@ static int rapl_pmu_event_init(struct perf_event *event)
 		return -EINVAL;
 	event->cpu = rapl_pmu->cpu;
 	event->pmu_private = rapl_pmu;
-	event->hw.event_base = rapl_msrs[bit].msr;
+	event->hw.event_base = rapl_model->rapl_msrs[bit].msr;
 	event->hw.config = cfg;
 	event->hw.idx = bit;
 
@@ -875,9 +874,7 @@ static int __init rapl_pmu_init(void)
 
 	rapl_model = (struct rapl_model *) id->driver_data;
 
-	rapl_msrs = rapl_model->rapl_pkg_msrs;
-
-	rapl_pkg_cntr_mask = perf_msr_probe(rapl_msrs, PERF_RAPL_PKG_EVENTS_MAX,
+	rapl_pkg_cntr_mask = perf_msr_probe(rapl_model->rapl_msrs, PERF_RAPL_PKG_EVENTS_MAX,
 					false, (void *) &rapl_model->pkg_events);
 
 	ret = rapl_check_hw_unit();
-- 
2.34.1


  parent reply	other threads:[~2024-07-11 10:30 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-11 10:24 [PATCH v4 00/11] Add per-core RAPL energy counter support for AMD CPUs Dhananjay Ugwekar
2024-07-11 10:24 ` [PATCH v4 01/11] x86/topology: Introduce topology_logical_core_id() Dhananjay Ugwekar
2024-07-11 10:24 ` [PATCH v4 02/11] perf/x86/rapl: Fix the energy-pkg event for AMD CPUs Dhananjay Ugwekar
2024-07-12  2:04   ` Zhang, Rui
2024-07-12  3:28     ` Dhananjay Ugwekar
2024-07-16  8:56   ` Dhananjay Ugwekar
2024-07-11 10:24 ` [PATCH v4 03/11] perf/x86/rapl: Rename rapl_pmu variables Dhananjay Ugwekar
2024-07-12  2:14   ` Zhang, Rui
2024-07-11 10:24 ` [PATCH v4 04/11] perf/x86/rapl: Make rapl_model struct global Dhananjay Ugwekar
2024-07-12  3:03   ` Zhang, Rui
2024-07-11 10:24 ` [PATCH v4 05/11] perf/x86/rapl: Move cpumask variable to rapl_pmus struct Dhananjay Ugwekar
2024-07-12  3:07   ` Zhang, Rui
2024-07-12  3:30     ` Dhananjay Ugwekar
2024-07-11 10:24 ` [PATCH v4 06/11] perf/x86/rapl: Add wrapper for online/offline functions Dhananjay Ugwekar
2024-07-12  3:20   ` Zhang, Rui
2024-07-11 10:24 ` [PATCH v4 07/11] perf/x86/rapl: Add an argument to the cleanup and init functions Dhananjay Ugwekar
2024-07-12  3:22   ` Zhang, Rui
2024-07-11 10:24 ` [PATCH v4 08/11] perf/x86/rapl: Modify the generic variable names to *_pkg* Dhananjay Ugwekar
2024-07-12  3:28   ` Zhang, Rui
2024-07-11 10:24 ` Dhananjay Ugwekar [this message]
2024-07-12  3:29   ` [PATCH v4 09/11] perf/x86/rapl: Remove the global variable rapl_msrs Zhang, Rui
2024-07-11 10:24 ` [PATCH v4 10/11] perf/x86/rapl: Add per-core energy counter support for AMD CPUs Dhananjay Ugwekar
2024-07-12  6:15   ` Zhang, Rui
2024-07-11 10:24 ` [PATCH v4 11/11] perf/x86/rapl: Remove the unused function cpu_to_rapl_pmu Dhananjay Ugwekar
2024-07-11 22:23 ` [PATCH v4 00/11] Add per-core RAPL energy counter support for AMD CPUs Ian Rogers
2024-07-15  9:35   ` Dhananjay Ugwekar
2024-07-15 15:22     ` Ian Rogers
2024-07-16  8:42       ` Dhananjay Ugwekar
2024-07-16 22:47         ` Ian Rogers
2024-07-17  8:04           ` Dhananjay Ugwekar
2024-07-17 15:36             ` Ian Rogers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240711102436.4432-10-Dhananjay.Ugwekar@amd.com \
    --to=dhananjay.ugwekar@amd.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=ananth.narayan@amd.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=gautham.shenoy@amd.com \
    --cc=gustavoars@kernel.org \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=kees@kernel.org \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=oleksandr@natalenko.name \
    --cc=peterz@infradead.org \
    --cc=ravi.bangoria@amd.com \
    --cc=rui.zhang@intel.com \
    --cc=sandipan.das@amd.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox