Linux RAID subsystem development
 help / color / mirror / Atom feed
From: Adam Kwolek <adam.kwolek@intel.com>
To: neilb@suse.de
Cc: linux-raid@vger.kernel.org, dan.j.williams@intel.com,
	ed.ciechanowski@intel.com, wojciech.neubauer@intel.com
Subject: [PATCH 1/9] FIX: Do not configure and start, already started reshape
Date: Wed, 02 Mar 2011 14:29:04 +0100	[thread overview]
Message-ID: <20110302132904.24771.65588.stgit@gklab-128-013.igk.intel.com> (raw)
In-Reply-To: <20110302132426.24771.99191.stgit@gklab-128-013.igk.intel.com>

When Grow_continue() calls reshape_array(), reshape is configured
and it is started with array. We cannot start reshape again,
when reshape is in progress.
/it in fact waits due to array_state == 'readonly'/

Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
---

 Grow.c |   12 +++++++++---
 1 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/Grow.c b/Grow.c
index e321a39..d25b71d 100644
--- a/Grow.c
+++ b/Grow.c
@@ -1641,6 +1641,7 @@ static int reshape_array(char *container, int fd, char *devname,
 	unsigned long long array_size;
 	int done;
 	struct mdinfo *sra = NULL;
+	int already_running;
 
 	msg = analyse_change(info, &reshape);
 	if (msg) {
@@ -1995,10 +1996,15 @@ started:
 		}
 	}
 
-	err = start_reshape(sra, (info->reshape_active && !st->ss->external));
+	already_running = info->reshape_active &&
+		restart ? restart : !st->ss->external;
+	dprintf("Reshape will be %s\n",
+		already_running ? "continued" : "started");
+	err = start_reshape(sra, already_running);
 	if (err) {
-		fprintf(stderr, Name ": Cannot start reshape for %s\n",
-			devname);
+		fprintf(stderr, Name ": Cannot %s reshape for %s\n",
+				already_running ? "continue" : "start",
+				devname);
 		goto release;
 	}
 	if (restart)


  reply	other threads:[~2011-03-02 13:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-02 13:28 [PATCH 0/9] Grow_continue() - single array Adam Kwolek
2011-03-02 13:29 ` Adam Kwolek [this message]
2011-03-02 13:29 ` [PATCH 2/9] FIX: Array during reshape cannot be configured Adam Kwolek
2011-03-02 13:29 ` [PATCH 3/9] imsm: FIX: Return blocks_per unit for general migration Adam Kwolek
2011-03-02 13:29 ` [PATCH 4/9] imsm: FIX: After checkpoint mark array have to be clean Adam Kwolek
2011-03-08  5:07   ` NeilBrown
2011-03-08  8:52     ` Kwolek, Adam
2011-03-08 22:14       ` NeilBrown
2011-03-09  7:31         ` Kwolek, Adam
2011-03-02 13:29 ` [PATCH 5/9] FIX: Continue reshape in the background Adam Kwolek
2011-03-02 13:29 ` [PATCH 6/9] FIX: Verify Backup file name before reshape Adam Kwolek
2011-03-02 13:29 ` [PATCH 7/9] FIX: Set 'new' geometry when assembling reshaped array Adam Kwolek
2011-03-02 13:29 ` [PATCH 8/9] FIX: Block array monitoring " Adam Kwolek
2011-03-02 13:30 ` [PATCH 9/9] imsm: FIX: Variables declaration cleanup Adam Kwolek
2011-03-08  6:43 ` [PATCH 0/9] Grow_continue() - single array NeilBrown
2011-03-08 11:18   ` Kwolek, Adam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110302132904.24771.65588.stgit@gklab-128-013.igk.intel.com \
    --to=adam.kwolek@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=ed.ciechanowski@intel.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=wojciech.neubauer@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox