From: NeilBrown <neilb@suse.de>
To: Adam Kwolek <adam.kwolek@intel.com>
Cc: linux-raid@vger.kernel.org, dan.j.williams@intel.com,
ed.ciechanowski@intel.com, wojciech.neubauer@intel.com
Subject: Re: [PATCH 0/9] Grow_continue() - single array.
Date: Tue, 8 Mar 2011 17:43:17 +1100 [thread overview]
Message-ID: <20110308174317.489684f1@notabene.brown> (raw)
In-Reply-To: <20110302132426.24771.99191.stgit@gklab-128-013.igk.intel.com>
Hi Adam,
I've reviewed this set of patches, applied a few of them, and
made some patches of my own that should achieve the result that I think you
were aiming for. I haven't tested them so there might still be some
issues...
Two important points.
1/ I now require getinfo_super and container_content to present a
reshape_active array in a form that md can cope with it. So a
RAID0 array that is in the middle of a reshape must appear to be
a RAID4 or RAID5 array.
I have changed super-intel to do this, but I have probably missed
some cases - please check that all supported migrations that cannot
be handled directly are handled by the new code.
With this in place, I have changed sysfs_set_array to set up all
the geometry of the array, both old and new. I think this makes
a lot of things a lot cleaner.
2/ I've revised how to handle the restart of a container-wide
migration.
As there is only one array in such a container that is actually
migrating, the mdadm which assembles it can be the one that forks
and managed the whole container.
This now happens. The metadata informs metadata that a container-wide
reshape is needed by setting ->reshape_active to '2'.
I have added a 'freeze' call where I think it should go but I wouldn't be at
all surprised if I got it wrong.
Please review the patch - which are all in my devel-3.2 branch
http://neil.brown.name/git?p=mdadm;a=log;h=refs/heads/devel-3.2
and let me know what you think.
Thanks,
NeilBrown
next prev parent reply other threads:[~2011-03-08 6:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 13:28 [PATCH 0/9] Grow_continue() - single array Adam Kwolek
2011-03-02 13:29 ` [PATCH 1/9] FIX: Do not configure and start, already started reshape Adam Kwolek
2011-03-02 13:29 ` [PATCH 2/9] FIX: Array during reshape cannot be configured Adam Kwolek
2011-03-02 13:29 ` [PATCH 3/9] imsm: FIX: Return blocks_per unit for general migration Adam Kwolek
2011-03-02 13:29 ` [PATCH 4/9] imsm: FIX: After checkpoint mark array have to be clean Adam Kwolek
2011-03-08 5:07 ` NeilBrown
2011-03-08 8:52 ` Kwolek, Adam
2011-03-08 22:14 ` NeilBrown
2011-03-09 7:31 ` Kwolek, Adam
2011-03-02 13:29 ` [PATCH 5/9] FIX: Continue reshape in the background Adam Kwolek
2011-03-02 13:29 ` [PATCH 6/9] FIX: Verify Backup file name before reshape Adam Kwolek
2011-03-02 13:29 ` [PATCH 7/9] FIX: Set 'new' geometry when assembling reshaped array Adam Kwolek
2011-03-02 13:29 ` [PATCH 8/9] FIX: Block array monitoring " Adam Kwolek
2011-03-02 13:30 ` [PATCH 9/9] imsm: FIX: Variables declaration cleanup Adam Kwolek
2011-03-08 6:43 ` NeilBrown [this message]
2011-03-08 11:18 ` [PATCH 0/9] Grow_continue() - single array Kwolek, Adam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110308174317.489684f1@notabene.brown \
--to=neilb@suse.de \
--cc=adam.kwolek@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=wojciech.neubauer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox