From: Adam Kwolek <adam.kwolek@intel.com>
To: neilb@suse.de
Cc: linux-raid@vger.kernel.org, dan.j.williams@intel.com,
ed.ciechanowski@intel.com, wojciech.neubauer@intel.com
Subject: [PATCH 5/9] FIX: Continue reshape in the background
Date: Wed, 02 Mar 2011 14:29:35 +0100 [thread overview]
Message-ID: <20110302132935.24771.4330.stgit@gklab-128-013.igk.intel.com> (raw)
In-Reply-To: <20110302132426.24771.99191.stgit@gklab-128-013.igk.intel.com>
For external metadada, reshape will be continued in the background.
Reshape_array() makes fork itself, but for container operation support
we need a place to wait for reshape begin when current array reshape
time comes /reshapes has to be run in sequence/.
In such case Grow_continue() is responsible for unfreezing array
after return from reshape_array() function.
Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
---
Assemble.c | 4 ++++
Grow.c | 26 ++++++++++++++++++++++++--
2 files changed, 28 insertions(+), 2 deletions(-)
diff --git a/Assemble.c b/Assemble.c
index ee5fcec..e31462d 100644
--- a/Assemble.c
+++ b/Assemble.c
@@ -703,6 +703,10 @@ int Assemble(struct supertype *st, char *mddev,
/* check if reshape of external metadata
* is in progress
* and it is need to be monitored by mdadm
+ * ToDo:
+ * For container operation this simple check:
+ * if (content->reshape_active)
+ * has to be replaced by container operation check
*/
if (content->reshape_active)
err = Grow_continue(mdfd, st, content,
diff --git a/Grow.c b/Grow.c
index ee75352..5176425 100644
--- a/Grow.c
+++ b/Grow.c
@@ -3332,6 +3332,7 @@ int Grow_continue(int mdfd, struct supertype *st, struct mdinfo *info,
char buf[40];
char *container = NULL;
int err;
+ int forked = 0;
if (!st->ss->external) {
err = sysfs_set_str(info, NULL, "array_state", "readonly");
@@ -3340,9 +3341,30 @@ int Grow_continue(int mdfd, struct supertype *st, struct mdinfo *info,
} else {
fmt_devname(buf, st->container_dev);
container = buf;
+ switch (fork()) {
+ case -1:
+ fprintf(stderr, Name ": Cannot run child to "
+ "monitor reshape: %s\n", strerror(errno));
+ return 1;
+ default:
+ return 0;
+ case 0:
+ dprintf(Name ": Continue bacground reshape "
+ "after assemblation\n");
+ forked = 1;
+ /* ToDo:
+ * Wait here during container operation,
+ * if this array has to be reshaped now
+ */
+ }
}
- return reshape_array(container, mdfd, "array", st, info, 1,
- backup_file, 0, 0, 1);
+
+ err = reshape_array(container, mdfd, "array", st, info, 1,
+ backup_file, 0, forked, 1);
+ if (forked)
+ unblock_subarray(info, 0);
+
+ return err;
}
next prev parent reply other threads:[~2011-03-02 13:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 13:28 [PATCH 0/9] Grow_continue() - single array Adam Kwolek
2011-03-02 13:29 ` [PATCH 1/9] FIX: Do not configure and start, already started reshape Adam Kwolek
2011-03-02 13:29 ` [PATCH 2/9] FIX: Array during reshape cannot be configured Adam Kwolek
2011-03-02 13:29 ` [PATCH 3/9] imsm: FIX: Return blocks_per unit for general migration Adam Kwolek
2011-03-02 13:29 ` [PATCH 4/9] imsm: FIX: After checkpoint mark array have to be clean Adam Kwolek
2011-03-08 5:07 ` NeilBrown
2011-03-08 8:52 ` Kwolek, Adam
2011-03-08 22:14 ` NeilBrown
2011-03-09 7:31 ` Kwolek, Adam
2011-03-02 13:29 ` Adam Kwolek [this message]
2011-03-02 13:29 ` [PATCH 6/9] FIX: Verify Backup file name before reshape Adam Kwolek
2011-03-02 13:29 ` [PATCH 7/9] FIX: Set 'new' geometry when assembling reshaped array Adam Kwolek
2011-03-02 13:29 ` [PATCH 8/9] FIX: Block array monitoring " Adam Kwolek
2011-03-02 13:30 ` [PATCH 9/9] imsm: FIX: Variables declaration cleanup Adam Kwolek
2011-03-08 6:43 ` [PATCH 0/9] Grow_continue() - single array NeilBrown
2011-03-08 11:18 ` Kwolek, Adam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110302132935.24771.4330.stgit@gklab-128-013.igk.intel.com \
--to=adam.kwolek@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=wojciech.neubauer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox