Re: [PATCH 4/9] imsm: FIX: After checkpoint mark array have to be clean

[NeilBrown <neilb@suse.de>]

On Wed, 02 Mar 2011 14:29:27 +0100 Adam Kwolek <adam.kwolek@intel.com> wrote:

> When checkpoint is marked set volume as clean.
> Reshape on dirty volume cannot be restarted from checkpoint.
> 
> Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
> ---
> 
>  super-intel.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/super-intel.c b/super-intel.c
> index 11972f3..04e32ae 100644
> --- a/super-intel.c
> +++ b/super-intel.c
> @@ -5218,6 +5218,7 @@ static int imsm_set_array_state(struct active_array *a, int consistent)
>  				    __le32_to_cpu(dev->vol.curr_migr_unit)) {
>  					dev->vol.curr_migr_unit =
>  						__cpu_to_le32(unit);
> +					dev->vol.dirty = 0;
>  					super->updates_pending++;
>  				}
>  			}
> 

hi Adam,
 You'll need to explain this one a bit more.

 If the array isn't clean, then it is wrong to mark it as clean.
 If it is clean, then 'consistent' should be 'true' and it will
 be marked clean anyway.

 Why cannot a reshape of a dirty volume be restarted from a checkpoint?
 I would think it would continue with the reshape and then when that
 finished, go back and do the resync.

NeilBrown