* [PATCH v1 for-rc] RDMA/vmw_pvrdma: Fix the active_speed and phys_state value
@ 2020-11-02 22:54 Adit Ranadive
2020-11-03 0:02 ` Jason Gunthorpe
0 siblings, 1 reply; 2+ messages in thread
From: Adit Ranadive @ 2020-11-02 22:54 UTC (permalink / raw)
To: jgg, dledford, linux-rdma; +Cc: Adit Ranadive, pv-drivers
The PVRDMA device still reports the active_speed in u8.
The pvrdma_port_attr structure is used by the device to report the
port attributes in the device API query port response structure -
pvrdma_cmd_query_port_resp - and shouldn't be changed.
Fixes: 376ceb31ff87 ("RDMA: Fix link active_speed size")
Reviewed-by: Vishnu Dasa <vdasa@vmware.com>
Signed-off-by: Adit Ranadive <aditr@vmware.com>
---
Changelog:
- v0->v1: Reverted the structure layout only as per Jason. Updated description.
---
drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.h b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.h
index f0e5ffba2d51..97ed8f952f6e 100644
--- a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.h
+++ b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.h
@@ -176,7 +176,7 @@ struct pvrdma_port_attr {
u8 subnet_timeout;
u8 init_type_reply;
u8 active_width;
- u16 active_speed;
+ u8 active_speed;
u8 phys_state;
u8 reserved[2];
};
--
2.18.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1 for-rc] RDMA/vmw_pvrdma: Fix the active_speed and phys_state value
2020-11-02 22:54 [PATCH v1 for-rc] RDMA/vmw_pvrdma: Fix the active_speed and phys_state value Adit Ranadive
@ 2020-11-03 0:02 ` Jason Gunthorpe
0 siblings, 0 replies; 2+ messages in thread
From: Jason Gunthorpe @ 2020-11-03 0:02 UTC (permalink / raw)
To: Adit Ranadive; +Cc: dledford, linux-rdma, pv-drivers
On Mon, Nov 02, 2020 at 10:54:37PM +0000, Adit Ranadive wrote:
> The PVRDMA device still reports the active_speed in u8.
> The pvrdma_port_attr structure is used by the device to report the
> port attributes in the device API query port response structure -
> pvrdma_cmd_query_port_resp - and shouldn't be changed.
>
> Fixes: 376ceb31ff87 ("RDMA: Fix link active_speed size")
> Reviewed-by: Vishnu Dasa <vdasa@vmware.com>
> Signed-off-by: Adit Ranadive <aditr@vmware.com>
> ---
>
> Changelog:
> - v0->v1: Reverted the structure layout only as per Jason. Updated description.
> ---
> drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-rc
If you think it is better you can send another patch to use the
ib_get_eth_speed() function
Also please send a patch to move all of these ABI structs into the
pvrdma_dev_api.h - ABI structures should not be strewn randomly over
header files, it leads to mistakes like this.
Thanks,
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-03 0:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-02 22:54 [PATCH v1 for-rc] RDMA/vmw_pvrdma: Fix the active_speed and phys_state value Adit Ranadive
2020-11-03 0:02 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox