public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: "Margolin, Michael" <mrgolin@amazon.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Leon Romanovsky <leon@kernel.org>, <linux-rdma@vger.kernel.org>,
	<sleybo@amazon.com>, <matua@amazon.com>, <gal.pressman@linux.dev>,
	"Daniel Kranzdorf" <dkkranzd@amazon.com>,
	Yonatan Nachum <ynachum@amazon.com>
Subject: Re: [PATCH for-next] RDMA/efa: Add CQ with external memory support
Date: Mon, 9 Jun 2025 18:03:32 +0300	[thread overview]
Message-ID: <83eb7ecd-ac1e-4472-a688-bc3f22900546@amazon.com> (raw)
In-Reply-To: <cb06d3d2-a8c2-459a-af32-bcbbdaa297b6@amazon.com>


On 5/26/2025 7:17 PM, Margolin, Michael wrote:
>
> On 5/26/2025 7:08 PM, Jason Gunthorpe wrote:
>> CAUTION: This email originated from outside of the organization. Do 
>> not click links or open attachments unless you can confirm the sender 
>> and know the content is safe.
>>
>>
>>
>> On Mon, May 26, 2025 at 06:45:59PM +0300, Margolin, Michael wrote:
>>
>>> Are you suggesting turning mlx5dv_devx_umem_reg into a common verb 
>>> including
>>> the kernel part or some kind of rdma-core level abstraction for passing
>>> dmabuf+offset+length / address+length to a create CQ/QP function?
>> I think Leon was, but I'm not sure that is so worthwhile.
>>
>> I was thinking more of having the ioctls for things like QP/CQ/MR
>> accept a more standard common set of attributes to describe the buffer
>> memory and then making it simpler for the driver to get a umem from
>> those common attributes.
>>
>> But EFA is alread sort of different because it normally uses a kernel
>> allocated buffer, right?
>>
>> Jason
>
> Yes, EFA is an example for a driver that doesn't need this on the 
> "standard" flow.
>
> Michael
>
How can we move forward with this patch? It's possible to add additional 
attributes to the common create CQ ioctl and use it for EFA direct verbs 
but it won't be easy to move existing drivers to use it.


Michael


  reply	other threads:[~2025-06-09 15:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-15 14:50 [PATCH for-next] RDMA/efa: Add CQ with external memory support Michael Margolin
2025-05-18  6:42 ` Leon Romanovsky
2025-05-18  8:56   ` Margolin, Michael
2025-05-20  9:16     ` Leon Romanovsky
2025-05-21 15:19       ` Margolin, Michael
2025-05-25 17:52         ` Jason Gunthorpe
2025-05-26 15:45           ` Margolin, Michael
2025-05-26 16:08             ` Jason Gunthorpe
2025-05-26 16:17               ` Margolin, Michael
2025-06-09 15:03                 ` Margolin, Michael [this message]
2025-06-11 19:47                   ` Jason Gunthorpe
2025-06-24 16:39                     ` Margolin, Michael

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83eb7ecd-ac1e-4472-a688-bc3f22900546@amazon.com \
    --to=mrgolin@amazon.com \
    --cc=dkkranzd@amazon.com \
    --cc=gal.pressman@linux.dev \
    --cc=jgg@nvidia.com \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=matua@amazon.com \
    --cc=sleybo@amazon.com \
    --cc=ynachum@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox