From: "Margolin, Michael" <mrgolin@amazon.com>
To: Leon Romanovsky <leon@kernel.org>, <jgg@nvidia.com>
Cc: <linux-rdma@vger.kernel.org>, <sleybo@amazon.com>,
<matua@amazon.com>, <gal.pressman@linux.dev>,
Daniel Kranzdorf <dkkranzd@amazon.com>,
"Yonatan Nachum" <ynachum@amazon.com>
Subject: Re: [PATCH for-next] RDMA/efa: Add CQ with external memory support
Date: Wed, 21 May 2025 18:19:51 +0300 [thread overview]
Message-ID: <9ae80a03-e31b-4f33-8900-541a27e30eac@amazon.com> (raw)
In-Reply-To: <20250520091638.GF7435@unreal>
On 5/20/2025 12:16 PM, Leon Romanovsky wrote:
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
>
>
>
> On Sun, May 18, 2025 at 11:56:56AM +0300, Margolin, Michael wrote:
>> On 5/18/2025 9:42 AM, Leon Romanovsky wrote:
>>> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
>>>
>>>
>>>
>>> On Thu, May 15, 2025 at 02:50:40PM +0000, Michael Margolin wrote:
>>>> Add an option to create CQ using external memory instead of allocating
>>>> in the driver. The memory can be passed from userspace by dmabuf fd and
>>>> an offset.
>>> EFA is unique here. This patch is missing description of why it is
>>> needed, and why existing solutions if any exist, can't be used.
>>>
>>> Thanks
>> I probably should have explained more, the purpose is creating CQs that
>> reside in GPU HBM enabling low latency polling directly by the GPU. EFA
>> isn't unique in receiving pre-allocated memory from userspace, the extension
>> here is the use of dmabuf for that purpose as a general mechanism that
>> allows using memory independent of its source. I will add more info in the
>> commit message.
> I think that this functionality is worth to have as general verb and not DV.
> mlx5 has something similar and now EFA needs it too.
>
> Let's wait for Jason's response before rushing to implement it.
>
> Thanks
Jason, any thoughts on this?
We can probably add optional attributes to create CQ command, but most
of the handling will remain vendor specific. I'm not convinced it's
beneficial enough.
Michael
next prev parent reply other threads:[~2025-05-21 15:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 14:50 [PATCH for-next] RDMA/efa: Add CQ with external memory support Michael Margolin
2025-05-18 6:42 ` Leon Romanovsky
2025-05-18 8:56 ` Margolin, Michael
2025-05-20 9:16 ` Leon Romanovsky
2025-05-21 15:19 ` Margolin, Michael [this message]
2025-05-25 17:52 ` Jason Gunthorpe
2025-05-26 15:45 ` Margolin, Michael
2025-05-26 16:08 ` Jason Gunthorpe
2025-05-26 16:17 ` Margolin, Michael
2025-06-09 15:03 ` Margolin, Michael
2025-06-11 19:47 ` Jason Gunthorpe
2025-06-24 16:39 ` Margolin, Michael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ae80a03-e31b-4f33-8900-541a27e30eac@amazon.com \
--to=mrgolin@amazon.com \
--cc=dkkranzd@amazon.com \
--cc=gal.pressman@linux.dev \
--cc=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=matua@amazon.com \
--cc=sleybo@amazon.com \
--cc=ynachum@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox