* [PATCH] ARM: dts: porter: add sound support [not found] <1674850.BZpGW9kEud@wasted.cogentembedded.com> @ 2016-01-21 22:36 ` Sergei Shtylyov 2016-01-25 0:35 ` Kuninori Morimoto 2016-01-26 22:14 ` [PATCH] ARM: dts: porter: add MAX3355 support Sergei Shtylyov ` (4 subsequent siblings) 5 siblings, 1 reply; 25+ messages in thread From: Sergei Shtylyov @ 2016-01-21 22:36 UTC (permalink / raw) To: horms, linux-renesas-soc, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, devicetree Cc: magnus.damm, linux, linux-arm-kernel Define the Porter board dependent part of the R8A7791 sound device node. Add device node for Asahi Kasei AK4642 stereo codec to the I2C2 bus. Add the "simple-audio-card" device node to interconnect the SoC sound device and the codec. Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- This patch is against 'renesas-devel-20160121-v4.4' tag of Simon Horman's 'renesas.git' repo. arch/arm/boot/dts/r8a7791-porter.dts | 71 +++++++++++++++++++++++++++++++++++ 1 file changed, 71 insertions(+) Index: renesas/arch/arm/boot/dts/r8a7791-porter.dts =================================================================== --- renesas.orig/arch/arm/boot/dts/r8a7791-porter.dts +++ renesas/arch/arm/boot/dts/r8a7791-porter.dts @@ -8,6 +8,17 @@ * kind, whether express or implied. */ +/* + * SSI-AK4642 + * + * SW3: 1: AK4642 + * 3: ADV7511 + * + * This command is required before playback/capture: + * + * amixer set "LINEOUT Mixer DACL" on + */ + /dts-v1/; #include "r8a7791.dtsi" #include <dt-bindings/gpio/gpio.h> @@ -101,6 +112,30 @@ #clock-cells = <0>; clock-frequency = <74250000>; }; + + x14_clk: x14-clock { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <11289600>; + clock-output-names = "audio_clock"; + }; + + sound { + compatible = "simple-audio-card"; + + simple-audio-card,format = "left_j"; + simple-audio-card,bitclock-master = <&soundcodec>; + simple-audio-card,frame-master = <&soundcodec>; + + simple-audio-card,cpu { + sound-dai = <&rcar_sound>; + }; + + soundcodec: simple-audio-card,codec { + sound-dai = <&ak4642>; + clocks = <&x14_clk>; + }; + }; }; &extal_clk { @@ -167,6 +202,16 @@ renesas,groups = "du_rgb888", "du_sync", "du_disp", "du_clk_out_0"; renesas,function = "du"; }; + + ssi_pins: sound { + renesas,groups = "ssi0129_ctrl", "ssi0_data", "ssi1_data"; + renesas,function = "ssi"; + }; + + audio_clk_pins: audio_clk { + renesas,groups = "audio_clk_a"; + renesas,function = "audio_clk"; + }; }; &scif0 { @@ -257,6 +302,12 @@ status = "okay"; clock-frequency = <400000>; + ak4642: codec@12 { + compatible = "asahi-kasei,ak4642"; + #sound-dai-cells = <0>; + reg = <0x12>; + }; + composite-in@20 { compatible = "adi,adv7180"; reg = <0x20>; @@ -385,3 +436,23 @@ }; }; }; + +&rcar_sound { + pinctrl-0 = <&ssi_pins &audio_clk_pins>; + pinctrl-names = "default"; + status = "okay"; + + /* Single DAI */ + #sound-dai-cells = <0>; + + rcar_sound,dai { + dai0 { + playback = <&ssi0>; + capture = <&ssi1>; + }; + }; +}; + +&ssi1 { + shared-pin; +}; ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH] ARM: dts: porter: add sound support 2016-01-21 22:36 ` [PATCH] ARM: dts: porter: add sound support Sergei Shtylyov @ 2016-01-25 0:35 ` Kuninori Morimoto 2016-01-26 0:43 ` Simon Horman 2016-01-26 14:31 ` Sergei Shtylyov 0 siblings, 2 replies; 25+ messages in thread From: Kuninori Morimoto @ 2016-01-25 0:35 UTC (permalink / raw) To: Sergei Shtylyov Cc: horms, linux-renesas-soc, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, devicetree, magnus.damm, linux, linux-arm-kernel Hi > Define the Porter board dependent part of the R8A7791 sound device node. > Add device node for Asahi Kasei AK4642 stereo codec to the I2C2 bus. > Add the "simple-audio-card" device node to interconnect the SoC sound > device and the codec. > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > +/* > + * SSI-AK4642 > + * > + * SW3: 1: AK4642 > + * 3: ADV7511 This is no a big deal, but according to my schematic, porter is using JP3, not SW3, but no one cares ;P Best regards --- Kuninori Morimoto ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH] ARM: dts: porter: add sound support 2016-01-25 0:35 ` Kuninori Morimoto @ 2016-01-26 0:43 ` Simon Horman 2016-01-26 14:31 ` Sergei Shtylyov 1 sibling, 0 replies; 25+ messages in thread From: Simon Horman @ 2016-01-26 0:43 UTC (permalink / raw) To: Kuninori Morimoto Cc: Sergei Shtylyov, linux-renesas-soc, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, devicetree, magnus.damm, linux, linux-arm-kernel On Mon, Jan 25, 2016 at 12:35:57AM +0000, Kuninori Morimoto wrote: > > Hi > > > Define the Porter board dependent part of the R8A7791 sound device node. > > Add device node for Asahi Kasei AK4642 stereo codec to the I2C2 bus. > > Add the "simple-audio-card" device node to interconnect the SoC sound > > device and the codec. > > > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Thanks, I have queued this up. > > +/* > > + * SSI-AK4642 > > + * > > + * SW3: 1: AK4642 > > + * 3: ADV7511 > > This is no a big deal, but according to my schematic, > porter is using JP3, not SW3, but no one cares ;P Sergei, please feel free to provide a follow-up patch to address this. ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH] ARM: dts: porter: add sound support 2016-01-25 0:35 ` Kuninori Morimoto 2016-01-26 0:43 ` Simon Horman @ 2016-01-26 14:31 ` Sergei Shtylyov 1 sibling, 0 replies; 25+ messages in thread From: Sergei Shtylyov @ 2016-01-26 14:31 UTC (permalink / raw) To: Kuninori Morimoto Cc: horms, linux-renesas-soc, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, devicetree, magnus.damm, linux, linux-arm-kernel Hello. On 01/25/2016 03:35 AM, Kuninori Morimoto wrote: >> Define the Porter board dependent part of the R8A7791 sound device node. >> Add device node for Asahi Kasei AK4642 stereo codec to the I2C2 bus. >> Add the "simple-audio-card" device node to interconnect the SoC sound >> device and the codec. >> >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Thank you. I forgot to mention that the patch was based on your work... :-/ >> +/* >> + * SSI-AK4642 >> + * >> + * SW3: 1: AK4642 >> + * 3: ADV7511 > > This is no a big deal, but according to my schematic, > porter is using JP3, not SW3, but no one cares ;P Indeed, sorry about that. > Best regards > --- > Kuninori Morimoto MBR, Sergei ^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH] ARM: dts: porter: add MAX3355 support [not found] <1674850.BZpGW9kEud@wasted.cogentembedded.com> 2016-01-21 22:36 ` [PATCH] ARM: dts: porter: add sound support Sergei Shtylyov @ 2016-01-26 22:14 ` Sergei Shtylyov 2016-01-28 5:49 ` Yoshihiro Shimoda 2016-02-11 20:26 ` [PATCH] ARM: dts: silk: add sound support Sergei Shtylyov ` (3 subsequent siblings) 5 siblings, 1 reply; 25+ messages in thread From: Sergei Shtylyov @ 2016-01-26 22:14 UTC (permalink / raw) To: horms, linux-renesas-soc, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, devicetree Cc: magnus.damm, linux, linux-arm-kernel Now that Maxim Integrated MAX3355 'extcon' driver and device tree bindings are upstream along with the 'extcon' hook in the Renesas USBHS driver, we can add MAX3355 device node to the Porter device tree and properly refer to it from the USBHS node instead of using "renesas,enable-gpio" property which only allowed checking the USB ID pin at the driver probe time; now this pin's state can be monitored dynamically! Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- This patch is against 'renesas-devel-20160126-v4.5-rc1' tag of Simon Horman's 'renesas.git' repo. arch/arm/boot/dts/r8a7791-porter.dts | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) Index: renesas/arch/arm/boot/dts/r8a7791-porter.dts =================================================================== --- renesas.orig/arch/arm/boot/dts/r8a7791-porter.dts +++ renesas/arch/arm/boot/dts/r8a7791-porter.dts @@ -90,6 +90,12 @@ 1800000 0>; }; + max3355: usb-otg { + compatible = "maxim,max3355"; + maxim,shdn-gpios = <&gpio2 4 GPIO_ACTIVE_HIGH>; + id-gpios = <&gpio5 31 GPIO_ACTIVE_HIGH>; + }; + hdmi-out { compatible = "hdmi-connector"; type = "a"; @@ -394,7 +400,7 @@ pinctrl-names = "default"; status = "okay"; - renesas,enable-gpio = <&gpio5 31 GPIO_ACTIVE_HIGH>; + extcon = <&max3355>; }; &usbphy { ^ permalink raw reply [flat|nested] 25+ messages in thread
* RE: [PATCH] ARM: dts: porter: add MAX3355 support 2016-01-26 22:14 ` [PATCH] ARM: dts: porter: add MAX3355 support Sergei Shtylyov @ 2016-01-28 5:49 ` Yoshihiro Shimoda 2016-01-29 20:28 ` Sergei Shtylyov 0 siblings, 1 reply; 25+ messages in thread From: Yoshihiro Shimoda @ 2016-01-28 5:49 UTC (permalink / raw) To: Sergei Shtylyov Cc: magnus.damm@gmail.com, linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org, horms@verge.net.au, linux-renesas-soc@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org Hi, > From: linux-renesas-soc-owner@vger.kernel.org [mailto:linux-renesas-soc-owner@vger.kernel.org] On Behalf Of Sergei > Shtylyov > Sent: Wednesday, January 27, 2016 7:14 AM > > Now that Maxim Integrated MAX3355 'extcon' driver and device tree bindings > are upstream along with the 'extcon' hook in the Renesas USBHS driver, we > can add MAX3355 device node to the Porter device tree and properly refer > to it from the USBHS node instead of using "renesas,enable-gpio" property > which only allowed checking the USB ID pin at the driver probe time; now > this pin's state can be monitored dynamically! > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> I tested this patch on Porter, but interrupt of "usb-otg" didn't happened even if I connected/disconnected a usb convert cable (usb micro-ab to A). Remarks: I confirmed that the usb convert cable worked correctly on other board. Do I need other settings for this? - kernel : renesas.git / renesas-devel-20160127-v4.5-rc1 tag + this patch - config : shmobile_defconfig + EXTCON + MAX3355 + and more - board : Porter (Y-RCAR-M2-PORTER-A) - log : [ 0.000000] Booting Linux on physical CPU 0x0 [ 0.000000] Linux version 4.5.0-rc1-dirty (shimoda@shimoda-i7-pc) (gcc version 4.9.3 20141031 (prerelease) (Linaro GCC 2014.11) ) #45 SMP Thu Jan 28 13:49:08 JST 2016 [ 0.000000] CPU: ARMv7 Processor [413fc0f2] revision 2 (ARMv7), cr=10c5387d [ 0.000000] CPU: div instructions available: patching division code [ 0.000000] CPU: PIPT / VIPT nonaliasing data cache, PIPT instruction cache [ 0.000000] Machine model: Porter [ 0.000000] Ignoring memory block 0x200000000 - 0x240000000 [ 0.000000] debug: ignoring loglevel setting. [ 0.000000] Memory policy: Data cache writealloc [ 0.000000] On node 0 totalpages: 262144 [ 0.000000] free_area_init_node: node 0, pgdat c07308c0, node_mem_map ef7f9000 [ 0.000000] Normal zone: 1536 pages used for memmap [ 0.000000] Normal zone: 0 pages reserved [ 0.000000] Normal zone: 196608 pages, LIFO batch:31 [ 0.000000] HighMem zone: 65536 pages, LIFO batch:15 [ 0.000000] PERCPU: Embedded 12 pages/cpu @ef7c0000 s17984 r8192 d22976 u49152 [ 0.000000] pcpu-alloc: s17984 r8192 d22976 u49152 alloc=12*4096 [ 0.000000] pcpu-alloc: [0] 0 [0] 1 [ 0.000000] Built 1 zonelists in Zone order, mobility grouping on. Total pages: 260608 [ 0.000000] Kernel command line: ignore_loglevel rw root=/dev/nfs ip=dhcp [ 0.000000] PID hash table entries: 4096 (order: 2, 16384 bytes) [ 0.000000] Dentry cache hash table entries: 131072 (order: 7, 524288 bytes) [ 0.000000] Inode-cache hash table entries: 65536 (order: 6, 262144 bytes) [ 0.000000] Memory: 1031652K/1048576K available (4928K kernel code, 184K rwdata, 1908K rodata, 308K init, 290K bss, 16924K reserved, 0K cma-reserved, 262144K highmem) [ 0.000000] Virtual kernel memory layout: [ 0.000000] vector : 0xffff0000 - 0xffff1000 ( 4 kB) [ 0.000000] fixmap : 0xffc00000 - 0xfff00000 (3072 kB) [ 0.000000] vmalloc : 0xf0800000 - 0xff800000 ( 240 MB) [ 0.000000] lowmem : 0xc0000000 - 0xf0000000 ( 768 MB) [ 0.000000] pkmap : 0xbfe00000 - 0xc0000000 ( 2 MB) [ 0.000000] modules : 0xbf000000 - 0xbfe00000 ( 14 MB) [ 0.000000] .text : 0xc0008000 - 0xc06b604c (6841 kB) [ 0.000000] .init : 0xc06b7000 - 0xc0704000 ( 308 kB) [ 0.000000] .data : 0xc0704000 - 0xc0732100 ( 185 kB) [ 0.000000] .bss : 0xc0735000 - 0xc077d9a4 ( 291 kB) [ 0.000000] Hierarchical RCU implementation. [ 0.000000] Build-time adjustment of leaf fanout to 32. [ 0.000000] RCU restricting CPUs from NR_CPUS=8 to nr_cpu_ids=2. [ 0.000000] RCU: Adjusting geometry for rcu_fanout_leaf=32, nr_cpu_ids=2 [ 0.000000] NR_IRQS:16 nr_irqs:16 16 [ 0.000000] Architected cp15 timer(s) running at 10.00MHz (virt). [ 0.000000] clocksource: arch_sys_counter: mask: 0xffffffffffffff max_cycles: 0x24e6a1710, max_idle_ns: 440795202120 ns [ 0.000004] sched_clock: 56 bits at 10MHz, resolution 100ns, wraps every 4398046511100ns [ 0.000013] Switching to timer-based delay loop, resolution 100ns [ 0.000386] Console: colour dummy device 80x30 [ 0.000680] console [tty0] enabled [ 0.000700] Calibrating delay loop (skipped), value calculated using timer frequency.. 20.00 BogoMIPS (lpj=100000) [ 0.000723] pid_max: default: 32768 minimum: 301 [ 0.000830] Mount-cache hash table entries: 2048 (order: 1, 8192 bytes) [ 0.000845] Mountpoint-cache hash table entries: 2048 (order: 1, 8192 bytes) [ 0.001289] CPU: Testing write buffer coherency: ok [ 0.001474] CPU0: update cpu_capacity 1024 [ 0.001489] CPU0: thread -1, cpu 0, socket 0, mpidr 80000000 [ 0.001564] Setting up static identity map for 0x40009000 - 0x40009058 [ 0.002502] Unable to boot CPU1 when MD21 is set [ 0.002520] CPU1: failed to boot: -524 [ 0.002557] Brought up 1 CPUs [ 0.002569] SMP: Total of 1 processors activated (20.00 BogoMIPS). [ 0.002581] CPU: All CPU(s) started in SVC mode. [ 0.003315] devtmpfs: initialized [ 0.010845] VFP support v0.3: implementor 41 architecture 4 part 30 variant f rev 0 [ 0.011227] clocksource: jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 19112604462750000 ns [ 0.011504] pinctrl core: initialized pinctrl subsystem [ 0.012122] NET: Registered protocol family 16 [ 0.012294] DMA: preallocated 256 KiB pool for atomic coherent allocations [ 0.015038] renesas_irqc e61c0000.interrupt-controller: driving 10 irqs [ 0.017503] sh-pfc e6060000.pfc: r8a77910_pfc support registered [ 0.021185] No ATAGs? [ 0.021207] hw-breakpoint: found 5 (+1 reserved) breakpoint and 4 watchpoint registers. [ 0.021231] hw-breakpoint: maximum watchpoint size is 8 bytes. [ 0.041040] gpio-regulator regulator@1: Could not obtain regulator setting GPIOs: -517 [ 0.041139] gpio-regulator regulator@3: Could not obtain regulator setting GPIOs: -517 [ 0.041603] vgaarb: loaded [ 0.041834] SCSI subsystem initialized [ 0.042233] libata version 3.00 loaded. [ 0.042444] usbcore: registered new interface driver usbfs [ 0.042501] usbcore: registered new interface driver hub [ 0.042554] usbcore: registered new device driver usb [ 0.043578] Advanced Linux Sound Architecture Driver Initialized. [ 0.044815] clocksource: Switched to clocksource arch_sys_counter [ 0.058596] NET: Registered protocol family 2 [ 0.059004] TCP established hash table entries: 8192 (order: 3, 32768 bytes) [ 0.059064] TCP bind hash table entries: 8192 (order: 4, 65536 bytes) [ 0.059160] TCP: Hash tables configured (established 8192 bind 8192) [ 0.059204] UDP hash table entries: 512 (order: 2, 16384 bytes) [ 0.059233] UDP-Lite hash table entries: 512 (order: 2, 16384 bytes) [ 0.059373] NET: Registered protocol family 1 [ 0.060064] RPC: Registered named UNIX socket transport module. [ 0.060082] RPC: Registered udp transport module. [ 0.060093] RPC: Registered tcp transport module. [ 0.060104] RPC: Registered tcp NFSv4.1 backchannel transport module. [ 0.060127] PCI: CLS 0 bytes, default 64 [ 0.061237] futex hash table entries: 512 (order: 3, 32768 bytes) [ 0.062651] NFS: Registering the id_resolver key type [ 0.062692] Key type id_resolver registered [ 0.062704] Key type id_legacy registered [ 0.062729] nfs4filelayout_init: NFSv4 File Layout Driver Registering... [ 0.064362] bounce: pool size: 64 pages [ 0.064431] Block layer SCSI generic (bsg) driver version 0.4 loaded (major 251) [ 0.064453] io scheduler noop registered [ 0.064467] io scheduler deadline registered [ 0.064487] io scheduler cfq registered (default) [ 0.065525] gpio_rcar e6050000.gpio: driving 32 GPIOs [ 0.065776] gpio_rcar e6051000.gpio: driving 26 GPIOs [ 0.066053] gpio_rcar e6052000.gpio: driving 32 GPIOs [ 0.066328] gpio_rcar e6053000.gpio: driving 32 GPIOs [ 0.066599] gpio_rcar e6054000.gpio: driving 32 GPIOs [ 0.066867] gpio_rcar e6055000.gpio: driving 32 GPIOs [ 0.067155] gpio_rcar e6055400.gpio: driving 32 GPIOs [ 0.067400] gpio_rcar e6055800.gpio: driving 26 GPIOs [ 0.067947] pci-rcar-gen2 ee090000.pci: PCI: bus0 revision 11 [ 0.068104] pci-rcar-gen2 ee090000.pci: PCI host bridge to bus 0000:00 [ 0.068121] pci_bus 0000:00: root bus resource [io 0xee080000-0xee0810ff] [ 0.068136] pci_bus 0000:00: root bus resource [mem 0xee080000-0xee0810ff] [ 0.068150] pci_bus 0000:00: No busn resource found for root bus, will use [bus 00-ff] [ 0.068192] pci 0000:00:00.0: [1033:0000] type 00 class 0x060000 [ 0.068218] pci 0000:00:00.0: reg 0x10: [mem 0xee090800-0xee090bff] [ 0.068236] pci 0000:00:00.0: reg 0x14: [mem 0x40000000-0x7fffffff pref] [ 0.068434] pci 0000:00:01.0: [1033:0035] type 00 class 0x0c0310 [ 0.068461] pci 0000:00:01.0: reg 0x10: [mem 0x00000000-0x00000fff] [ 0.068534] pci 0000:00:01.0: supports D1 D2 [ 0.068548] pci 0000:00:01.0: PME# supported from D0 D1 D2 D3hot [ 0.068746] pci 0000:00:02.0: [1033:00e0] type 00 class 0x0c0320 [ 0.068773] pci 0000:00:02.0: reg 0x10: [mem 0x00000000-0x000000ff] [ 0.068845] pci 0000:00:02.0: supports D1 D2 [ 0.068858] pci 0000:00:02.0: PME# supported from D0 D1 D2 D3hot [ 0.069055] PCI: bus0: Fast back to back transfers disabled [ 0.069072] pci_bus 0000:00: busn_res: [bus 00-ff] end is updated to 00 [ 0.069147] pci 0000:00:01.0: BAR 0: assigned [mem 0xee080000-0xee080fff] [ 0.069167] pci 0000:00:02.0: BAR 0: assigned [mem 0xee081000-0xee0810ff] [ 0.069205] pci 0000:00:01.0: enabling device (0140 -> 0142) [ 0.069246] pci 0000:00:02.0: enabling device (0140 -> 0142) [ 0.069423] pci-rcar-gen2 ee0d0000.pci: PCI: bus0 revision 11 [ 0.069564] pci-rcar-gen2 ee0d0000.pci: PCI host bridge to bus 0001:01 [ 0.069580] pci_bus 0001:01: root bus resource [io 0xee0c0000-0xee0c10ff] [ 0.069594] pci_bus 0001:01: root bus resource [mem 0xee0c0000-0xee0c10ff] [ 0.069608] pci_bus 0001:01: No busn resource found for root bus, will use [bus 01-ff] [ 0.069640] pci 0001:01:00.0: [1033:0000] type 00 class 0x060000 [ 0.069663] pci 0001:01:00.0: reg 0x10: [mem 0xee0d0800-0xee0d0bff] [ 0.069681] pci 0001:01:00.0: reg 0x14: [mem 0x40000000-0x7fffffff pref] [ 0.069863] pci 0001:01:01.0: [1033:0035] type 00 class 0x0c0310 [ 0.069889] pci 0001:01:01.0: reg 0x10: [mem 0x00000000-0x00000fff] [ 0.069962] pci 0001:01:01.0: supports D1 D2 [ 0.069975] pci 0001:01:01.0: PME# supported from D0 D1 D2 D3hot [ 0.070168] pci 0001:01:02.0: [1033:00e0] type 00 class 0x0c0320 [ 0.070194] pci 0001:01:02.0: reg 0x10: [mem 0x00000000-0x000000ff] [ 0.070266] pci 0001:01:02.0: supports D1 D2 [ 0.070279] pci 0001:01:02.0: PME# supported from D0 D1 D2 D3hot [ 0.070476] PCI: bus1: Fast back to back transfers disabled [ 0.070492] pci_bus 0001:01: busn_res: [bus 01-ff] end is updated to 01 [ 0.070606] pci 0001:01:01.0: BAR 0: assigned [mem 0xee0c0000-0xee0c0fff] [ 0.070624] pci 0001:01:02.0: BAR 0: assigned [mem 0xee0c1000-0xee0c10ff] [ 0.070660] pci 0001:01:01.0: enabling device (0140 -> 0142) [ 0.070697] pci 0001:01:02.0: enabling device (0140 -> 0142) [ 0.070959] PCI host bridge /pcie@fe000000 ranges: [ 0.070984] IO 0xfe100000..0xfe1fffff -> 0x00000000 [ 0.071003] MEM 0xfe200000..0xfe3fffff -> 0xfe200000 [ 0.071021] MEM 0x30000000..0x37ffffff -> 0x30000000 [ 0.071035] MEM 0x38000000..0x3fffffff -> 0x38000000 [ 0.264153] rcar-pcie fe000000.pcie: PCIe link down [ 0.278314] Serial: 8250/16550 driver, 4 ports, IRQ sharing disabled [ 0.279574] SuperH (H)SCI(F) driver initialized [ 0.279919] e6e60000.serial: ttySC0 at MMIO 0xe6e60000 (irq = 105, base_baud = 0) is a scif [ 1.250320] console [ttySC0] enabled [ 1.254672] [drm] Initialized drm 1.1.0 20060810 [ 1.260004] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013). [ 1.266787] [drm] No driver support for vblank timestamp query. [ 1.273157] rcar-du feb00000.display: failed to initialize DRM/KMS (-517) [ 1.282277] scsi host0: sata_rcar [ 1.285888] ata1: SATA max UDMA/133 irq 107 [ 1.290762] renesas_spi e6b10000.spi: DMA available [ 1.296792] m25p80 spi0.0: s25fl512s (65536 Kbytes) [ 1.301962] 3 ofpart partitions found on MTD device spi0.0 [ 1.307592] Creating 3 MTD partitions on "spi0.0": [ 1.312488] 0x000000000000-0x000000040000 : "loader_prg" [ 1.318859] 0x000000040000-0x000000440000 : "user_prg" [ 1.325085] 0x000000440000-0x000004000000 : "flash_fs" [ 1.331277] renesas_spi e6b10000.spi: probed [ 1.336702] CAN device driver interface [ 1.341298] rcar_can e6e80000.can: device registered (regs @ f08ea000, IRQ115) [ 1.349212] libphy: sh_mii: probed [ 1.355593] sh-eth ee700000.ethernet eth0: Base address at 0xee700000, 2e:09:0a:00:89:12, IRQ 106. [ 1.365356] ehci_hcd: USB 2.0 'Enhanced' Host Controller (EHCI) Driver [ 1.372029] ehci-pci: EHCI PCI platform driver [ 1.376710] ehci-pci 0000:00:02.0: EHCI Host Controller [ 1.382064] ehci-pci 0000:00:02.0: new USB bus registered, assigned bus number 1 [ 1.389744] ehci-pci 0000:00:02.0: irq 118, io mem 0xee081000 [ 1.414163] ehci-pci 0000:00:02.0: USB 2.0 started, EHCI 1.00 [ 1.420696] hub 1-0:1.0: USB hub found [ 1.424682] hub 1-0:1.0: 1 port detected [ 1.429078] ehci-pci 0001:01:02.0: EHCI Host Controller [ 1.434476] ehci-pci 0001:01:02.0: new USB bus registered, assigned bus number 2 [ 1.442122] ehci-pci 0001:01:02.0: irq 119, io mem 0xee0c1000 [ 1.464210] ehci-pci 0001:01:02.0: USB 2.0 started, EHCI 1.00 [ 1.470671] hub 2-0:1.0: USB hub found [ 1.474641] hub 2-0:1.0: 1 port detected [ 1.478985] ohci_hcd: USB 1.1 'Open' Host Controller (OHCI) Driver [ 1.485321] ohci-pci: OHCI PCI platform driver [ 1.489927] ohci-pci 0000:00:01.0: OHCI PCI host controller [ 1.495644] ohci-pci 0000:00:01.0: new USB bus registered, assigned bus number 3 [ 1.503236] ohci-pci 0000:00:01.0: irq 118, io mem 0xee080000 [ 1.595067] hub 3-0:1.0: USB hub found [ 1.599015] hub 3-0:1.0: 1 port detected [ 1.603355] ohci-pci 0001:01:01.0: OHCI PCI host controller [ 1.609080] ohci-pci 0001:01:01.0: new USB bus registered, assigned bus number 4 [ 1.616682] ohci-pci 0001:01:01.0: irq 119, io mem 0xee0c0000 [ 1.704949] hub 4-0:1.0: USB hub found [ 1.708894] hub 4-0:1.0: 1 port detected [ 1.714314] mousedev: PS/2 mouse device common for all mice [ 1.720365] i2c /dev entries driver [ 1.727969] i2c-rcar e6530000.i2c: probed [ 1.735107] rcar_thermal e61f0000.thermal: 1 sensor probed [ 1.741272] sh_mobile_sdhi ee100000.sd: Got CD GPIO [ 1.746303] sh_mobile_sdhi ee100000.sd: Got WP GPIO [ 1.751548] ata1: link resume succeeded after 1 retries [ 1.864182] ata1: SATA link down (SStatus 0 SControl 300) [ 1.924411] sh_mobile_sdhi ee100000.sd: mmc0 base at 0xee100000 clock rate 97 MHz [ 1.932452] sh_mobile_sdhi ee160000.sd: Got CD GPIO [ 2.114316] sh_mobile_sdhi ee160000.sd: mmc1 base at 0xee160000 clock rate 97 MHz [ 2.122647] usbcore: registered new interface driver usbhid [ 2.128363] usbhid: USB HID core driver [ 2.133902] ak4642-codec 2-0012: No cache used with register defaults set! [ 2.144969] rcar_sound ec500000.sound: probed [ 2.150032] NET: Registered protocol family 10 [ 2.157203] sit: IPv6 over IPv4 tunneling driver [ 2.162417] NET: Registered protocol family 17 [ 2.167011] can: controller area network core (rev 20120528 abi 9) [ 2.173362] NET: Registered protocol family 29 [ 2.177933] can: raw protocol (rev 20120528) [ 2.182297] can: broadcast manager protocol (rev 20120528 t) [ 2.188095] can: netlink gateway (rev 20130117) max_hops=1 [ 2.193775] Key type dns_resolver registered [ 2.198575] Registering SWP/SWPB emulation handler [ 2.205780] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013). [ 2.212546] [drm] No driver support for vblank timestamp query. [ 2.219809] rcar-du feb00000.display: No connectors reported connected with modes [ 2.227488] [drm] Cannot find any crtc or sizes - going 1024x768 [ 2.241025] Console: switching to colour frame buffer device 128x48 [ 2.253463] rcar-du feb00000.display: fb0: frame buffer device [ 2.259597] [drm] Initialized rcar-du 1.0.0 20130110 on minor 0 [ 2.266760] renesas_usbhs e6590000.usb: transceiver found [ 2.272488] renesas_usbhs e6590000.usb: gadget probed [ 2.277780] phy phy-e6590100.usb-phy.1: phy init failed --> -16 [ 2.283893] renesas_usbhs e6590000.usb: probed [ 2.288492] sh-pfc e6060000.pfc: pin GP_7_23 already requested by ee090000.pci; cannot claim for e6590000.usb [ 2.298737] sh-pfc e6060000.pfc: pin-247 (e6590000.usb) status -22 [ 2.305124] sh-pfc e6060000.pfc: could not request pin 247 (GP_7_23) from group usb0 on device sh-pfc [ 2.314734] renesas_usbhs e6590000.usb: Error applying setting, reverse things back [ 2.322632] renesas_usbhs e6590000.usb: failed to activate default pinctrl state [ 2.331932] asoc-simple-card sound: ak4642-hifi <-> ec500000.sound mapping ok [ 2.341065] hctosys: unable to open rtc device (rtc0) [ 2.425932] Micrel KSZ8041RNLI ee700000.etherne:01: attached PHY driver [Micrel KSZ8041RNLI] (mii_bus:phy_addr=ee700000.etherne:01, irq=367) [ 2.439009] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready [ 5.358471] sh-eth ee700000.ethernet eth0: Link is Up - 100Mbps/Full - flow control rx/tx [ 5.367618] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready [ 5.384155] Sending DHCP requests ., OK [ 5.457444] IP-Config: Got DHCP answer from 192.168.44.74, my address is 192.168.44.192 [ 5.468607] IP-Config: Complete: [ 5.474789] device=eth0, hwaddr=2e:09:0a:00:89:12, ipaddr=192.168.44.192, mask=255.255.255.0, gw=192.168.44.74 [ 5.488457] host=192.168.44.192, domain=shimoda-i7.org, nis-domain=(none) [ 5.498836] bootserver=192.168.44.74, rootserver=192.168.44.74, rootpath=/var/lib/tftpboot/arm_linux/rootfs/debian/armel-wheezy nameserver0=192.168.44.74 [ 5.519858] SDHI0 VccQ: disabling [ 5.526303] SDHI2 VccQ: disabling [ 5.532911] ALSA device list: [ 5.538917] #0: rsnd-dai.0-ak4642-hifi [ 5.549703] VFS: Mounted root (nfs filesystem) on device 0:13. [ 5.558922] devtmpfs: mounted [ 5.565079] Freeing unused kernel memory: 308K (c06b7000 - c0704000) INIT: version 2.88 booting [info] Using makefile-style concurrent boot in runlevel S. [....] Starting the hotplug events dispatcher: udevd[ 6.398307] udevd[864]: starting version 175 . ok [ ok ] Synthesizing the initial hotplug events...done. [ ok ] Waiting for /dev to be fully populated...done. [ 7.434946] random: nonblocking pool is initialized [ ok ] Activating swap...done. [ ok ] Cleaning up temporary files.... [ ok ] Activating lvm and md swap...done. [....] Checking file systems...fsck from util-linux 2.20.1 done. [ ok ] Mounting local filesystems...done. [ ok ] Activating swapfile swap...done. [ ok ] Cleaning up temporary files.... [ ok ] Setting kernel variables ...done. [ ok ] Configuring network interfaces...done. [ ok ] Cleaning up temporary files.... [....] Setting up ALSA...warning: 'alsactl restore' failed with error message 'Found hardware: "rsnd-dai_0-ak46" "" "" "" "" Hardware is initialized using a generic method alsactl: set_control:1328: failed to obtain info for control #4 (No such file or directory) alsactl: set_control:1328: failed to obtain info for control #5 (No such file or directory) alsactl: set_control:1328: failed to obtain info for control #6 (No such file or directory) alsactl: set_control:1328: failed to obtain info for control #7 (No such file or directory) alsactl: set_control:1328: failed to obtain info for control #8 (No such file or directory) alsactl: set_control:1328: failed to obtain info for control #9 (No such file or directory) alsactl: set_control:1328: failed to obtain info for control #10 (No such file or directory) alsactl: set_control:1328: failed to obtain info for control #11 (No such file or directory) alsactl: set_control:1328: failed to obtain info for control #12 (No such file or directory) alsactl: set_control:1328: failed to obtain info for control #13 (No such file o[ ok ectory)'...done. [ ok ] Setting up X socket directories... /tmp/.X11-unix /tmp/.ICE-unix. INIT: Entering runlevel: 2 [info] Using makefile-style concurrent boot in runlevel 2. [ ok ] Starting enhanced syslogd: rsyslogd. [ ok ] Starting periodic command scheduler: cron. [ ok ] Starting system message bus: dbus. Debian GNU/Linux 7 192.168.44.192 ttySC0 192 login: root Password: Last login: Thu Jan 1 00:00:17 UTC 1970 on ttySC0 Linux 192.168.44.192 4.5.0-rc1-dirty #45 SMP Thu Jan 28 13:49:08 JST 2016 armv7l The programs included with the Debian GNU/Linux system are free software; the exact distribution terms for each program are described in the individual files in /usr/share/doc/*/copyright. Debian GNU/Linux comes with ABSOLUTELY NO WARRANTY, to the extent permitted by applicable law. root@192:~# root@192:~# cat /proc/interrupts | grep usb 108: 0 GIC-0 139 Level e6590000.usb 118: 1 GIC-0 140 Level ehci_hcd:usb1, ohci_hcd:usb3 119: 0 GIC-0 145 Level ehci_hcd:usb2, ohci_hcd:usb4 308: 0 e6055000.gpio 31 Edge usb-otg root@192:~# root@192:~# cat /proc/interrupts | grep usb 108: 0 GIC-0 139 Level e6590000.usb 118: 1 GIC-0 140 Level ehci_hcd:usb1, ohci_hcd:usb3 119: 0 GIC-0 145 Level ehci_hcd:usb2, ohci_hcd:usb4 308: 0 e6055000.gpio 31 Edge usb-otg root@192:~# root@192:~# cd /sys/class/extcon/extcon0 root@192:/sys/class/extcon/extcon0# cat state USB=1 USB-HOST=0 Best regards, Yoshihiro Shimoda ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH] ARM: dts: porter: add MAX3355 support 2016-01-28 5:49 ` Yoshihiro Shimoda @ 2016-01-29 20:28 ` Sergei Shtylyov 2016-01-29 20:49 ` Sergei Shtylyov 0 siblings, 1 reply; 25+ messages in thread From: Sergei Shtylyov @ 2016-01-29 20:28 UTC (permalink / raw) To: Yoshihiro Shimoda Cc: magnus.damm@gmail.com, linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org, horms@verge.net.au, linux-renesas-soc@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org Hello. On 01/28/2016 08:49 AM, Yoshihiro Shimoda wrote: >> From: linux-renesas-soc-owner@vger.kernel.org [mailto:linux-renesas-soc-owner@vger.kernel.org] On Behalf Of Sergei >> Shtylyov >> Sent: Wednesday, January 27, 2016 7:14 AM >> >> Now that Maxim Integrated MAX3355 'extcon' driver and device tree bindings >> are upstream along with the 'extcon' hook in the Renesas USBHS driver, we >> can add MAX3355 device node to the Porter device tree and properly refer >> to it from the USBHS node instead of using "renesas,enable-gpio" property >> which only allowed checking the USB ID pin at the driver probe time; now >> this pin's state can be monitored dynamically! >> >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > I tested this patch on Porter, but interrupt of "usb-otg" didn't happened > even if I connected/disconnected a usb convert cable (usb micro-ab to A). > Remarks: I confirmed that the usb convert cable worked correctly on other board. I guess I have the same cable and IRQs do happen for me when I connect and disconnect it (as it should be). > Do I need other settings for this? No evident answer to that, your logs show that MAX3355 driver was enabled... > root@192:~# cat /proc/interrupts | grep usb > 108: 0 GIC-0 139 Level e6590000.usb > 118: 1 GIC-0 140 Level ehci_hcd:usb1, ohci_hcd:usb3 > 119: 0 GIC-0 145 Level ehci_hcd:usb2, ohci_hcd:usb4 > 308: 0 e6055000.gpio 31 Edge usb-otg > root@192:~# > root@192:~# cat /proc/interrupts | grep usb > 108: 0 GIC-0 139 Level e6590000.usb > 118: 1 GIC-0 140 Level ehci_hcd:usb1, ohci_hcd:usb3 > 119: 0 GIC-0 145 Level ehci_hcd:usb2, ohci_hcd:usb4 > 308: 0 e6055000.gpio 31 Edge usb-otg > root@192:~# > root@192:~# cd /sys/class/extcon/extcon0 > root@192:/sys/class/extcon/extcon0# cat state > USB=1 > USB-HOST=0 I guess these states doesn't change even if you insert your cable? They also do change for me. > Best regards, > Yoshihiro Shimoda MBR, Sergei ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH] ARM: dts: porter: add MAX3355 support 2016-01-29 20:28 ` Sergei Shtylyov @ 2016-01-29 20:49 ` Sergei Shtylyov 2016-02-01 11:17 ` Yoshihiro Shimoda 0 siblings, 1 reply; 25+ messages in thread From: Sergei Shtylyov @ 2016-01-29 20:49 UTC (permalink / raw) To: Yoshihiro Shimoda Cc: magnus.damm@gmail.com, linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org, horms@verge.net.au, linux-renesas-soc@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org On 01/29/2016 11:28 PM, Sergei Shtylyov wrote: >>> From: linux-renesas-soc-owner@vger.kernel.org >>> [mailto:linux-renesas-soc-owner@vger.kernel.org] On Behalf Of Sergei >>> Shtylyov >>> Sent: Wednesday, January 27, 2016 7:14 AM >>> >>> Now that Maxim Integrated MAX3355 'extcon' driver and device tree bindings >>> are upstream along with the 'extcon' hook in the Renesas USBHS driver, we >>> can add MAX3355 device node to the Porter device tree and properly refer >>> to it from the USBHS node instead of using "renesas,enable-gpio" property >>> which only allowed checking the USB ID pin at the driver probe time; now >>> this pin's state can be monitored dynamically! >>> >>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >> >> I tested this patch on Porter, but interrupt of "usb-otg" didn't happened >> even if I connected/disconnected a usb convert cable (usb micro-ab to A). >> Remarks: I confirmed that the usb convert cable worked correctly on other >> board. > > I guess I have the same cable No, I have mini-AB connector here and hence my cable is mini-AB to A. > and IRQs do happen for me when I connect and > disconnect it (as it should be). >> Best regards, >> Yoshihiro Shimoda MBR, Sergei ^ permalink raw reply [flat|nested] 25+ messages in thread
* RE: [PATCH] ARM: dts: porter: add MAX3355 support 2016-01-29 20:49 ` Sergei Shtylyov @ 2016-02-01 11:17 ` Yoshihiro Shimoda 2016-02-01 17:54 ` Sergei Shtylyov 0 siblings, 1 reply; 25+ messages in thread From: Yoshihiro Shimoda @ 2016-02-01 11:17 UTC (permalink / raw) To: Sergei Shtylyov Cc: magnus.damm@gmail.com, linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org, horms@verge.net.au, linux-renesas-soc@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org Hi, > From: Sergei Shtylyov > Sent: Saturday, January 30, 2016 5:50 AM > > On 01/29/2016 11:28 PM, Sergei Shtylyov wrote: > > >>> From: linux-renesas-soc-owner@vger.kernel.org > >>> [mailto:linux-renesas-soc-owner@vger.kernel.org] On Behalf Of Sergei > >>> Shtylyov > >>> Sent: Wednesday, January 27, 2016 7:14 AM > >>> > >>> Now that Maxim Integrated MAX3355 'extcon' driver and device tree bindings > >>> are upstream along with the 'extcon' hook in the Renesas USBHS driver, we > >>> can add MAX3355 device node to the Porter device tree and properly refer > >>> to it from the USBHS node instead of using "renesas,enable-gpio" property > >>> which only allowed checking the USB ID pin at the driver probe time; now > >>> this pin's state can be monitored dynamically! > >>> > >>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > >> > >> I tested this patch on Porter, but interrupt of "usb-otg" didn't happened > >> even if I connected/disconnected a usb convert cable (usb micro-ab to A). > >> Remarks: I confirmed that the usb convert cable worked correctly on other > >> board. > > > > I guess I have the same cable > > No, I have mini-AB connector here and hence my cable is mini-AB to A. I checked Porter specification and then I found 2 specifications exist... Porter "B" : mini AB connecter and Max3355 is on the board. Porter "C" : micro AB connect and Max3355 is not on the board. (Select host/peripheral by a jumper.) I guess that your current target is "B". If so, I think this patch is acceptable. Best regards, Yoshihiro Shimoda > > and IRQs do happen for me when I connect and > > disconnect it (as it should be). > > >> Best regards, > >> Yoshihiro Shimoda > > MBR, Sergei ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH] ARM: dts: porter: add MAX3355 support 2016-02-01 11:17 ` Yoshihiro Shimoda @ 2016-02-01 17:54 ` Sergei Shtylyov 2016-02-01 19:00 ` Sergei Shtylyov 0 siblings, 1 reply; 25+ messages in thread From: Sergei Shtylyov @ 2016-02-01 17:54 UTC (permalink / raw) To: Yoshihiro Shimoda Cc: magnus.damm@gmail.com, linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org, horms@verge.net.au, linux-renesas-soc@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org Hello. On 02/01/2016 02:17 PM, Yoshihiro Shimoda wrote: >>>>> From: linux-renesas-soc-owner@vger.kernel.org >>>>> [mailto:linux-renesas-soc-owner@vger.kernel.org] On Behalf Of Sergei >>>>> Shtylyov >>>>> Sent: Wednesday, January 27, 2016 7:14 AM >>>>> >>>>> Now that Maxim Integrated MAX3355 'extcon' driver and device tree bindings >>>>> are upstream along with the 'extcon' hook in the Renesas USBHS driver, we >>>>> can add MAX3355 device node to the Porter device tree and properly refer >>>>> to it from the USBHS node instead of using "renesas,enable-gpio" property >>>>> which only allowed checking the USB ID pin at the driver probe time; now >>>>> this pin's state can be monitored dynamically! >>>>> >>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >>>> >>>> I tested this patch on Porter, but interrupt of "usb-otg" didn't happened >>>> even if I connected/disconnected a usb convert cable (usb micro-ab to A). >>>> Remarks: I confirmed that the usb convert cable worked correctly on other >>>> board. >>> >>> I guess I have the same cable >> >> No, I have mini-AB connector here and hence my cable is mini-AB to A. > > I checked Porter specification and then I found 2 specifications exist... I've looked thru my schematics files and found 3: Rev. 1.1 Update Version 2, "PORTER_2" Rev. 3.0 Preliminary, and "PORTER_C" Rev. 3.0 Release version! I'm not sure which of the last 2 should be considered final... > Porter "B" : mini AB connecter and Max3355 is on the board. > Porter "C" : micro AB connect and Max3355 is not on the board. (Select host/peripheral by a jumper.) Yeah, seeing JP13 in the PORTER_C schematics. > I guess that your current target is "B". If not earlier. It actually has "Henninger B REV2" printed on it and "Porter PCB 1 R3" on a pasted sticker. > If so, I think this patch is acceptable. I'm not so sure now... > Best regards, > Yoshihiro Shimoda MBR, Sergei ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH] ARM: dts: porter: add MAX3355 support 2016-02-01 17:54 ` Sergei Shtylyov @ 2016-02-01 19:00 ` Sergei Shtylyov 2016-02-15 1:45 ` Simon Horman 0 siblings, 1 reply; 25+ messages in thread From: Sergei Shtylyov @ 2016-02-01 19:00 UTC (permalink / raw) To: Yoshihiro Shimoda Cc: magnus.damm@gmail.com, linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org, horms@verge.net.au, linux-renesas-soc@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org On 02/01/2016 08:54 PM, Sergei Shtylyov wrote: >>>>>> From: linux-renesas-soc-owner@vger.kernel.org >>>>>> [mailto:linux-renesas-soc-owner@vger.kernel.org] On Behalf Of Sergei >>>>>> Shtylyov >>>>>> Sent: Wednesday, January 27, 2016 7:14 AM >>>>>> >>>>>> Now that Maxim Integrated MAX3355 'extcon' driver and device tree bindings >>>>>> are upstream along with the 'extcon' hook in the Renesas USBHS driver, we >>>>>> can add MAX3355 device node to the Porter device tree and properly refer >>>>>> to it from the USBHS node instead of using "renesas,enable-gpio" property >>>>>> which only allowed checking the USB ID pin at the driver probe time; now >>>>>> this pin's state can be monitored dynamically! >>>>>> >>>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >>>>> >>>>> I tested this patch on Porter, but interrupt of "usb-otg" didn't happened >>>>> even if I connected/disconnected a usb convert cable (usb micro-ab to A). >>>>> Remarks: I confirmed that the usb convert cable worked correctly on other >>>>> board. >>>> >>>> I guess I have the same cable >>> >>> No, I have mini-AB connector here and hence my cable is mini-AB to A. >> >> I checked Porter specification and then I found 2 specifications exist... > > I've looked thru my schematics files and found 3: Rev. 1.1 Update Version > 2, "PORTER_2" Rev. 3.0 Preliminary, and "PORTER_C" Rev. 3.0 Release version! > I'm not sure which of the last 2 should be considered final... Now I've found 5 versions of the Porter schematics... :-) >> Porter "B" : mini AB connecter and Max3355 is on the board. >> Porter "C" : micro AB connect and Max3355 is not on the board. (Select >> host/peripheral by a jumper.) > > Yeah, seeing JP13 in the PORTER_C schematics. > >> I guess that your current target is "B". > > If not earlier. It actually has "Henninger B REV2" printed on it and > "Porter PCB 1 R3" on a pasted sticker. > >> If so, I think this patch is acceptable. > > I'm not so sure now... My boss told me PORTER_C is a final version, so this patch isn't needed. But then another patch is needed instead: to remove "renesas,enable-gpio" prop from the HS-USB device node... >> Best regards, >> Yoshihiro Shimoda MBR, Sergei ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH] ARM: dts: porter: add MAX3355 support 2016-02-01 19:00 ` Sergei Shtylyov @ 2016-02-15 1:45 ` Simon Horman 2016-02-15 10:59 ` Sergei Shtylyov 0 siblings, 1 reply; 25+ messages in thread From: Simon Horman @ 2016-02-15 1:45 UTC (permalink / raw) To: Sergei Shtylyov Cc: Yoshihiro Shimoda, magnus.damm@gmail.com, linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org On Mon, Feb 01, 2016 at 10:00:55PM +0300, Sergei Shtylyov wrote: > On 02/01/2016 08:54 PM, Sergei Shtylyov wrote: > > >>>>>>From: linux-renesas-soc-owner@vger.kernel.org > >>>>>>[mailto:linux-renesas-soc-owner@vger.kernel.org] On Behalf Of Sergei > >>>>>>Shtylyov > >>>>>>Sent: Wednesday, January 27, 2016 7:14 AM > >>>>>> > >>>>>>Now that Maxim Integrated MAX3355 'extcon' driver and device tree bindings > >>>>>>are upstream along with the 'extcon' hook in the Renesas USBHS driver, we > >>>>>>can add MAX3355 device node to the Porter device tree and properly refer > >>>>>>to it from the USBHS node instead of using "renesas,enable-gpio" property > >>>>>>which only allowed checking the USB ID pin at the driver probe time; now > >>>>>>this pin's state can be monitored dynamically! > >>>>>> > >>>>>>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > >>>>> > >>>>>I tested this patch on Porter, but interrupt of "usb-otg" didn't happened > >>>>>even if I connected/disconnected a usb convert cable (usb micro-ab to A). > >>>>>Remarks: I confirmed that the usb convert cable worked correctly on other > >>>>>board. > >>>> > >>>> I guess I have the same cable > >>> > >>> No, I have mini-AB connector here and hence my cable is mini-AB to A. > >> > >>I checked Porter specification and then I found 2 specifications exist... > > > > I've looked thru my schematics files and found 3: Rev. 1.1 Update Version > >2, "PORTER_2" Rev. 3.0 Preliminary, and "PORTER_C" Rev. 3.0 Release version! > >I'm not sure which of the last 2 should be considered final... > > Now I've found 5 versions of the Porter schematics... :-) > > >> Porter "B" : mini AB connecter and Max3355 is on the board. > >> Porter "C" : micro AB connect and Max3355 is not on the board. (Select > >>host/peripheral by a jumper.) > > > > Yeah, seeing JP13 in the PORTER_C schematics. > > > >>I guess that your current target is "B". > > > > If not earlier. It actually has "Henninger B REV2" printed on it and > >"Porter PCB 1 R3" on a pasted sticker. > > > >>If so, I think this patch is acceptable. > > > > I'm not so sure now... > > My boss told me PORTER_C is a final version, so this patch isn't needed. > But then another patch is needed instead: to remove "renesas,enable-gpio" > prop from the HS-USB device node... I am marking this patch as "Rejected" in patchwork. If changes are required in this area please either resubmit this patch or post a different one. Thanks. ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH] ARM: dts: porter: add MAX3355 support 2016-02-15 1:45 ` Simon Horman @ 2016-02-15 10:59 ` Sergei Shtylyov 0 siblings, 0 replies; 25+ messages in thread From: Sergei Shtylyov @ 2016-02-15 10:59 UTC (permalink / raw) To: Simon Horman Cc: Yoshihiro Shimoda, magnus.damm@gmail.com, linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org On 2/15/2016 4:45 AM, Simon Horman wrote: >>>>>>>> Now that Maxim Integrated MAX3355 'extcon' driver and device tree bindings >>>>>>>> are upstream along with the 'extcon' hook in the Renesas USBHS driver, we >>>>>>>> can add MAX3355 device node to the Porter device tree and properly refer >>>>>>>> to it from the USBHS node instead of using "renesas,enable-gpio" property >>>>>>>> which only allowed checking the USB ID pin at the driver probe time; now >>>>>>>> this pin's state can be monitored dynamically! >>>>>>>> >>>>>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >>>>>>> >>>>>>> I tested this patch on Porter, but interrupt of "usb-otg" didn't happened >>>>>>> even if I connected/disconnected a usb convert cable (usb micro-ab to A). >>>>>>> Remarks: I confirmed that the usb convert cable worked correctly on other >>>>>>> board. >>>>>> >>>>>> I guess I have the same cable >>>>> >>>>> No, I have mini-AB connector here and hence my cable is mini-AB to A. >>>> >>>> I checked Porter specification and then I found 2 specifications exist... >>> >>> I've looked thru my schematics files and found 3: Rev. 1.1 Update Version >>> 2, "PORTER_2" Rev. 3.0 Preliminary, and "PORTER_C" Rev. 3.0 Release version! >>> I'm not sure which of the last 2 should be considered final... >> >> Now I've found 5 versions of the Porter schematics... :-) >> >>>> Porter "B" : mini AB connecter and Max3355 is on the board. >>>> Porter "C" : micro AB connect and Max3355 is not on the board. (Select >>>> host/peripheral by a jumper.) >>> >>> Yeah, seeing JP13 in the PORTER_C schematics. >>> >>>> I guess that your current target is "B". >>> >>> If not earlier. It actually has "Henninger B REV2" printed on it and >>> "Porter PCB 1 R3" on a pasted sticker. >>> >>>> If so, I think this patch is acceptable. >>> >>> I'm not so sure now... >> >> My boss told me PORTER_C is a final version, so this patch isn't needed. >> But then another patch is needed instead: to remove "renesas,enable-gpio" >> prop from the HS-USB device node... > > I am marking this patch as "Rejected" in patchwork. > If changes are required in this area please either > resubmit this patch or post a different one. Posted a different one on Saturday. > Thanks. MBR, Sergei ^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH] ARM: dts: silk: add sound support [not found] <1674850.BZpGW9kEud@wasted.cogentembedded.com> 2016-01-21 22:36 ` [PATCH] ARM: dts: porter: add sound support Sergei Shtylyov 2016-01-26 22:14 ` [PATCH] ARM: dts: porter: add MAX3355 support Sergei Shtylyov @ 2016-02-11 20:26 ` Sergei Shtylyov 2016-02-15 4:56 ` Kuninori Morimoto 2016-02-11 21:49 ` [PATCH] ARM: dts: porter: fix JP3 jumper description Sergei Shtylyov ` (2 subsequent siblings) 5 siblings, 1 reply; 25+ messages in thread From: Sergei Shtylyov @ 2016-02-11 20:26 UTC (permalink / raw) To: horms, linux-renesas-soc, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, devicetree Cc: magnus.damm, linux, linux-arm-kernel Define the SILK board dependent part of the R8A7794 sound device node. Add device node for Asahi Kasei AK4643 stereo codec to the I2C1 bus. Add the "simple-audio-card" device node to interconnect the SoC sound device and the codec. This patch is based on the commit 493b4da7c10c ("ARM: dts: porter: add sound support"). Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- This patch is against the 'renesas-devel-20160209-v4.5-rc3' tag of Simon Horman's 'renesas.git' repo. It depends on the 5 R8A7794 sound support patches in posted earlier this week in order to build and the R8A7794 PFC driver patches posted yesterday in order for the pins to be properly configured (but works without the pins configured too)... arch/arm/boot/dts/r8a7794-silk.dts | 71 +++++++++++++++++++++++++++++++++++++ 1 file changed, 71 insertions(+) Index: renesas/arch/arm/boot/dts/r8a7794-silk.dts =================================================================== --- renesas.orig/arch/arm/boot/dts/r8a7794-silk.dts +++ renesas/arch/arm/boot/dts/r8a7794-silk.dts @@ -10,6 +10,17 @@ * kind, whether express or implied. */ +/* + * SSI-AK4643 + * + * SW1: 2-1: AK4643 + * 2-3: ADV7511 + * + * This command is required before playback/capture: + * + * amixer set "LINEOUT Mixer DACL" on + */ + /dts-v1/; #include "r8a7794.dtsi" #include <dt-bindings/gpio/gpio.h> @@ -119,6 +130,30 @@ #clock-cells = <0>; clock-frequency = <74250000>; }; + + x9_clk: x9-clock { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <12288000>; + clock-output-names = "audio_clock"; + }; + + sound { + compatible = "simple-audio-card"; + + simple-audio-card,format = "left_j"; + simple-audio-card,bitclock-master = <&soundcodec>; + simple-audio-card,frame-master = <&soundcodec>; + + simple-audio-card,cpu { + sound-dai = <&rcar_sound>; + }; + + soundcodec: simple-audio-card,codec { + sound-dai = <&ak4643>; + clocks = <&x9_clk>; + }; + }; }; &extal_clk { @@ -183,6 +218,16 @@ renesas,groups = "usb1"; renesas,function = "usb1"; }; + + ssi_pins: sound { + renesas,groups = "ssi0129_ctrl", "ssi0_data", "ssi1_data"; + renesas,function = "ssi"; + }; + + audio_clk_pins: audio_clk { + renesas,groups = "audio_clkc"; + renesas,function = "audio_clk"; + }; }; &scif2 { @@ -220,6 +265,12 @@ status = "okay"; clock-frequency = <400000>; + ak4643: codec@12 { + compatible = "asahi-kasei,ak4643"; + #sound-dai-cells = <0>; + reg = <0x12>; + }; + composite-in@20 { compatible = "adi,adv7180"; reg = <0x20>; @@ -380,3 +431,23 @@ }; }; }; + +&rcar_sound { + pinctrl-0 = <&ssi_pins &audio_clk_pins>; + pinctrl-names = "default"; + status = "okay"; + + /* Single DAI */ + #sound-dai-cells = <0>; + + rcar_sound,dai { + dai0 { + playback = <&ssi0>; + capture = <&ssi1>; + }; + }; +}; + +&ssi1 { + shared-pin; +}; ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH] ARM: dts: silk: add sound support 2016-02-11 20:26 ` [PATCH] ARM: dts: silk: add sound support Sergei Shtylyov @ 2016-02-15 4:56 ` Kuninori Morimoto 0 siblings, 0 replies; 25+ messages in thread From: Kuninori Morimoto @ 2016-02-15 4:56 UTC (permalink / raw) To: Sergei Shtylyov Cc: horms, linux-renesas-soc, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, devicetree, magnus.damm, linux, linux-arm-kernel Hi > Define the SILK board dependent part of the R8A7794 sound device node. > Add device node for Asahi Kasei AK4643 stereo codec to the I2C1 bus. > Add the "simple-audio-card" device node to interconnect the SoC sound > device and the codec. > > This patch is based on the commit 493b4da7c10c ("ARM: dts: porter: add > sound support"). > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > --- > This patch is against the 'renesas-devel-20160209-v4.5-rc3' tag of Simon > Horman's 'renesas.git' repo. It depends on the 5 R8A7794 sound support patches > in posted earlier this week in order to build and the R8A7794 PFC driver > patches posted yesterday in order for the pins to be properly configured > (but works without the pins configured too)... Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> This patch doesn't use SRC, and it is no problem. We need fixup src.c driver for r8a7794 because it lacks some SRCs. > arch/arm/boot/dts/r8a7794-silk.dts | 71 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 71 insertions(+) > > Index: renesas/arch/arm/boot/dts/r8a7794-silk.dts > =================================================================== > --- renesas.orig/arch/arm/boot/dts/r8a7794-silk.dts > +++ renesas/arch/arm/boot/dts/r8a7794-silk.dts > @@ -10,6 +10,17 @@ > * kind, whether express or implied. > */ > > +/* > + * SSI-AK4643 > + * > + * SW1: 2-1: AK4643 > + * 2-3: ADV7511 > + * > + * This command is required before playback/capture: > + * > + * amixer set "LINEOUT Mixer DACL" on > + */ > + > /dts-v1/; > #include "r8a7794.dtsi" > #include <dt-bindings/gpio/gpio.h> > @@ -119,6 +130,30 @@ > #clock-cells = <0>; > clock-frequency = <74250000>; > }; > + > + x9_clk: x9-clock { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <12288000>; > + clock-output-names = "audio_clock"; > + }; > + > + sound { > + compatible = "simple-audio-card"; > + > + simple-audio-card,format = "left_j"; > + simple-audio-card,bitclock-master = <&soundcodec>; > + simple-audio-card,frame-master = <&soundcodec>; > + > + simple-audio-card,cpu { > + sound-dai = <&rcar_sound>; > + }; > + > + soundcodec: simple-audio-card,codec { > + sound-dai = <&ak4643>; > + clocks = <&x9_clk>; > + }; > + }; > }; > > &extal_clk { > @@ -183,6 +218,16 @@ > renesas,groups = "usb1"; > renesas,function = "usb1"; > }; > + > + ssi_pins: sound { > + renesas,groups = "ssi0129_ctrl", "ssi0_data", "ssi1_data"; > + renesas,function = "ssi"; > + }; > + > + audio_clk_pins: audio_clk { > + renesas,groups = "audio_clkc"; > + renesas,function = "audio_clk"; > + }; > }; > > &scif2 { > @@ -220,6 +265,12 @@ > status = "okay"; > clock-frequency = <400000>; > > + ak4643: codec@12 { > + compatible = "asahi-kasei,ak4643"; > + #sound-dai-cells = <0>; > + reg = <0x12>; > + }; > + > composite-in@20 { > compatible = "adi,adv7180"; > reg = <0x20>; > @@ -380,3 +431,23 @@ > }; > }; > }; > + > +&rcar_sound { > + pinctrl-0 = <&ssi_pins &audio_clk_pins>; > + pinctrl-names = "default"; > + status = "okay"; > + > + /* Single DAI */ > + #sound-dai-cells = <0>; > + > + rcar_sound,dai { > + dai0 { > + playback = <&ssi0>; > + capture = <&ssi1>; > + }; > + }; > +}; > + > +&ssi1 { > + shared-pin; > +}; > ^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH] ARM: dts: porter: fix JP3 jumper description [not found] <1674850.BZpGW9kEud@wasted.cogentembedded.com> ` (2 preceding siblings ...) 2016-02-11 20:26 ` [PATCH] ARM: dts: silk: add sound support Sergei Shtylyov @ 2016-02-11 21:49 ` Sergei Shtylyov 2016-02-15 4:50 ` Kuninori Morimoto 2016-02-13 22:26 ` [PATCH] ARM: dts: porter: remove enable prop from HS-USB device node Sergei Shtylyov 2016-04-13 19:36 ` [PATCH] ARM: dts: silk: add DU pins Sergei Shtylyov 5 siblings, 1 reply; 25+ messages in thread From: Sergei Shtylyov @ 2016-02-11 21:49 UTC (permalink / raw) To: horms, linux-renesas-soc, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, devicetree Cc: magnus.damm, linux, linux-arm-kernel When finishing the Porter sound support patch, I managed to call the JP3 jumper SW3 in the comment. Fix this along with (also miscalled) jumper positions... Fixes: 493b4da7c10c ("ARM: dts: porter: add sound support") Reported-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- This patch is against the 'renesas-devel-20160209-v4.5-rc3' tag of Simon Horman's 'renesas.git' repo. arch/arm/boot/dts/r8a7791-porter.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: renesas/arch/arm/boot/dts/r8a7791-porter.dts =================================================================== --- renesas.orig/arch/arm/boot/dts/r8a7791-porter.dts +++ renesas/arch/arm/boot/dts/r8a7791-porter.dts @@ -11,8 +11,8 @@ /* * SSI-AK4642 * - * SW3: 1: AK4642 - * 3: ADV7511 + * JP3: 2-1: AK4642 + * 2-3: ADV7511 * * This command is required before playback/capture: * ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH] ARM: dts: porter: fix JP3 jumper description 2016-02-11 21:49 ` [PATCH] ARM: dts: porter: fix JP3 jumper description Sergei Shtylyov @ 2016-02-15 4:50 ` Kuninori Morimoto 2016-02-15 21:55 ` Simon Horman 0 siblings, 1 reply; 25+ messages in thread From: Kuninori Morimoto @ 2016-02-15 4:50 UTC (permalink / raw) To: Sergei Shtylyov Cc: horms, linux-renesas-soc, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, devicetree, magnus.damm, linux, linux-arm-kernel Hi > When finishing the Porter sound support patch, I managed to call the JP3 > jumper SW3 in the comment. Fix this along with (also miscalled) jumper > positions... > > Fixes: 493b4da7c10c ("ARM: dts: porter: add sound support") > Reported-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > --- > This patch is against the 'renesas-devel-20160209-v4.5-rc3' tag of Simon > Horman's 'renesas.git' repo. > > arch/arm/boot/dts/r8a7791-porter.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > Index: renesas/arch/arm/boot/dts/r8a7791-porter.dts > =================================================================== > --- renesas.orig/arch/arm/boot/dts/r8a7791-porter.dts > +++ renesas/arch/arm/boot/dts/r8a7791-porter.dts > @@ -11,8 +11,8 @@ > /* > * SSI-AK4642 > * > - * SW3: 1: AK4642 > - * 3: ADV7511 > + * JP3: 2-1: AK4642 > + * 2-3: ADV7511 > * > * This command is required before playback/capture: > * > ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH] ARM: dts: porter: fix JP3 jumper description 2016-02-15 4:50 ` Kuninori Morimoto @ 2016-02-15 21:55 ` Simon Horman 0 siblings, 0 replies; 25+ messages in thread From: Simon Horman @ 2016-02-15 21:55 UTC (permalink / raw) To: Kuninori Morimoto Cc: Sergei Shtylyov, linux-renesas-soc, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, devicetree, magnus.damm, linux, linux-arm-kernel On Mon, Feb 15, 2016 at 04:50:17AM +0000, Kuninori Morimoto wrote: > > Hi > > > When finishing the Porter sound support patch, I managed to call the JP3 > > jumper SW3 in the comment. Fix this along with (also miscalled) jumper > > positions... > > > > Fixes: 493b4da7c10c ("ARM: dts: porter: add sound support") > > Reported-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Thanks, I have queued this up. ^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH] ARM: dts: porter: remove enable prop from HS-USB device node [not found] <1674850.BZpGW9kEud@wasted.cogentembedded.com> ` (3 preceding siblings ...) 2016-02-11 21:49 ` [PATCH] ARM: dts: porter: fix JP3 jumper description Sergei Shtylyov @ 2016-02-13 22:26 ` Sergei Shtylyov 2016-02-26 19:43 ` Sergei Shtylyov 2016-04-13 19:36 ` [PATCH] ARM: dts: silk: add DU pins Sergei Shtylyov 5 siblings, 1 reply; 25+ messages in thread From: Sergei Shtylyov @ 2016-02-13 22:26 UTC (permalink / raw) To: horms, linux-renesas-soc, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, devicetree Cc: magnus.damm, linux, linux-arm-kernel In the final versions of the Porter board (called "PORTER_C") Renesas decided to get rid of the Maxim Integrated MAX3355 OTG chip and didn't add any other provision to differ the host/gadget mode, so we'll have to remove no longer valid "renesas,enable-gpio" property from the HS-USB device node. Hopefully, the earlier revisions of the board were never seen in the wild... Fixes: c794f6a09a25 ("ARM: shmobile: porter: add HS-USB DT support") Reported-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- This patch is against the 'master' branch of Simon Horman's 'renesas.git' repo. arch/arm/boot/dts/r8a7791-porter.dts | 1 - 1 file changed, 1 deletion(-) Index: renesas/arch/arm/boot/dts/r8a7791-porter.dts =================================================================== --- renesas.orig/arch/arm/boot/dts/r8a7791-porter.dts +++ renesas/arch/arm/boot/dts/r8a7791-porter.dts @@ -283,7 +283,6 @@ pinctrl-names = "default"; status = "okay"; - renesas,enable-gpio = <&gpio5 31 GPIO_ACTIVE_HIGH>; }; &usbphy { ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH] ARM: dts: porter: remove enable prop from HS-USB device node 2016-02-13 22:26 ` [PATCH] ARM: dts: porter: remove enable prop from HS-USB device node Sergei Shtylyov @ 2016-02-26 19:43 ` Sergei Shtylyov 2016-03-02 0:47 ` Simon Horman 0 siblings, 1 reply; 25+ messages in thread From: Sergei Shtylyov @ 2016-02-26 19:43 UTC (permalink / raw) To: horms, linux-renesas-soc, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, devicetree Cc: magnus.damm, linux, linux-arm-kernel On 02/14/2016 01:26 AM, Sergei Shtylyov wrote: > In the final versions of the Porter board (called "PORTER_C") Renesas > decided to get rid of the Maxim Integrated MAX3355 OTG chip and didn't > add any other provision to differ the host/gadget mode, so we'll have to > remove no longer valid "renesas,enable-gpio" property from the HS-USB > device node. Hopefully, the earlier revisions of the board were never > seen in the wild... > > Fixes: c794f6a09a25 ("ARM: shmobile: porter: add HS-USB DT support") > Reported-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Simon, what about this patch? It was posted 12 days ago and no reaction whatsoever... MBR, Sergei ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH] ARM: dts: porter: remove enable prop from HS-USB device node 2016-02-26 19:43 ` Sergei Shtylyov @ 2016-03-02 0:47 ` Simon Horman 0 siblings, 0 replies; 25+ messages in thread From: Simon Horman @ 2016-03-02 0:47 UTC (permalink / raw) To: Sergei Shtylyov Cc: linux-renesas-soc, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, devicetree, magnus.damm, linux, linux-arm-kernel On Fri, Feb 26, 2016 at 10:43:27PM +0300, Sergei Shtylyov wrote: > On 02/14/2016 01:26 AM, Sergei Shtylyov wrote: > > >In the final versions of the Porter board (called "PORTER_C") Renesas > >decided to get rid of the Maxim Integrated MAX3355 OTG chip and didn't > >add any other provision to differ the host/gadget mode, so we'll have to > >remove no longer valid "renesas,enable-gpio" property from the HS-USB > >device node. Hopefully, the earlier revisions of the board were never > >seen in the wild... > > > >Fixes: c794f6a09a25 ("ARM: shmobile: porter: add HS-USB DT support") > >Reported-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > >Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > Simon, what about this patch? It was posted 12 days ago and no reaction > whatsoever... Hi Sergei, sorry for the extended delay. I have queued this up as a fix for v4.5. ^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH] ARM: dts: silk: add DU pins [not found] <1674850.BZpGW9kEud@wasted.cogentembedded.com> ` (4 preceding siblings ...) 2016-02-13 22:26 ` [PATCH] ARM: dts: porter: remove enable prop from HS-USB device node Sergei Shtylyov @ 2016-04-13 19:36 ` Sergei Shtylyov 2016-06-17 20:53 ` Sergei Shtylyov 5 siblings, 1 reply; 25+ messages in thread From: Sergei Shtylyov @ 2016-04-13 19:36 UTC (permalink / raw) To: horms, linux-renesas-soc, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, devicetree Cc: magnus.damm, linux, linux-arm-kernel Add the (previously omitted) DU pin data to the SILK board's device tree. Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- This patch is against the 'renesas-devel-20160411-v4.6-rc3' tag of Simon Horman's 'renesas.git' repo. It depends on the R8A7794 DU PFC driver patch just posted for the pins to be configured... arch/arm/boot/dts/r8a7794-silk.dts | 12 ++++++++++++ 1 file changed, 12 insertions(+) Index: renesas/arch/arm/boot/dts/r8a7794-silk.dts =================================================================== --- renesas.orig/arch/arm/boot/dts/r8a7794-silk.dts +++ renesas/arch/arm/boot/dts/r8a7794-silk.dts @@ -183,6 +183,16 @@ groups = "usb1"; function = "usb1"; }; + + du0_pins: du0 { + groups = "du0_rgb888", "du0_sync", "du0_disp", "du0_clk0_out"; + function = "du0"; + }; + + du1_pins: du1 { + groups = "du1_rgb666", "du1_sync", "du1_disp", "du1_clk0_out"; + function = "du1"; + }; }; &scif2 { @@ -360,6 +370,8 @@ }; &du { + pinctrl-0 = <&du0_pins &du1_pins>; + pinctrl-names = "default"; status = "okay"; clocks = <&mstp7_clks R8A7794_CLK_DU0>, ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH] ARM: dts: silk: add DU pins 2016-04-13 19:36 ` [PATCH] ARM: dts: silk: add DU pins Sergei Shtylyov @ 2016-06-17 20:53 ` Sergei Shtylyov 2016-06-20 8:35 ` Simon Horman 0 siblings, 1 reply; 25+ messages in thread From: Sergei Shtylyov @ 2016-06-17 20:53 UTC (permalink / raw) To: horms, linux-renesas-soc, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, devicetree Cc: magnus.damm, linux, linux-arm-kernel Hello. On 04/13/2016 10:36 PM, Sergei Shtylyov wrote: > Add the (previously omitted) DU pin data to the SILK board's device tree. > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > --- > This patch is against the 'renesas-devel-20160411-v4.6-rc3' tag of Simon > Horman's 'renesas.git' repo. It depends on the R8A7794 DU PFC driver patch > just posted for the pins to be configured... Simon, this patch seems stuck while the PFC driver patch hit Linus' tree long ago. :-( MBR, Sergei ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH] ARM: dts: silk: add DU pins 2016-06-17 20:53 ` Sergei Shtylyov @ 2016-06-20 8:35 ` Simon Horman 0 siblings, 0 replies; 25+ messages in thread From: Simon Horman @ 2016-06-20 8:35 UTC (permalink / raw) To: Sergei Shtylyov Cc: linux-renesas-soc, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, devicetree, magnus.damm, linux, linux-arm-kernel On Fri, Jun 17, 2016 at 11:53:21PM +0300, Sergei Shtylyov wrote: > Hello. > > On 04/13/2016 10:36 PM, Sergei Shtylyov wrote: > > >Add the (previously omitted) DU pin data to the SILK board's device tree. > > > >Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > > >--- > >This patch is against the 'renesas-devel-20160411-v4.6-rc3' tag of Simon > >Horman's 'renesas.git' repo. It depends on the R8A7794 DU PFC driver patch > >just posted for the pins to be configured... > > Simon, this patch seems stuck while the PFC driver patch hit Linus' tree > long ago. :-( Thanks, I have queued it up. ^ permalink raw reply [flat|nested] 25+ messages in thread
[parent not found: <cover.1456880499.git.horms+renesas@verge.net.au>]
* [PATCH] ARM: dts: porter: remove enable prop from HS-USB device node [not found] <cover.1456880499.git.horms+renesas@verge.net.au> @ 2016-03-02 1:05 ` Simon Horman 0 siblings, 0 replies; 25+ messages in thread From: Simon Horman @ 2016-03-02 1:05 UTC (permalink / raw) To: linux-renesas-soc Cc: linux-arm-kernel, Magnus Damm, Sergei Shtylyov, Simon Horman From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> In the final versions of the Porter board (called "PORTER_C") Renesas decided to get rid of the Maxim Integrated MAX3355 OTG chip and didn't add any other provision to differ the host/gadget mode, so we'll have to remove no longer valid "renesas,enable-gpio" property from the HS-USB device node. Hopefully, the earlier revisions of the board were never seen in the wild... Fixes: c794f6a09a25 ("ARM: shmobile: porter: add HS-USB DT support") Reported-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- arch/arm/boot/dts/r8a7791-porter.dts | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/boot/dts/r8a7791-porter.dts b/arch/arm/boot/dts/r8a7791-porter.dts index 6713b1ea732b..01d239c3eaaa 100644 --- a/arch/arm/boot/dts/r8a7791-porter.dts +++ b/arch/arm/boot/dts/r8a7791-porter.dts @@ -283,7 +283,6 @@ pinctrl-names = "default"; status = "okay"; - renesas,enable-gpio = <&gpio5 31 GPIO_ACTIVE_HIGH>; }; &usbphy { -- 2.1.4 ^ permalink raw reply related [flat|nested] 25+ messages in thread
end of thread, other threads:[~2016-06-20 8:35 UTC | newest]
Thread overview: 25+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1674850.BZpGW9kEud@wasted.cogentembedded.com>
2016-01-21 22:36 ` [PATCH] ARM: dts: porter: add sound support Sergei Shtylyov
2016-01-25 0:35 ` Kuninori Morimoto
2016-01-26 0:43 ` Simon Horman
2016-01-26 14:31 ` Sergei Shtylyov
2016-01-26 22:14 ` [PATCH] ARM: dts: porter: add MAX3355 support Sergei Shtylyov
2016-01-28 5:49 ` Yoshihiro Shimoda
2016-01-29 20:28 ` Sergei Shtylyov
2016-01-29 20:49 ` Sergei Shtylyov
2016-02-01 11:17 ` Yoshihiro Shimoda
2016-02-01 17:54 ` Sergei Shtylyov
2016-02-01 19:00 ` Sergei Shtylyov
2016-02-15 1:45 ` Simon Horman
2016-02-15 10:59 ` Sergei Shtylyov
2016-02-11 20:26 ` [PATCH] ARM: dts: silk: add sound support Sergei Shtylyov
2016-02-15 4:56 ` Kuninori Morimoto
2016-02-11 21:49 ` [PATCH] ARM: dts: porter: fix JP3 jumper description Sergei Shtylyov
2016-02-15 4:50 ` Kuninori Morimoto
2016-02-15 21:55 ` Simon Horman
2016-02-13 22:26 ` [PATCH] ARM: dts: porter: remove enable prop from HS-USB device node Sergei Shtylyov
2016-02-26 19:43 ` Sergei Shtylyov
2016-03-02 0:47 ` Simon Horman
2016-04-13 19:36 ` [PATCH] ARM: dts: silk: add DU pins Sergei Shtylyov
2016-06-17 20:53 ` Sergei Shtylyov
2016-06-20 8:35 ` Simon Horman
[not found] <cover.1456880499.git.horms+renesas@verge.net.au>
2016-03-02 1:05 ` [PATCH] ARM: dts: porter: remove enable prop from HS-USB device node Simon Horman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox