Re: [PATCH v2 1/2] pwm: add microchip soft ip corePWM driver

From: <Conor.Dooley@microchip.com>
To: <lkp@intel.com>, <Conor.Dooley@microchip.com>,
	<thierry.reding@gmail.com>, <u.kleine-koenig@pengutronix.de>,
	<lee.jones@linaro.org>
Cc: <kbuild-all@lists.01.org>, <Daire.McNamara@microchip.com>,
	<linux-kernel@vger.kernel.org>, <linux-pwm@vger.kernel.org>,
	<linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v2 1/2] pwm: add microchip soft ip corePWM driver
Date: Wed, 15 Jun 2022 19:20:47 +0000	[thread overview]
Message-ID: <53090614-fd86-25b6-557f-392323c0b2b7@microchip.com> (raw)
In-Reply-To: <202206160239.6lkHbYaU-lkp@intel.com>

On 15/06/2022 20:14, kernel test robot wrote:
> Hi Conor,
> 
> I love your patch! Yet something to improve:
> 
> [auto build test ERROR on thierry-reding-pwm/for-next]
> [also build test ERROR on linus/master v5.19-rc2 next-20220615]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Conor-Dooley/pwm-add-microchip-soft-ip-corePWM-driver/20220613-211851
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/thierry.reding/linux-pwm.git for-next
> config: powerpc-allyesconfig (https://download.01.org/0day-ci/archive/20220616/202206160239.6lkHbYaU-lkp@intel.com/config)
> compiler: powerpc-linux-gcc (GCC) 11.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/intel-lab-lkp/linux/commit/4451a8420f9fd16ee9a0801fcf02f1ec04bb8ab0
>         git remote add linux-review https://github.com/intel-lab-lkp/linux
>         git fetch --no-tags linux-review Conor-Dooley/pwm-add-microchip-soft-ip-corePWM-driver/20220613-211851
>         git checkout 4451a8420f9fd16ee9a0801fcf02f1ec04bb8ab0
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash
> 
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>    powerpc-linux-ld: drivers/pwm/pwm-microchip-core.o: in function `mchp_core_pwm_apply':
>>> pwm-microchip-core.c:(.text.mchp_core_pwm_apply+0x290): undefined reference to `__udivdi3'

Not new :) (well on this arch it is I guess)

FWIW Uwe, the fix was obv. not difficult but I ran into more
problems with idempotency while checking before resending with
the fix. I had fixed all the idempotency problems with my v2
but I think turning on the shadow registers in the core changed
the behaviour I was relying on so I won't send v3 with this fix
until that point.

Thanks,
Cnor.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv