[PATCH-RT] preempt.h: Fix implicit declaration of 'preempt_check_resched_rt'

[PATCH-RT] preempt.h: Fix implicit declaration of 'preempt_check_resched_rt'

[John Kacur]

When building a non-preempt kernel where CONFIG_PREEMPT_COUNT is not
defined the following build break occurs.

/home/jkacur/linux-rt/block/blk-softirq.c: In function ‘trigger_softirq’:
/home/jkacur/linux-rt/block/blk-softirq.c:54: error: implicit declaration of function ‘preempt_check_resched_rt’
make[2]: *** [block/blk-softirq.o] Error 1
make[1]: *** [block/blk-softirq.o] Error 2
make: *** [sub-make] Error 2

This patch fixes the build error by adding a define to the
!CONFIG_PREEMPT_COUNT section.

Signed-off-by: Clark Williams <williams@redhat.com>
Signed-off-by: John Kacur <jkacur@redhat.com>
---
 include/linux/preempt.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/preempt.h b/include/linux/preempt.h
index fa40695..58d8982 100644
--- a/include/linux/preempt.h
+++ b/include/linux/preempt.h
@@ -107,6 +107,7 @@ do { \
 #define preempt_disable_notrace()		do { } while (0)
 #define preempt_enable_no_resched_notrace()	do { } while (0)
 #define preempt_enable_notrace()		do { } while (0)
+#define preempt_check_resched_rt()	do { } while (0)
 
 #endif /* CONFIG_PREEMPT_COUNT */
 
-- 
1.7.2.3

--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH-RT] preempt.h: Fix implicit declaration of 'preempt_check_resched_rt'

[Steven Rostedt]

On Thu, 2012-03-08 at 21:13 +0100, John Kacur wrote:
> When building a non-preempt kernel where CONFIG_PREEMPT_COUNT is not
> defined the following build break occurs.
> 
> /home/jkacur/linux-rt/block/blk-softirq.c: In function ‘trigger_softirq’:
> /home/jkacur/linux-rt/block/blk-softirq.c:54: error: implicit declaration of function ‘preempt_check_resched_rt’
> make[2]: *** [block/blk-softirq.o] Error 1
> make[1]: *** [block/blk-softirq.o] Error 2
> make: *** [sub-make] Error 2
> 
> This patch fixes the build error by adding a define to the
> !CONFIG_PREEMPT_COUNT section.
> 
> Signed-off-by: Clark Williams <williams@redhat.com>

Why Clark's SOB? Did he write it and send it to you?

-- Steve

> Signed-off-by: John Kacur <jkacur@redhat.com>
> ---
>  include/linux/preempt.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/preempt.h b/include/linux/preempt.h
> index fa40695..58d8982 100644
> --- a/include/linux/preempt.h
> +++ b/include/linux/preempt.h
> @@ -107,6 +107,7 @@ do { \
>  #define preempt_disable_notrace()		do { } while (0)
>  #define preempt_enable_no_resched_notrace()	do { } while (0)
>  #define preempt_enable_notrace()		do { } while (0)
> +#define preempt_check_resched_rt()	do { } while (0)
>  
>  #endif /* CONFIG_PREEMPT_COUNT */
>  


--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH-RT] preempt.h: Fix implicit declaration of 'preempt_check_resched_rt'

[Clark Williams]

[-- Attachment #1: Type: text/plain, Size: 979 bytes --]

On Thu, 08 Mar 2012 15:17:20 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Thu, 2012-03-08 at 21:13 +0100, John Kacur wrote:
> > When building a non-preempt kernel where CONFIG_PREEMPT_COUNT is not
> > defined the following build break occurs.
> > 
> > /home/jkacur/linux-rt/block/blk-softirq.c: In function ‘trigger_softirq’:
> > /home/jkacur/linux-rt/block/blk-softirq.c:54: error: implicit declaration of function ‘preempt_check_resched_rt’
> > make[2]: *** [block/blk-softirq.o] Error 1
> > make[1]: *** [block/blk-softirq.o] Error 2
> > make: *** [sub-make] Error 2
> > 
> > This patch fixes the build error by adding a define to the
> > !CONFIG_PREEMPT_COUNT section.
> > 
> > Signed-off-by: Clark Williams <williams@redhat.com>
> 
> Why Clark's SOB? Did he write it and send it to you?

I suppose to be technically correct it should have been a Tested-by:

John found it while I was working on it and I tested it for him.

Clark

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH-RT] preempt.h: Fix implicit declaration of 'preempt_check_resched_rt'

[Steven Rostedt]

On Thu, 2012-03-08 at 14:22 -0600, Clark Williams wrote:
> On Thu, 08 Mar 2012 15:17:20 -0500
> Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> > On Thu, 2012-03-08 at 21:13 +0100, John Kacur wrote:
> > > When building a non-preempt kernel where CONFIG_PREEMPT_COUNT is not
> > > defined the following build break occurs.
> > > 
> > > /home/jkacur/linux-rt/block/blk-softirq.c: In function ‘trigger_softirq’:
> > > /home/jkacur/linux-rt/block/blk-softirq.c:54: error: implicit declaration of function ‘preempt_check_resched_rt’
> > > make[2]: *** [block/blk-softirq.o] Error 1
> > > make[1]: *** [block/blk-softirq.o] Error 2
> > > make: *** [sub-make] Error 2
> > > 
> > > This patch fixes the build error by adding a define to the
> > > !CONFIG_PREEMPT_COUNT section.
> > > 
> > > Signed-off-by: Clark Williams <williams@redhat.com>
> > 
> > Why Clark's SOB? Did he write it and send it to you?
> 
> I suppose to be technically correct it should have been a Tested-by:
> 
> John found it while I was working on it and I tested it for him.

Either a "Reported-by" if you mentioned it to John and he fixed it, or a
"Tested-by" if he fixed it and you tested it. You can have both if that
is true too.

But "Signed-off-by" has supposed legal significance. It means that you
are responsible for this patch. Either you authored it, or it went
through you to get to the git repo (ie. you are the maintainer that took
the patch).

All other tags are FYI only. Only the SOB is required and has real
meaning. Also, you should *never* add a SOB to a patch without the
person explicitly giving it to you.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH-RT] preempt.h: Fix implicit declaration of 'preempt_check_resched_rt'

[John Kacur]

On Thu, Mar 8, 2012 at 9:34 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> On Thu, 2012-03-08 at 14:22 -0600, Clark Williams wrote:
>> On Thu, 08 Mar 2012 15:17:20 -0500
>> Steven Rostedt <rostedt@goodmis.org> wrote:
>>
>> > On Thu, 2012-03-08 at 21:13 +0100, John Kacur wrote:
>> > > When building a non-preempt kernel where CONFIG_PREEMPT_COUNT is not
>> > > defined the following build break occurs.
>> > >
>> > > /home/jkacur/linux-rt/block/blk-softirq.c: In function ‘trigger_softirq’:
>> > > /home/jkacur/linux-rt/block/blk-softirq.c:54: error: implicit declaration of function ‘preempt_check_resched_rt’
>> > > make[2]: *** [block/blk-softirq.o] Error 1
>> > > make[1]: *** [block/blk-softirq.o] Error 2
>> > > make: *** [sub-make] Error 2
>> > >
>> > > This patch fixes the build error by adding a define to the
>> > > !CONFIG_PREEMPT_COUNT section.
>> > >
>> > > Signed-off-by: Clark Williams <williams@redhat.com>
>> >
>> > Why Clark's SOB? Did he write it and send it to you?
>>
>> I suppose to be technically correct it should have been a Tested-by:
>>
>> John found it while I was working on it and I tested it for him.
>
> Either a "Reported-by" if you mentioned it to John and he fixed it, or a
> "Tested-by" if he fixed it and you tested it. You can have both if that
> is true too.
>
> But "Signed-off-by" has supposed legal significance. It means that you
> are responsible for this patch. Either you authored it, or it went
> through you to get to the git repo (ie. you are the maintainer that took
> the patch).
>
> All other tags are FYI only. Only the SOB is required and has real
> meaning. Also, you should *never* add a SOB to a patch without the
> person explicitly giving it to you.
>
> -- Steve
>

Good, understood. Please change to

Tested-by: Clark Willilams <williams@redhat.com>
Signed-off-by: John Kacur <jkacur@redhat.com>

Note that the patch is for 3.2.9-rt17

Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH-RT] preempt.h: Fix implicit declaration of 'preempt_check_resched_rt'

[Steven Rostedt]

Thomas,

Can you apply this patch (with the fixed "tested-by") and push out a new
3.2-rt?

This bug is causing one of my "stable tests" to fail, and I wont push
out a new stable test until it passes. But I also wont add a fix that is
not in your tree. This means that 3.0-rt is being held back until this
gets applied.

Thanks,

-- Steve


On Thu, 2012-03-08 at 21:13 +0100, John Kacur wrote:
> When building a non-preempt kernel where CONFIG_PREEMPT_COUNT is not
> defined the following build break occurs.
> 
> /home/jkacur/linux-rt/block/blk-softirq.c: In function ‘trigger_softirq’:
> /home/jkacur/linux-rt/block/blk-softirq.c:54: error: implicit declaration of function ‘preempt_check_resched_rt’
> make[2]: *** [block/blk-softirq.o] Error 1
> make[1]: *** [block/blk-softirq.o] Error 2
> make: *** [sub-make] Error 2
> 
> This patch fixes the build error by adding a define to the
> !CONFIG_PREEMPT_COUNT section.
> 
> Signed-off-by: Clark Williams <williams@redhat.com>
> Signed-off-by: John Kacur <jkacur@redhat.com>
> ---
>  include/linux/preempt.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/preempt.h b/include/linux/preempt.h
> index fa40695..58d8982 100644
> --- a/include/linux/preempt.h
> +++ b/include/linux/preempt.h
> @@ -107,6 +107,7 @@ do { \
>  #define preempt_disable_notrace()		do { } while (0)
>  #define preempt_enable_no_resched_notrace()	do { } while (0)
>  #define preempt_enable_notrace()		do { } while (0)
> +#define preempt_check_resched_rt()	do { } while (0)
>  
>  #endif /* CONFIG_PREEMPT_COUNT */
>  


--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html