* Re: [PATCH v1 3/3] rtc: Use named initializers for platform_device_id arrays
From: Linus Walleij @ 2026-05-28 13:21 UTC (permalink / raw)
To: Uwe Kleine-König (The Capable Hub)
Cc: Alexandre Belloni, Karel Balej, Matti Vaittinen, Chanwoo Choi,
Krzysztof Kozlowski, André Draszik, linux-rtc, linux-kernel,
linux-samsung-soc
In-Reply-To: <d14b9076b2c7703708bcc5cc35f339cd97fc10cd.1779950275.git.u.kleine-koenig@baylibre.com>
On Thu, May 28, 2026 at 8:48 AM Uwe Kleine-König (The Capable Hub)
<u.kleine-koenig@baylibre.com> wrote:
> Named initializers are better readable and more robust to changes of the
> struct definition. This robustness is relevant for a planned change to
> struct platform_device_id replacing .driver_data by an anonymous union.
>
> While touching these arrays unify spacing and usage of commas.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
Reviewed-by: Linus Walleij <linusw@kernel.org>
Yours,
Linus Walleij
^ permalink raw reply
* Re: [PATCH v1 2/3] rtc: ab8500: Simplify driver_data handling
From: Linus Walleij @ 2026-05-28 13:22 UTC (permalink / raw)
To: Uwe Kleine-König (The Capable Hub)
Cc: Alexandre Belloni, linux-arm-kernel, linux-rtc, linux-kernel
In-Reply-To: <a909d3c59d00756130ac16051ceedbec0ce9cec7.1779950275.git.u.kleine-koenig@baylibre.com>
On Thu, May 28, 2026 at 8:48 AM Uwe Kleine-König (The Capable Hub)
<u.kleine-koenig@baylibre.com> wrote:
> Instead of hiding the rtc ops for the only supported device behind an
> abstraction for multi-device support, hardcode the used ops which gets rid
> of the need to call platform_get_device_id and two casts.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
Reviewed-by: Linus Walleij <linusw@kernel.org>
Yours,
Linus Walleij
^ permalink raw reply
* Re: [PATCH v1 3/3] rtc: Use named initializers for platform_device_id arrays
From: Matti Vaittinen @ 2026-05-29 7:33 UTC (permalink / raw)
To: Uwe Kleine-König (The Capable Hub), Alexandre Belloni
Cc: Karel Balej, Chanwoo Choi, Krzysztof Kozlowski,
André Draszik, linux-rtc, linux-kernel, linux-samsung-soc
In-Reply-To: <d14b9076b2c7703708bcc5cc35f339cd97fc10cd.1779950275.git.u.kleine-koenig@baylibre.com>
On 28/05/2026 09:48, Uwe Kleine-König (The Capable Hub) wrote:
> Named initializers are better readable and more robust to changes of the
> struct definition. This robustness is relevant for a planned change to
> struct platform_device_id replacing .driver_data by an anonymous union.
>
> While touching these arrays unify spacing and usage of commas.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub)<u.kleine-koenig@baylibre.com>
Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>
--
---
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~
^ permalink raw reply
* Re: [PATCH 0/5] rtc: renesas-rtca3: Various fixes and improvements
From: Lad, Prabhakar @ 2026-05-29 21:35 UTC (permalink / raw)
To: Alexandre Belloni, Claudiu Beznea, Geert Uytterhoeven
Cc: linux-rtc, linux-renesas-soc, linux-kernel, Biju Das,
Fabrizio Castro, Lad Prabhakar
In-Reply-To: <20260506164914.3987293-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
Hi,
On Wed, May 6, 2026 at 5:49 PM Prabhakar <prabhakar.csengg@gmail.com> wrote:
>
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Hi all,
>
> This patch series includes various fixes and improvements for the
> Renesas RTCA-3 RTC driver, including:
> - Fixing the polling condition when clearing the PIE bit during alarm
> setup error handling.
> - Checking the result of the RADJ polling during initial setup and
> propagating errors.
> - Correcting an error message related to reset control.
> - Fixing a typo in the documentation for the rtca3_ppb_per_cycle struct.
> - Refactoring year decoding logic into a helper function for better
> readability.
>
> Cheers,
> Prabhakar
>
> Lad Prabhakar (5):
> rtc: renesas-rtca3: Fix PIE clear polling condition in alarm setup
> error path
> rtc: renesas-rtca3: Check RADJ poll result during initial setup
> rtc: renesas-rtca3: Fix incorrect error message for reset assert
> rtc: renesas-rtca3: Fix typo in rtca3_ppb_per_cycle documentation
> rtc: renesas-rtca3: Factor out year decoding helper
>
> drivers/rtc/rtc-renesas-rtca3.c | 26 +++++++++++++++-----------
> 1 file changed, 15 insertions(+), 11 deletions(-)
>
Gentle ping.
Cheers,
Prabhakar
^ permalink raw reply
* Re: [PATCH v4] dt-bindings: clock: via,vt8500: Convert to DT Schema
From: Krzysztof Kozlowski @ 2026-05-30 7:35 UTC (permalink / raw)
To: Udaya Kiran Challa
Cc: mturquette, sboyd, robh, krzk+dt, conor+dt, skhan, me, linux-rtc,
devicetree, linux-kernel
In-Reply-To: <20260524151110.21277-1-challauday369@gmail.com>
On Sun, May 24, 2026 at 08:40:26PM +0530, Udaya Kiran Challa wrote:
> Convert the VIA/Wondermedia VT8500 and Wondermedia WM8xxx series SoCs clock
> controller binding from the legacy text format to DT schema.
>
> Signed-off-by: Udaya Kiran Challa <challauday369@gmail.com>
> ---
> Changelog:
> Changes since v3
> - Add schema select matching for via,vt8500-pmc
> - Allow hyphen in node names under patternProperties
> - Add dependentRequired validation for enable-reg/enable-bit
> - Fix example validation against PMC schema
>
> Link to v3:https://lore.kernel.org/all/20260524111813.39810-1-challauday369@gmail.com/
>
> Changes since v2:
> - Drop redundant description for clocks
> - Disable reg property for device clocks
> - Fix schema hierarchy to match actual DTS structure
>
> Link to v2:https://lore.kernel.org/all/20260521170810.19702-1-challauday369@gmail.com/
>
> Changes since v1:
> - Add default value for divisor-mask
> - Add required properties compatible and model
> - Fix example node name
> - Update example size cells and reg value
>
> Link to v1:https://lore.kernel.org/all/20260520025131.17772-1-challauday369@gmail.com/
> ---
> .../bindings/clock/via,vt8500-clock.yaml | 209 ++++++++++++++++++
> .../devicetree/bindings/clock/vt8500.txt | 74 -------
> 2 files changed, 209 insertions(+), 74 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/clock/via,vt8500-clock.yaml
> delete mode 100644 Documentation/devicetree/bindings/clock/vt8500.txt
>
> diff --git a/Documentation/devicetree/bindings/clock/via,vt8500-clock.yaml b/Documentation/devicetree/bindings/clock/via,vt8500-clock.yaml
> new file mode 100644
> index 000000000000..51a68df6c2f3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/via,vt8500-clock.yaml
> @@ -0,0 +1,209 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/via,vt8500-clock.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: VIA/Wondermedia VT8500 Clock Controller
How PMC is a clock controller? Really?
> +
> +maintainers:
> + - Michael Turquette <mturquette@baylibre.com>
> + - Stephen Boyd <sboyd@kernel.org>
Subsystem maintainers do not care about PMC. This can be platform
maintainer.
> +
> +description:
> + Clock controller bindings for VIA/Wondermedia VT8500 and Wondermedia WM8xxx
> + series SoCs.
> +
> +select:
> + properties:
> + compatible:
> + const: via,vt8500-pmc
> +
> + required:
> + - compatible
Why do you have select?
I don't understand your changes. This was not at v2 and I did not ask to
change that.
> +
> +properties:
> + compatible:
> + const: via,vt8500-pmc
So via,vt8500-clock.yaml or pmc? Why aren't you removing the pmc file?
Why is this located at clocks?
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + type: object
> + additionalProperties: true
No, this cannot be "true".
I finished review here.
Best regards,
Krzysztof
^ permalink raw reply
* Re: [PATCH] dt-bindings: arm: vt8500: via,vt8500-pmc: Convert to DT Schema
From: Krzysztof Kozlowski @ 2026-05-30 10:49 UTC (permalink / raw)
To: Udaya Kiran Challa
Cc: linux, robh, krzk+dt, conor+dt, skhan, me, linux-rtc, devicetree,
linux-kernel
In-Reply-To: <20260524110047.37590-1-challauday369@gmail.com>
On Sun, May 24, 2026 at 04:30:09PM +0530, Udaya Kiran Challa wrote:
> +properties:
> + compatible:
> + const: via,vt8500-pmc
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + type: object
> + additionalProperties: true
No, binding must be constrained. See writing-bindings or any other
binding. If you are unsure how to do something - open other existing
bindings. Do you see anywhere such syntax?
Best regards,
Krzysztof
^ permalink raw reply
* Re: [PATCH v4] dt-bindings: clock: via,vt8500: Convert to DT Schema
From: Uday Kiran @ 2026-05-31 16:49 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: mturquette, sboyd, robh, krzk+dt, conor+dt, skhan, me, linux-rtc,
devicetree, linux-kernel
In-Reply-To: <20260530-academic-aspiring-sawfly-7dcfab@quoll>
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/clock/via,vt8500-clock.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: VIA/Wondermedia VT8500 Clock Controller
>
> How PMC is a clock controller? Really?
No Krzysztof, actually that was a wrong direction in v4.
> > +
> > +maintainers:
> > + - Michael Turquette <mturquette@baylibre.com>
> > + - Stephen Boyd <sboyd@kernel.org>
>
>
> Subsystem maintainers do not care about PMC. This can be platform
> maintainer.
I agree with you. I changed maintainers accordingly.
> > +
> > +description:
> > + Clock controller bindings for VIA/Wondermedia VT8500 and Wondermedia WM8xxx
> > + series SoCs.
> > +
> > +select:
> > + properties:
> > + compatible:
> > + const: via,vt8500-pmc
> > +
> > + required:
> > + - compatible
>
> Why do you have select?
>
> I don't understand your changes. This was not at v2 and I did not ask to
> change that.
The select: block with via,vt8500-pmc and the clocks: type: object were
mistakenly added to via,vt8500-clock.yaml in v4 — leftover confusion from
trying to handle the PMC node's clock container in the same schema. In v5 these
are removed from the clock schema entirely. The PMC binding is now a separate
patch (via,vt8500-pmc.yaml) which is the right place for the clock container
node description.
> > +
> > +properties:
> > + compatible:
> > + const: via,vt8500-pmc
>
>
> So via,vt8500-clock.yaml or pmc? Why aren't you removing the pmc file?
> Why is this located at clocks?
In the next revision, this patch is scope only to the clock provider bindings
(via,vt8500-device-clock, via,vt8500-pll-clock, wm,*-pll-clock). It no longer
models PMC/top-level node properties and does not modify PMC binding files.
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + clocks:
> > + type: object
> > + additionalProperties: true
>
> No, this cannot be "true".
Agreed, I dropped that structure and kept strict schema validation.
I also fixed remaining related points from review/bot feedback:
- example validation issues
- dependency constraints (enable-reg/enable-bit, divisor-mask/divisor-reg)
- explicit reg: false for via,vt8500-device-clock
Regards,
Udaya Kiran Challa
^ permalink raw reply
* Re: [PATCH] dt-bindings: arm: vt8500: via,vt8500-pmc: Convert to DT Schema
From: Uday Kiran @ 2026-05-31 16:51 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux, robh, krzk+dt, conor+dt, skhan, me, linux-rtc, devicetree,
linux-kernel
In-Reply-To: <20260530-devious-magnificent-jackdaw-cc48c1@quoll>
> > +properties:
> > + compatible:
> > + const: via,vt8500-pmc
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + clocks:
> > + type: object
> > + additionalProperties: true
>
> No, binding must be constrained. See writing-bindings or any other
> binding. If you are unsure how to do something - open other existing
> bindings. Do you see anywhere such syntax?
Agreed. The clocks child node is now fully constrained: #address-cells and
#size-cells are declared with fixed values and marked required.
additionalProperties: true is retained only because the child clock nodes
inside have their own schema (via,vt8500-clock.yaml) with
additionalProperties: false, which is the pattern described in
example-schema.yaml for child nodes with their own device schema.
Regards,
Udaya Kiran Challa
^ permalink raw reply
* [PATCH v5] dt-bindings: clock: via,vt8500: Convert to DT Schema
From: Udaya Kiran Challa @ 2026-05-31 17:09 UTC (permalink / raw)
To: alchark, krzk, robh, krzk+dt, conor+dt
Cc: skhan, me, linux-rtc, devicetree, linux-kernel,
Udaya Kiran Challa
Convert the VIA/Wondermedia VT8500 and Wondermedia WM8xxx series SoCs clock
controller binding from the legacy text format to DT schema.
Signed-off-by: Udaya Kiran Challa <challauday369@gmail.com>
---
Changelog:
Changes since v4:
- Remove schema select matching for via,vt8500-pmc
- Add dependentRequired validation for divisor-mask
- Fix maintainers list
- Add reg false condition for device clock
- Fix example validation against clocks child node
Link to v4:https://lore.kernel.org/all/20260524151110.21277-1-challauday369@gmail.com/
Changes since v3:
- Add schema select matching for via,vt8500-pmc
- Allow hyphen in node names under patternProperties
- Add dependentRequired validation for enable-reg/enable-bit
- Fix example validation against PMC schema
Link to v3:https://lore.kernel.org/all/20260524111813.39810-1-challauday369@gmail.com/
Changes since v2:
- Drop redundant description for clocks
- Disable reg property for device clocks
- Fix schema hierarchy to match actual DTS structure
Link to v2:https://lore.kernel.org/all/20260521170810.19702-1-challauday369@gmail.com/
Changes since v1:
- Add default value for divisor-mask
- Add required properties compatible and model
- Fix example node name
- Update example size cells and reg value
Link to v1:https://lore.kernel.org/all/20260520025131.17772-1-challauday369@gmail.com/
---
.../bindings/clock/via,vt8500-clock.yaml | 133 ++++++++++++++++++
.../devicetree/bindings/clock/vt8500.txt | 74 ----------
2 files changed, 133 insertions(+), 74 deletions(-)
create mode 100644 Documentation/devicetree/bindings/clock/via,vt8500-clock.yaml
delete mode 100644 Documentation/devicetree/bindings/clock/vt8500.txt
diff --git a/Documentation/devicetree/bindings/clock/via,vt8500-clock.yaml b/Documentation/devicetree/bindings/clock/via,vt8500-clock.yaml
new file mode 100644
index 000000000000..e2e674d95654
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/via,vt8500-clock.yaml
@@ -0,0 +1,133 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/clock/via,vt8500-clock.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: VIA/Wondermedia VT8500 Clock Controller
+
+maintainers:
+ - Alexey Charkov <alchark@gmail.com>
+ - Krzysztof Kozlowski <krzk@kernel.org>
+
+description:
+ Clock controller bindings for VIA/Wondermedia VT8500 and Wondermedia WM8xxx
+ series SoCs.
+
+properties:
+ compatible:
+ enum:
+ - via,vt8500-pll-clock
+ - wm,wm8650-pll-clock
+ - wm,wm8750-pll-clock
+ - wm,wm8850-pll-clock
+ - via,vt8500-device-clock
+
+ reg:
+ description: Offset of the PLL register within the PMC register space.
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ "#clock-cells":
+ const: 0
+
+ clock-output-names:
+ maxItems: 1
+
+ enable-reg:
+ description: Offset of the clock enable register within the PMC register space.
+ $ref: /schemas/types.yaml#/definitions/uint32
+
+ enable-bit:
+ description: Bit index controlling clock enable.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ maximum: 31
+
+ divisor-reg:
+ description: Offset of the clock divisor register within the PMC register space.
+ $ref: /schemas/types.yaml#/definitions/uint32
+
+ divisor-mask:
+ description: Bitmask describing the divisor field inside divisor-reg.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ default: 0x1f
+
+required:
+ - compatible
+ - clocks
+ - "#clock-cells"
+
+allOf:
+ - if:
+ properties:
+ compatible:
+ const: via,vt8500-device-clock
+ then:
+ properties:
+ reg: false
+ anyOf:
+ - required:
+ - enable-reg
+ - enable-bit
+ - required:
+ - divisor-reg
+ - if:
+ properties:
+ compatible:
+ enum:
+ - via,vt8500-pll-clock
+ - wm,wm8650-pll-clock
+ - wm,wm8750-pll-clock
+ - wm,wm8850-pll-clock
+ then:
+ required:
+ - reg
+
+dependentRequired:
+ enable-reg:
+ - enable-bit
+ enable-bit:
+ - enable-reg
+ divisor-mask:
+ - divisor-reg
+
+additionalProperties: false
+
+examples:
+ - |
+ clocks {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ ref25: clock-25000000 {
+ compatible = "fixed-clock";
+ clock-frequency = <25000000>;
+ #clock-cells = <0>;
+ };
+
+ plla: clock@200 {
+ compatible = "wm,wm8650-pll-clock";
+ reg = <0x200>;
+ clocks = <&ref25>;
+ #clock-cells = <0>;
+ };
+
+ pllb: clock@204 {
+ compatible = "wm,wm8650-pll-clock";
+ reg = <0x204>;
+ clocks = <&ref25>;
+ #clock-cells = <0>;
+ };
+
+ clksdhc: sdhc {
+ compatible = "via,vt8500-device-clock";
+ clocks = <&pllb>;
+ #clock-cells = <0>;
+ divisor-reg = <0x328>;
+ divisor-mask = <0x3f>;
+ enable-reg = <0x254>;
+ enable-bit = <18>;
+ };
+ };
diff --git a/Documentation/devicetree/bindings/clock/vt8500.txt b/Documentation/devicetree/bindings/clock/vt8500.txt
deleted file mode 100644
index 91d71cc0314a..000000000000
--- a/Documentation/devicetree/bindings/clock/vt8500.txt
+++ /dev/null
@@ -1,74 +0,0 @@
-Device Tree Clock bindings for arch-vt8500
-
-This binding uses the common clock binding[1].
-
-[1] Documentation/devicetree/bindings/clock/clock-bindings.txt
-
-Required properties:
-- compatible : shall be one of the following:
- "via,vt8500-pll-clock" - for a VT8500/WM8505 PLL clock
- "wm,wm8650-pll-clock" - for a WM8650 PLL clock
- "wm,wm8750-pll-clock" - for a WM8750 PLL clock
- "wm,wm8850-pll-clock" - for a WM8850 PLL clock
- "via,vt8500-device-clock" - for a VT/WM device clock
-
-Required properties for PLL clocks:
-- reg : shall be the control register offset from PMC base for the pll clock.
-- clocks : shall be the input parent clock phandle for the clock. This should
- be the reference clock.
-- #clock-cells : from common clock binding; shall be set to 0.
-
-Required properties for device clocks:
-- clocks : shall be the input parent clock phandle for the clock. This should
- be a pll output.
-- #clock-cells : from common clock binding; shall be set to 0.
-
-
-Device Clocks
-
-Device clocks are required to have one or both of the following sets of
-properties:
-
-
-Gated device clocks:
-
-Required properties:
-- enable-reg : shall be the register offset from PMC base for the enable
- register.
-- enable-bit : shall be the bit within enable-reg to enable/disable the clock.
-
-
-Divisor device clocks:
-
-Required property:
-- divisor-reg : shall be the register offset from PMC base for the divisor
- register.
-Optional property:
-- divisor-mask : shall be the mask for the divisor register. Defaults to 0x1f
- if not specified.
-
-
-For example:
-
-ref25: ref25M {
- #clock-cells = <0>;
- compatible = "fixed-clock";
- clock-frequency = <25000000>;
-};
-
-plla: plla {
- #clock-cells = <0>;
- compatible = "wm,wm8650-pll-clock";
- clocks = <&ref25>;
- reg = <0x200>;
-};
-
-sdhc: sdhc {
- #clock-cells = <0>;
- compatible = "via,vt8500-device-clock";
- clocks = <&pllb>;
- divisor-reg = <0x328>;
- divisor-mask = <0x3f>;
- enable-reg = <0x254>;
- enable-bit = <18>;
-};
--
2.43.0
^ permalink raw reply related
* [PATCH v2] dt-bindings: arm: vt8500: via,vt8500-pmc: Convert to DT Schema
From: Udaya Kiran Challa @ 2026-05-31 17:15 UTC (permalink / raw)
To: alchark, krzk, robh, krzk+dt, conor+dt
Cc: skhan, me, linux-rtc, devicetree, linux-kernel,
Udaya Kiran Challa
Convert the VIA/Wondermedia VT8500 Power Management controller binding
from the legacy text format to DT schema.
Signed-off-by: Udaya Kiran Challa <challauday369@gmail.com>
---
Changelog:
Changes since v1:
- Make child node binding constrained
- Fix example to include the clock container node
- Fix maintainers list
Link to v1:https://lore.kernel.org/all/20260524110047.37590-1-challauday369@gmail.com/
---
.../bindings/arm/vt8500/via,vt8500-pmc.txt | 13 -----
.../bindings/arm/vt8500/via,vt8500-pmc.yaml | 53 +++++++++++++++++++
2 files changed, 53 insertions(+), 13 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/arm/vt8500/via,vt8500-pmc.txt
create mode 100644 Documentation/devicetree/bindings/arm/vt8500/via,vt8500-pmc.yaml
diff --git a/Documentation/devicetree/bindings/arm/vt8500/via,vt8500-pmc.txt b/Documentation/devicetree/bindings/arm/vt8500/via,vt8500-pmc.txt
deleted file mode 100644
index 521b9c7de933..000000000000
--- a/Documentation/devicetree/bindings/arm/vt8500/via,vt8500-pmc.txt
+++ /dev/null
@@ -1,13 +0,0 @@
-VIA/Wondermedia VT8500 Power Management Controller
------------------------------------------------------
-
-Required properties:
-- compatible : "via,vt8500-pmc"
-- reg : Should contain 1 register ranges(address and length)
-
-Example:
-
- pmc@d8130000 {
- compatible = "via,vt8500-pmc";
- reg = <0xd8130000 0x1000>;
- };
diff --git a/Documentation/devicetree/bindings/arm/vt8500/via,vt8500-pmc.yaml b/Documentation/devicetree/bindings/arm/vt8500/via,vt8500-pmc.yaml
new file mode 100644
index 000000000000..e340281e5726
--- /dev/null
+++ b/Documentation/devicetree/bindings/arm/vt8500/via,vt8500-pmc.yaml
@@ -0,0 +1,53 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/arm/vt8500/via,vt8500-pmc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: VIA/Wondermedia VT8500 Power Management Controller
+
+maintainers:
+ - Alexey Charkov <alchark@gmail.com>
+ - Krzysztof Kozlowski <krzk@kernel.org>
+
+description:
+ The VIA/Wondermedia Power Management Controller provides register access for
+ clock and power management functions on VT8500 and WM8xxx series SoCs.
+
+properties:
+ compatible:
+ const: via,vt8500-pmc
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ type: object
+ description: Container node for VT8500/WM8xxx clock provider nodes.
+ properties:
+ "#address-cells":
+ const: 1
+ "#size-cells":
+ const: 0
+ required:
+ - "#address-cells"
+ - "#size-cells"
+ additionalProperties: true
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ pmc@d8130000 {
+ compatible = "via,vt8500-pmc";
+ reg = <0xd8130000 0x1000>;
+
+ clocks {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
+ };
--
2.43.0
^ permalink raw reply related
* Re: [PATCH v5] dt-bindings: clock: via,vt8500: Convert to DT Schema
From: Alexey Charkov @ 2026-06-01 8:30 UTC (permalink / raw)
To: Udaya Kiran Challa
Cc: krzk, robh, krzk+dt, conor+dt, skhan, me, linux-rtc, devicetree,
linux-kernel
In-Reply-To: <20260531171041.4149-1-challauday369@gmail.com>
On Sun, May 31, 2026 at 9:11 PM Udaya Kiran Challa
<challauday369@gmail.com> wrote:
>
> Convert the VIA/Wondermedia VT8500 and Wondermedia WM8xxx series SoCs clock
> controller binding from the legacy text format to DT schema.
>
> Signed-off-by: Udaya Kiran Challa <challauday369@gmail.com>
> ---
Hi,
I'm not sure that this separation of the clock controller binding vs.
PMC is the right way to go (yes, I know it's been that way in the .txt
document, but still).
The clock controller is not a standalone device on these SoCs - it's
one of the functions of the PMC (weirdly enough), with its MMIO space
interweaved between clock statuses and enable controls,
reset/hibernation control, system timer and watchdog, then again clock
control. You can't run the clock controller separately from the
resources provided in its parent PMC node, because all those *reg
nodes are just offsets into the PMC controller's MMIO space. So the
way it's done currently doesn't look like idiomatic DT to me.
If I were to implement support for all that beauty today, I would have
made a top-level MFD node owning the whole MMIO range of the PMC, put
clock IDs into a dt-bindings header file and just implement all clock
operations in code without putting those offsets and bits into the
device tree. They are not configurable, they are not board specific,
they just constitute the interface of a particular SoC revision which
follows directly from a SoC versioned PMC compatible string.
The only thing that would have showed up in the DT then would have
been the PMC node with a register range and a bunch of named
interrupts (not for clocks, but for other functions), a
clock-controller attribute and a single clock cell to pass arbitrarily
assigned clock IDs from a new per-SoC dt-bindings header.
I'm pretty sure there are no users of these DTs outside of mainline
Linux, because vendor kernels used board files, and no DT-enabled
firmware has ever been created, thus the only way to boot these boards
with a device tree has only ever been via an appended-DTB uImage (i.e.
the DTB always comes from the currently used Linux kernel source).
From this perspective I believe redoing the DT in a more
hardware-aligned fashion (and breaking DT ABI) could be better than
making the current suboptimal approach more "official" by encoding it
in DT schema. Krzysztof will likely disagree though :)
Best regards,
Alexey
^ permalink raw reply
* Re: [PATCH v2] dt-bindings: arm: vt8500: via,vt8500-pmc: Convert to DT Schema
From: Alexey Charkov @ 2026-06-01 8:47 UTC (permalink / raw)
To: Udaya Kiran Challa
Cc: krzk, robh, krzk+dt, conor+dt, skhan, me, linux-rtc, devicetree,
linux-kernel
In-Reply-To: <20260531171612.4536-1-challauday369@gmail.com>
On Sun, May 31, 2026 at 9:16 PM Udaya Kiran Challa
<challauday369@gmail.com> wrote:
>
> Convert the VIA/Wondermedia VT8500 Power Management controller binding
> from the legacy text format to DT schema.
>
> Signed-off-by: Udaya Kiran Challa <challauday369@gmail.com>
> ---
> Changelog:
> Changes since v1:
> - Make child node binding constrained
> - Fix example to include the clock container node
> - Fix maintainers list
>
> Link to v1:https://lore.kernel.org/all/20260524110047.37590-1-challauday369@gmail.com/
> ---
> .../bindings/arm/vt8500/via,vt8500-pmc.txt | 13 -----
> .../bindings/arm/vt8500/via,vt8500-pmc.yaml | 53 +++++++++++++++++++
> 2 files changed, 53 insertions(+), 13 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/arm/vt8500/via,vt8500-pmc.txt
> create mode 100644 Documentation/devicetree/bindings/arm/vt8500/via,vt8500-pmc.yaml
>
> diff --git a/Documentation/devicetree/bindings/arm/vt8500/via,vt8500-pmc.txt b/Documentation/devicetree/bindings/arm/vt8500/via,vt8500-pmc.txt
> deleted file mode 100644
> index 521b9c7de933..000000000000
> --- a/Documentation/devicetree/bindings/arm/vt8500/via,vt8500-pmc.txt
> +++ /dev/null
> @@ -1,13 +0,0 @@
> -VIA/Wondermedia VT8500 Power Management Controller
> ------------------------------------------------------
> -
> -Required properties:
> -- compatible : "via,vt8500-pmc"
> -- reg : Should contain 1 register ranges(address and length)
> -
> -Example:
> -
> - pmc@d8130000 {
> - compatible = "via,vt8500-pmc";
> - reg = <0xd8130000 0x1000>;
> - };
> diff --git a/Documentation/devicetree/bindings/arm/vt8500/via,vt8500-pmc.yaml b/Documentation/devicetree/bindings/arm/vt8500/via,vt8500-pmc.yaml
> new file mode 100644
> index 000000000000..e340281e5726
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/vt8500/via,vt8500-pmc.yaml
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/vt8500/via,vt8500-pmc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: VIA/Wondermedia VT8500 Power Management Controller
> +
> +maintainers:
> + - Alexey Charkov <alchark@gmail.com>
> + - Krzysztof Kozlowski <krzk@kernel.org>
> +
> +description:
> + The VIA/Wondermedia Power Management Controller provides register access for
> + clock and power management functions on VT8500 and WM8xxx series SoCs.
> +
> +properties:
> + compatible:
> + const: via,vt8500-pmc
Each SoC version had different registers within the PMC node (even
though key components such as the OS timer and reset control kept the
same offsets and function). So this really should be a SoC-versioned
enum rather than a single "compatible", as they were never really
mutually compatible (despite what current DTs say).
> + reg:
> + maxItems: 1
> +
> + clocks:
> + type: object
> + description: Container node for VT8500/WM8xxx clock provider nodes.
> + properties:
> + "#address-cells":
> + const: 1
> + "#size-cells":
> + const: 0
> + required:
> + - "#address-cells"
> + - "#size-cells"
#address-cells and #size-cells are automatically required once the
subnodes have regs, so it seems that this whole section could become
just "clocks: true" with no particular loss of meaning.
> + additionalProperties: true
If the PMC binding ends up separate from the clock control bindings
(which I'm somewhat skeptical of, see [1]), shouldn't the subnodes of
this clocks node be explicitly specified to follow that binding? The
fixed 25 MHz reference clock is not part of the PMC and doesn't belong
there (despite what current device trees contain), but the rest do.
[1] https://lore.kernel.org/all/CABjd4YzJoHrx1suMbhNvrMP+X=d=thvXYwSY=UD-4Qy=7-qmjw@mail.gmail.com/
Best regards,
Alexey
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + pmc@d8130000 {
> + compatible = "via,vt8500-pmc";
> + reg = <0xd8130000 0x1000>;
> +
> + clocks {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> + };
> --
> 2.43.0
^ permalink raw reply
* [PATCH 0/2] rtc: aspeed: Add AST2700 RTC support
From: Tommy Huang @ 2026-06-01 9:14 UTC (permalink / raw)
To: Alexandre Belloni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Joel Stanley, Andrew Jeffery
Cc: linux-rtc, devicetree, linux-kernel, linux-arm-kernel,
linux-aspeed, Tommy Huang
This patch series adds support for the ASPEED AST2700 RTC define,
includeing dt-binding in the Document and rtc-aspeed.c
Signed-off-by: Tommy Huang <tommy_huang@aspeedtech.com>
---
Tommy Huang (2):
dt-bindings: rtc: add ASPEED AST2700 compatible
rtc: aspeed: add AST2700 compatible
Documentation/devicetree/bindings/rtc/trivial-rtc.yaml | 2 ++
drivers/rtc/rtc-aspeed.c | 1 +
2 files changed, 3 insertions(+)
---
base-commit: e43ffb69e0438cddd72aaa30898b4dc446f664f8
change-id: 20260601-ast2700-rtc-d4adb51d2148
Best regards,
--
Tommy Huang <tommy_huang@aspeedtech.com>
^ permalink raw reply
* [PATCH 1/2] dt-bindings: rtc: add ASPEED AST2700 compatible
From: Tommy Huang @ 2026-06-01 9:14 UTC (permalink / raw)
To: Alexandre Belloni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Joel Stanley, Andrew Jeffery
Cc: linux-rtc, devicetree, linux-kernel, linux-arm-kernel,
linux-aspeed, Tommy Huang
In-Reply-To: <20260601-ast2700-rtc-v1-0-15d4ca46500a@aspeedtech.com>
Document the compatible string for the RTC controller found on
ASPEED AST2700 SoCs.
Signed-off-by: Tommy Huang <tommy_huang@aspeedtech.com>
---
Documentation/devicetree/bindings/rtc/trivial-rtc.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
index 722176c831aa..f4d0eed98a08 100644
--- a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
+++ b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
@@ -30,6 +30,8 @@ properties:
- aspeed,ast2500-rtc
# ASPEED BMC ast2600 Real-time Clock
- aspeed,ast2600-rtc
+ # ASPEED BMC ast2700 Real-time Clock
+ - aspeed,ast2700-rtc
# Conexant Digicolor Real Time Clock Controller
- cnxt,cx92755-rtc
# I2C, 32-Bit Binary Counter Watchdog RTC with Trickle Charger and Reset Input/Output
--
2.34.1
^ permalink raw reply related
* [PATCH 2/2] rtc: aspeed: add AST2700 compatible
From: Tommy Huang @ 2026-06-01 9:14 UTC (permalink / raw)
To: Alexandre Belloni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Joel Stanley, Andrew Jeffery
Cc: linux-rtc, devicetree, linux-kernel, linux-arm-kernel,
linux-aspeed, Tommy Huang
In-Reply-To: <20260601-ast2700-rtc-v1-0-15d4ca46500a@aspeedtech.com>
Add support for matching the RTC controller on ASPEED AST2700 SoCs.
The AST2700 RTC controller is compatible with the existing ASPEED
RTC driver implementation.
Signed-off-by: Tommy Huang <tommy_huang@aspeedtech.com>
---
drivers/rtc/rtc-aspeed.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/rtc/rtc-aspeed.c b/drivers/rtc/rtc-aspeed.c
index 0d0053b52f9b..8f5b440f8c0a 100644
--- a/drivers/rtc/rtc-aspeed.c
+++ b/drivers/rtc/rtc-aspeed.c
@@ -111,6 +111,7 @@ static const struct of_device_id aspeed_rtc_match[] = {
{ .compatible = "aspeed,ast2400-rtc", },
{ .compatible = "aspeed,ast2500-rtc", },
{ .compatible = "aspeed,ast2600-rtc", },
+ { .compatible = "aspeed,ast2700-rtc", },
{}
};
MODULE_DEVICE_TABLE(of, aspeed_rtc_match);
--
2.34.1
^ permalink raw reply related
* Re: [PATCH v5] dt-bindings: clock: via,vt8500: Convert to DT Schema
From: Krzysztof Kozlowski @ 2026-06-01 11:40 UTC (permalink / raw)
To: Udaya Kiran Challa
Cc: alchark, robh, krzk+dt, conor+dt, skhan, me, linux-rtc,
devicetree, linux-kernel
In-Reply-To: <20260531171041.4149-1-challauday369@gmail.com>
On Sun, May 31, 2026 at 10:39:55PM +0530, Udaya Kiran Challa wrote:
> Convert the VIA/Wondermedia VT8500 and Wondermedia WM8xxx series SoCs clock
> controller binding from the legacy text format to DT schema.
>
> Signed-off-by: Udaya Kiran Challa <challauday369@gmail.com>
> ---
> Changelog:
> Changes since v4:
My comments from v2 still apply. Almost all of them.
You a PMC binding and preferrably all this goes to that binding.
Best regards,
Krzysztof
^ permalink raw reply
* Re: [PATCH v2] dt-bindings: arm: vt8500: via,vt8500-pmc: Convert to DT Schema
From: Krzysztof Kozlowski @ 2026-06-01 11:42 UTC (permalink / raw)
To: Udaya Kiran Challa, alchark, robh, krzk+dt, conor+dt
Cc: skhan, me, linux-rtc, devicetree, linux-kernel
In-Reply-To: <20260531171612.4536-1-challauday369@gmail.com>
On 31/05/2026 19:15, Udaya Kiran Challa wrote:
> + clocks:
> + type: object
> + description: Container node for VT8500/WM8xxx clock provider nodes.
> + properties:
> + "#address-cells":
> + const: 1
> + "#size-cells":
> + const: 0
> + required:
> + - "#address-cells"
> + - "#size-cells"
> + additionalProperties: true
No improvements. Which part was confusing? Or let's rephrase, from where
did you take such syntax?
Best regards,
Krzysztof
^ permalink raw reply
* Re: [PATCH] dt-bindings: arm: vt8500: via,vt8500-pmc: Convert to DT Schema
From: Krzysztof Kozlowski @ 2026-06-01 11:42 UTC (permalink / raw)
To: Uday Kiran
Cc: linux, robh, krzk+dt, conor+dt, skhan, me, linux-rtc, devicetree,
linux-kernel
In-Reply-To: <CAAj-GBnDiiKPwCQz1KDp6kMx9mQzmxSJpAuanbWsjt4iSzoZQQ@mail.gmail.com>
On 31/05/2026 18:51, Uday Kiran wrote:
>>> +properties:
>>> + compatible:
>>> + const: via,vt8500-pmc
>>> +
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + clocks:
>>> + type: object
>>> + additionalProperties: true
>>
>> No, binding must be constrained. See writing-bindings or any other
>> binding. If you are unsure how to do something - open other existing
>> bindings. Do you see anywhere such syntax?
>
> Agreed. The clocks child node is now fully constrained: #address-cells and
No, it is not. What are you speaking about? Open this patch and look -
how anything "IS" there constrained?
Best regards,
Krzysztof
^ permalink raw reply
* Re: [PATCH v4] dt-bindings: clock: via,vt8500: Convert to DT Schema
From: Krzysztof Kozlowski @ 2026-06-01 11:44 UTC (permalink / raw)
To: Uday Kiran
Cc: mturquette, sboyd, robh, krzk+dt, conor+dt, skhan, me, linux-rtc,
devicetree, linux-kernel
In-Reply-To: <CAAj-GBmNXvTNbnQ8hOzsjnQd0Oi4a17LY8yjb8HTbD4PpTXH3Q@mail.gmail.com>
On 31/05/2026 18:49, Uday Kiran wrote:
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/clock/via,vt8500-clock.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: VIA/Wondermedia VT8500 Clock Controller
>>
>> How PMC is a clock controller? Really?
>
> No Krzysztof, actually that was a wrong direction in v4.
>
>>> +
>>> +maintainers:
>>> + - Michael Turquette <mturquette@baylibre.com>
>>> + - Stephen Boyd <sboyd@kernel.org>
>>
>>
>> Subsystem maintainers do not care about PMC. This can be platform
>> maintainer.
>
> I agree with you. I changed maintainers accordingly.
>
>>> +
>>> +description:
>>> + Clock controller bindings for VIA/Wondermedia VT8500 and Wondermedia WM8xxx
>>> + series SoCs.
>>> +
>>> +select:
>>> + properties:
>>> + compatible:
>>> + const: via,vt8500-pmc
>>> +
>>> + required:
>>> + - compatible
>>
>> Why do you have select?
>>
>> I don't understand your changes. This was not at v2 and I did not ask to
>> change that.
>
> The select: block with via,vt8500-pmc and the clocks: type: object were
> mistakenly added to via,vt8500-clock.yaml in v4 — leftover confusion from
> trying to handle the PMC node's clock container in the same schema. In v5 these
> are removed from the clock schema entirely. The PMC binding is now a separate
> patch (via,vt8500-pmc.yaml) which is the right place for the clock container
> node description.
>
>>> +
>>> +properties:
>>> + compatible:
>>> + const: via,vt8500-pmc
>>
>>
>> So via,vt8500-clock.yaml or pmc? Why aren't you removing the pmc file?
>> Why is this located at clocks?
>
> In the next revision, this patch is scope only to the clock provider bindings
> (via,vt8500-device-clock, via,vt8500-pll-clock, wm,*-pll-clock). It no longer
> models PMC/top-level node properties and does not modify PMC binding files.
>
>>> +
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + clocks:
>>> + type: object
>>> + additionalProperties: true
>>
>> No, this cannot be "true".
>
> Agreed, I dropped that structure and kept strict schema validation.
So open v5 and tell me how did you solve "this cannot be 'true'", part?
Best regards,
Krzysztof
^ permalink raw reply
* [PATCH v1] rtc: m41t80: clean up watchdog on probe failure
From: Yuho Choi @ 2026-06-01 19:46 UTC (permalink / raw)
To: Alexandre Belloni; +Cc: linux-rtc, linux-kernel, Yuho Choi
m41t80_probe() registers the watchdog misc device and reboot notifier
before registering the RTC device. If RTC device registration fails,
probe returns without calling m41t80_remove(), leaving the watchdog misc
device and reboot notifier registered.
Both watchdog paths use the global save_client pointer, which can
outlive the failed probe and point at driver state that has been
released by devres.
Unregister the watchdog misc device and reboot notifier before returning
from the RTC registration failure path.
Fixes: 10d0c768cc6d ("rtc: m41t80: fix race conditions")
Signed-off-by: Yuho Choi <dbgh9129@gmail.com>
---
drivers/rtc/rtc-m41t80.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c
index b26afef37d9c..f4a30320c6ed 100644
--- a/drivers/rtc/rtc-m41t80.c
+++ b/drivers/rtc/rtc-m41t80.c
@@ -1009,9 +1009,17 @@ static int m41t80_probe(struct i2c_client *client)
rc = devm_rtc_register_device(m41t80_data->rtc);
if (rc)
- return rc;
+ goto err_wdt;
return 0;
+err_wdt:
+#ifdef CONFIG_RTC_DRV_M41T80_WDT
+ if (m41t80_data->features & M41T80_FEATURE_HT) {
+ misc_deregister(&wdt_dev);
+ unregister_reboot_notifier(&wdt_notifier);
+ }
+#endif
+ return rc;
}
static void m41t80_remove(struct i2c_client *client)
--
2.43.0
^ permalink raw reply related
* [PATCH] rtc: pcf8563: fix clock provider leak on unbind
From: Yi Ding @ 2026-06-02 3:51 UTC (permalink / raw)
To: Alexandre Belloni; +Cc: Heiko Schocher, linux-rtc, linux-kernel, Yi Ding
pcf8563_clkout_register_clk() registers the CLKOUT clock provider with
of_clk_add_provider(), but nothing ever unwinds it: there is no
of_clk_del_provider() call and the driver has no remove callback. Each
of_clk_add_provider() allocates a struct of_clk_provider, takes a
reference on the OF node and adds an entry to the global of_clk_providers
list, none of which is released when the device is unbound. Every
bind/unbind (or module reload) therefore leaks a provider structure and
an of_node reference.
The clock itself is already device-managed (devm_clk_register()); only
the provider registration was not. Use devm_of_clk_add_hw_provider() so
the provider is removed automatically on unbind. Tie it to the parent
i2c device, whose OF node carries the #clock-cells and clock-output-names
properties (the RTC class device has no OF node of its own).
Fixes: a39a6405d5f9 ("rtc: pcf8563: add CLKOUT to common clock framework")
Assisted-by: Claude:claude-opus-4-8
Signed-off-by: Yi Ding <yi.s.ding@gmail.com>
---
drivers/rtc/rtc-pcf8563.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-pcf8563.c b/drivers/rtc/rtc-pcf8563.c
index b281e9489..7083d9278 100644
--- a/drivers/rtc/rtc-pcf8563.c
+++ b/drivers/rtc/rtc-pcf8563.c
@@ -449,7 +449,9 @@ static struct clk *pcf8563_clkout_register_clk(struct pcf8563 *pcf8563)
clk = devm_clk_register(&pcf8563->rtc->dev, &pcf8563->clkout_hw);
if (!IS_ERR(clk))
- of_clk_add_provider(node, of_clk_src_simple_get, clk);
+ devm_of_clk_add_hw_provider(pcf8563->rtc->dev.parent,
+ of_clk_hw_simple_get,
+ &pcf8563->clkout_hw);
return clk;
}
--
2.47.3
^ permalink raw reply related
* [PATCH] rtc: mpc5121: replace in_8/out_8 with generic accessors
From: Rosen Penev @ 2026-06-02 4:00 UTC (permalink / raw)
To: linux-rtc; +Cc: Alexandre Belloni, chleroy, open list
Convert ppc4xx-specific in_8/out_8, in_be16/out_be16 and in_be32/
out_be32 to the portable ioread8/iowrite8, ioread16be/iowrite16be
and ioread32be/iowrite32be respectively.
Add COMPILE_TEST as a result for greater compile coverage.
Assisted-by: opencode:big-pickle
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/rtc/Kconfig | 2 +-
drivers/rtc/rtc-mpc5121.c | 80 +++++++++++++++++++--------------------
2 files changed, 41 insertions(+), 41 deletions(-)
diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index 364afc73f8ab..6d8935250c82 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -1779,7 +1779,7 @@ config RTC_DRV_MC13XXX
config RTC_DRV_MPC5121
tristate "Freescale MPC5121 built-in RTC"
- depends on PPC_MPC512x || PPC_MPC52xx
+ depends on PPC_MPC512x || PPC_MPC52xx || COMPILE_TEST
help
If you say yes here you will get support for the
built-in RTC on MPC5121 or on MPC5200.
diff --git a/drivers/rtc/rtc-mpc5121.c b/drivers/rtc/rtc-mpc5121.c
index b90f8337a7e6..c038301fb86b 100644
--- a/drivers/rtc/rtc-mpc5121.c
+++ b/drivers/rtc/rtc-mpc5121.c
@@ -87,15 +87,15 @@ struct mpc5121_rtc_data {
static void mpc5121_rtc_update_smh(struct mpc5121_rtc_regs __iomem *regs,
struct rtc_time *tm)
{
- out_8(®s->second_set, tm->tm_sec);
- out_8(®s->minute_set, tm->tm_min);
- out_8(®s->hour_set, tm->tm_hour);
+ iowrite8(tm->tm_sec, ®s->second_set);
+ iowrite8(tm->tm_min, ®s->minute_set);
+ iowrite8(tm->tm_hour, ®s->hour_set);
/* set time sequence */
- out_8(®s->set_time, 0x1);
- out_8(®s->set_time, 0x3);
- out_8(®s->set_time, 0x1);
- out_8(®s->set_time, 0x0);
+ iowrite8(0x1, ®s->set_time);
+ iowrite8(0x3, ®s->set_time);
+ iowrite8(0x1, ®s->set_time);
+ iowrite8(0x0, ®s->set_time);
}
static int mpc5121_rtc_read_time(struct device *dev, struct rtc_time *tm)
@@ -107,7 +107,7 @@ static int mpc5121_rtc_read_time(struct device *dev, struct rtc_time *tm)
/*
* linux time is actual_time plus the offset saved in target_time
*/
- now = in_be32(®s->actual_time) + in_be32(®s->target_time);
+ now = ioread32be(®s->actual_time) + ioread32be(®s->target_time);
rtc_time64_to_tm(now, tm);
@@ -131,7 +131,7 @@ static int mpc5121_rtc_set_time(struct device *dev, struct rtc_time *tm)
* between it and linux time to the target_time register.
*/
now = rtc_tm_to_time64(tm);
- out_be32(®s->target_time, now - in_be32(®s->actual_time));
+ iowrite32be(now - ioread32be(®s->actual_time), ®s->target_time);
/*
* update second minute hour registers
@@ -148,20 +148,20 @@ static int mpc5200_rtc_read_time(struct device *dev, struct rtc_time *tm)
struct mpc5121_rtc_regs __iomem *regs = rtc->regs;
int tmp;
- tm->tm_sec = in_8(®s->second);
- tm->tm_min = in_8(®s->minute);
+ tm->tm_sec = ioread8(®s->second);
+ tm->tm_min = ioread8(®s->minute);
/* 12 hour format? */
- if (in_8(®s->hour) & 0x20)
- tm->tm_hour = (in_8(®s->hour) >> 1) +
- (in_8(®s->hour) & 1 ? 12 : 0);
+ if (ioread8(®s->hour) & 0x20)
+ tm->tm_hour = (ioread8(®s->hour) >> 1) +
+ (ioread8(®s->hour) & 1 ? 12 : 0);
else
- tm->tm_hour = in_8(®s->hour);
+ tm->tm_hour = ioread8(®s->hour);
- tmp = in_8(®s->wday_mday);
+ tmp = ioread8(®s->wday_mday);
tm->tm_mday = tmp & 0x1f;
- tm->tm_mon = in_8(®s->month) - 1;
- tm->tm_year = in_be16(®s->year) - 1900;
+ tm->tm_mon = ioread8(®s->month) - 1;
+ tm->tm_year = ioread16be(®s->year) - 1900;
tm->tm_wday = (tmp >> 5) % 7;
tm->tm_yday = rtc_year_days(tm->tm_mday, tm->tm_mon, tm->tm_year);
tm->tm_isdst = 0;
@@ -177,16 +177,16 @@ static int mpc5200_rtc_set_time(struct device *dev, struct rtc_time *tm)
mpc5121_rtc_update_smh(regs, tm);
/* date */
- out_8(®s->month_set, tm->tm_mon + 1);
- out_8(®s->weekday_set, tm->tm_wday ? tm->tm_wday : 7);
- out_8(®s->date_set, tm->tm_mday);
- out_be16(®s->year_set, tm->tm_year + 1900);
+ iowrite8(tm->tm_mon + 1, ®s->month_set);
+ iowrite8(tm->tm_wday ? tm->tm_wday : 7, ®s->weekday_set);
+ iowrite8(tm->tm_mday, ®s->date_set);
+ iowrite16be(tm->tm_year + 1900, ®s->year_set);
/* set date sequence */
- out_8(®s->set_date, 0x1);
- out_8(®s->set_date, 0x3);
- out_8(®s->set_date, 0x1);
- out_8(®s->set_date, 0x0);
+ iowrite8(0x1, ®s->set_date);
+ iowrite8(0x3, ®s->set_date);
+ iowrite8(0x1, ®s->set_date);
+ iowrite8(0x0, ®s->set_date);
return 0;
}
@@ -198,7 +198,7 @@ static int mpc5121_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alarm)
*alarm = rtc->wkalarm;
- alarm->pending = in_8(®s->alm_status);
+ alarm->pending = ioread8(®s->alm_status);
return 0;
}
@@ -212,10 +212,10 @@ static int mpc5121_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alarm)
alarm->time.tm_mon = -1;
alarm->time.tm_year = -1;
- out_8(®s->alm_min_set, alarm->time.tm_min);
- out_8(®s->alm_hour_set, alarm->time.tm_hour);
+ iowrite8(alarm->time.tm_min, ®s->alm_min_set);
+ iowrite8(alarm->time.tm_hour, ®s->alm_hour_set);
- out_8(®s->alm_enable, alarm->enabled);
+ iowrite8(alarm->enabled, ®s->alm_enable);
rtc->wkalarm = *alarm;
return 0;
@@ -226,10 +226,10 @@ static irqreturn_t mpc5121_rtc_handler(int irq, void *dev)
struct mpc5121_rtc_data *rtc = dev_get_drvdata((struct device *)dev);
struct mpc5121_rtc_regs __iomem *regs = rtc->regs;
- if (in_8(®s->int_alm)) {
+ if (ioread8(®s->int_alm)) {
/* acknowledge and clear status */
- out_8(®s->int_alm, 1);
- out_8(®s->alm_status, 1);
+ iowrite8(1, ®s->int_alm);
+ iowrite8(1, ®s->alm_status);
rtc_update_irq(rtc->rtc, 1, RTC_IRQF | RTC_AF);
return IRQ_HANDLED;
@@ -243,9 +243,9 @@ static irqreturn_t mpc5121_rtc_handler_upd(int irq, void *dev)
struct mpc5121_rtc_data *rtc = dev_get_drvdata((struct device *)dev);
struct mpc5121_rtc_regs __iomem *regs = rtc->regs;
- if (in_8(®s->int_sec) && (in_8(®s->int_enable) & 0x1)) {
+ if (ioread8(®s->int_sec) && (ioread8(®s->int_enable) & 0x1)) {
/* acknowledge */
- out_8(®s->int_sec, 1);
+ iowrite8(1, ®s->int_sec);
rtc_update_irq(rtc->rtc, 1, RTC_IRQF | RTC_UF);
return IRQ_HANDLED;
@@ -266,7 +266,7 @@ static int mpc5121_rtc_alarm_irq_enable(struct device *dev,
else
val = 0;
- out_8(®s->alm_enable, val);
+ iowrite8(val, ®s->alm_enable);
rtc->wkalarm.enabled = val;
return 0;
@@ -340,11 +340,11 @@ static int mpc5121_rtc_probe(struct platform_device *op)
if (of_device_is_compatible(op->dev.of_node, "fsl,mpc5121-rtc")) {
u32 ka;
- ka = in_be32(&rtc->regs->keep_alive);
+ ka = ioread32be(&rtc->regs->keep_alive);
if (ka & 0x02) {
dev_warn(&op->dev,
"mpc5121-rtc: Battery or oscillator failure!\n");
- out_be32(&rtc->regs->keep_alive, ka);
+ iowrite32be(ka, &rtc->regs->keep_alive);
}
rtc->rtc->ops = &mpc5121_rtc_ops;
/*
@@ -376,8 +376,8 @@ static void mpc5121_rtc_remove(struct platform_device *op)
struct mpc5121_rtc_regs __iomem *regs = rtc->regs;
/* disable interrupt, so there are no nasty surprises */
- out_8(®s->alm_enable, 0);
- out_8(®s->int_enable, in_8(®s->int_enable) & ~0x1);
+ iowrite8(0, ®s->alm_enable);
+ iowrite8(ioread8(®s->int_enable) & ~0x1, ®s->int_enable);
irq_dispose_mapping(rtc->irq);
irq_dispose_mapping(rtc->irq_periodic);
--
2.54.0
^ permalink raw reply related
* Re: [PATCH 1/5] rtc: renesas-rtca3: Fix PIE clear polling condition in alarm setup error path
From: Claudiu Beznea @ 2026-06-02 8:31 UTC (permalink / raw)
To: Prabhakar, Alexandre Belloni, Claudiu Beznea, Geert Uytterhoeven
Cc: linux-rtc, linux-renesas-soc, linux-kernel, Biju Das,
Fabrizio Castro, Lad Prabhakar
In-Reply-To: <20260506164914.3987293-2-prabhakar.mahadev-lad.rj@bp.renesas.com>
Hi, Prabhakar,
On 5/6/26 19:49, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> In rtca3_set_alarm(), the setup_failed path attempts to disable the
> Periodic Interrupt Enable (PIE) bit and wait until it is cleared.
> However, the polling condition passed to readb_poll_timeout_atomic()
> uses an incorrect expression:
>
> !(tmp & ~RTCA3_RCR1_PIE)
>
> As ~RTCA3_RCR1_PIE evaluates to a mask of all bits except PIE, the
> condition effectively waits for all non-PIE bits to become zero, which
> is unrelated to the intended operation and is unlikely to ever be true.
> This causes the poll to time out unnecessarily.
>
> Fix the condition to check for the PIE bit itself being cleared:
>
> !(tmp & RTCA3_RCR1_PIE)
>
> This correctly waits until PIE is deasserted after being cleared.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Tested-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> # on RZ/G3S
I think it also deserves a Fixes tag?
Thank you,
Claudiu
^ permalink raw reply
* Re: [PATCH 2/5] rtc: renesas-rtca3: Check RADJ poll result during initial setup
From: Claudiu Beznea @ 2026-06-02 8:32 UTC (permalink / raw)
To: Prabhakar, Alexandre Belloni, Claudiu Beznea, Geert Uytterhoeven
Cc: linux-rtc, linux-renesas-soc, linux-kernel, Biju Das,
Fabrizio Castro, Lad Prabhakar
In-Reply-To: <20260506164914.3987293-3-prabhakar.mahadev-lad.rj@bp.renesas.com>
On 5/6/26 19:49, Prabhakar wrote:
> From: Lad Prabhakar<prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> In rtca3_initial_setup(), the driver clears the RTCA3_RADJ register and
> waits for it to reach zero using readb_poll_timeout(). Check the return
> value of readb_poll_timeout() and propagate the error if the poll fails.
>
> Signed-off-by: Lad Prabhakar<prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Tested-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> # on RZ/G3S
^ permalink raw reply
* Re: [PATCH 3/5] rtc: renesas-rtca3: Fix incorrect error message for reset assert
From: Claudiu Beznea @ 2026-06-02 8:32 UTC (permalink / raw)
To: Prabhakar, Alexandre Belloni, Claudiu Beznea, Geert Uytterhoeven
Cc: linux-rtc, linux-renesas-soc, linux-kernel, Biju Das,
Fabrizio Castro, Lad Prabhakar
In-Reply-To: <20260506164914.3987293-4-prabhakar.mahadev-lad.rj@bp.renesas.com>
On 5/6/26 19:49, Prabhakar wrote:
> From: Lad Prabhakar<prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Update the message to "assert reset" to accurately reflect the
> operation being performed.
>
> Signed-off-by: Lad Prabhakar<prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Tested-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> # on RZ/G3S
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox