From: Tony Krowiak <akrowiak@linux.vnet.ibm.com>
To: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org
Cc: freude@de.ibm.com, schwidefsky@de.ibm.com,
heiko.carstens@de.ibm.com, borntraeger@de.ibm.com,
cohuck@redhat.com, kwankhede@nvidia.com,
bjsdjshi@linux.vnet.ibm.com, pbonzini@redhat.com,
alex.williamson@redhat.com, pmorel@linux.vnet.ibm.com,
alifm@linux.vnet.ibm.com, mjrosato@linux.vnet.ibm.com,
jjherne@linux.vnet.ibm.com, thuth@redhat.com,
pasic@linux.vnet.ibm.com, berrange@redhat.com,
fiuczy@linux.vnet.ibm.com, buendgen@de.ibm.com,
akrowiak@linux.vnet.ibm.com
Subject: [PATCH v5 00/13] s390: vfio-ap: guest dedicated crypto adapters
Date: Mon, 7 May 2018 11:11:39 -0400 [thread overview]
Message-ID: <1525705912-12815-1-git-send-email-akrowiak@linux.vnet.ibm.com> (raw)
On s390, we have cryptographic coprocessor cards, which are modeled on
Linux as devices on the AP bus. Each card can be partitioned into domains
which can be thought of as a set of hardware registers for processing
crypto commands. Crypto commands are sent to a specific domain within a
card is via a queue which is identified as a (card,domain) tuple. We model
this something like the following (assuming we have access to cards 3 and
4 and domains 1 and 2):
AP -> card3 -> queue (3,1)
-> queue (3,2)
-> card4 -> queue (4,1)
-> queue (4,2)
If we want to virtualize this, we can use a feature provided by the
hardware. We basically attach a satellite control block to our main
hardware virtualization control block and the hardware takes care of
most of the rest.
For this control block, we don't specify explicit tuples, but a list of
cards and a list of domains. The guest will get access to the cross
product.
Because of this, we need to take care that the lists provided to
different guests don't overlap; i.e., we need to enforce sane
configurations. Otherwise, one guest may get access to things like
secret keys for another guest.
The idea of this patch set is to introduce a new device, the matrix
device. This matrix device hangs off a different root and acts as the
parent node for mdev devices.
If you now want to give the tuples (4,1) and (4,2), you need to do the
following:
- Unbind the (4,1) and (4,2) tuples from their ap bus driver.
- Bind the (4,1) and (4,2) tuples to the vfio_ap driver.
- Create the mediated device.
- Assign card 4 and domains 1 and 2 to the mediated device
QEMU will now simply consume the mediated device and things should work.
For a complete description of the architecture and concepts underlying the
design, see the Documentation/s390/vfio-ap.txt file included with this
patch set.
v4 => v5 Change log:
===================
* Added code to mdev open callback to ensure not more than one vfio-ap
device can be opened by a guest.
* Interpret AP instructions by default
* Removed patch implementing interface to enable/disable AP interpretation,
since that will now be done by default
* Removed patch to reset crypto attributes for ALL vcpus. That will be
submitted as a single patch since it will not be needed in this series -
i.e., it was called from the interface to enable/disable AP instructions
* All code for initializing crypto for a guest has been moved back to
kvm-s390.c, kvm_s390_crypto_init(kvm) function
* Maintaining a module reference count for the vfio_ap module so it is not
removed while a guest with AP devices is running.
* AP bus interfaces needed by KVM that are unavailable if CONFIG_ZCRYPT=n
are temporarily embedded in KVM until available statically via future
patch.
Tony Krowiak (13):
KVM: s390: Interface to test whether APXA installed
KVM: s390: refactor crypto initialization
KVM: s390: CPU model support for AP virtualization
s390: vfio-ap: base implementation of VFIO AP device driver
s390: vfio-ap: register matrix device with VFIO mdev framework
KVM: s390: interfaces to manage guest's AP matrix
s390: vfio-ap: sysfs interfaces to configure adapters
s390: vfio-ap: sysfs interfaces to configure domains
s390: vfio-ap: sysfs interfaces to configure control domains
s390: vfio-ap: sysfs interface to view matrix mdev matrix
KVM: s390: implement mediated device open callback
s390: vfio-ap: implement VFIO_DEVICE_GET_INFO ioctl
s390: doc: detailed specifications for AP virtualization
Documentation/s390/vfio-ap.txt | 575 +++++++++++++++++++++
MAINTAINERS | 13 +
arch/s390/Kconfig | 11 +
arch/s390/include/asm/kvm-ap.h | 133 +++++
arch/s390/include/asm/kvm_host.h | 5 +
arch/s390/include/uapi/asm/kvm.h | 1 +
arch/s390/kvm/Makefile | 2 +-
arch/s390/kvm/kvm-ap.c | 263 ++++++++++
arch/s390/kvm/kvm-s390.c | 116 +++---
arch/s390/tools/gen_facilities.c | 3 +
drivers/s390/crypto/Makefile | 4 +
drivers/s390/crypto/vfio_ap_drv.c | 143 ++++++
drivers/s390/crypto/vfio_ap_ops.c | 906 +++++++++++++++++++++++++++++++++
drivers/s390/crypto/vfio_ap_private.h | 76 +++
include/uapi/linux/vfio.h | 2 +
15 files changed, 2194 insertions(+), 59 deletions(-)
create mode 100644 Documentation/s390/vfio-ap.txt
create mode 100644 arch/s390/include/asm/kvm-ap.h
create mode 100644 arch/s390/kvm/kvm-ap.c
create mode 100644 drivers/s390/crypto/vfio_ap_drv.c
create mode 100644 drivers/s390/crypto/vfio_ap_ops.c
create mode 100644 drivers/s390/crypto/vfio_ap_private.h
next reply other threads:[~2018-05-07 15:11 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-07 15:11 Tony Krowiak [this message]
2018-05-07 15:11 ` [PATCH v5 01/13] KVM: s390: Interface to test whether APXA installed Tony Krowiak
2018-05-16 10:21 ` Cornelia Huck
2018-05-16 10:45 ` Tony Krowiak
2018-05-17 9:11 ` Harald Freudenberger
2018-05-17 9:44 ` Cornelia Huck
2018-05-07 15:11 ` [PATCH v5 02/13] KVM: s390: refactor crypto initialization Tony Krowiak
2018-05-16 8:51 ` Pierre Morel
2018-05-16 11:14 ` Tony Krowiak
2018-05-16 12:17 ` Pierre Morel
2018-05-16 12:21 ` Cornelia Huck
2018-05-07 15:11 ` [PATCH v5 03/13] KVM: s390: CPU model support for AP virtualization Tony Krowiak
2018-05-07 15:11 ` [PATCH v5 04/13] s390: vfio-ap: base implementation of VFIO AP device driver Tony Krowiak
2018-05-16 8:21 ` Pierre Morel
2018-05-16 11:29 ` Tony Krowiak
2018-05-16 11:45 ` Tony Krowiak
2018-06-07 8:57 ` Pierre Morel
2018-06-13 7:41 ` Pierre Morel
2018-06-13 7:48 ` Cornelia Huck
2018-06-13 10:54 ` Pierre Morel
2018-06-13 11:14 ` Cornelia Huck
2018-06-13 12:01 ` Pierre Morel
2018-06-13 12:12 ` Cornelia Huck
2018-06-13 12:16 ` Pierre Morel
2018-06-14 13:04 ` Tony Krowiak
2018-05-07 15:11 ` [PATCH v5 05/13] s390: vfio-ap: register matrix device with VFIO mdev framework Tony Krowiak
2018-05-11 17:18 ` Halil Pasic
2018-05-14 19:42 ` Tony Krowiak
2018-05-15 14:17 ` Pierre Morel
2018-05-15 15:16 ` Tony Krowiak
2018-05-15 15:48 ` Halil Pasic
2018-05-15 16:11 ` Tony Krowiak
2018-05-17 7:44 ` Cornelia Huck
2018-05-21 15:13 ` Tony Krowiak
2018-05-22 8:19 ` Cornelia Huck
2018-05-22 21:41 ` Tony Krowiak
2018-05-16 10:42 ` Cornelia Huck
2018-05-16 12:48 ` Tony Krowiak
2018-05-16 12:58 ` Tony Krowiak
2018-05-07 15:11 ` [PATCH v5 06/13] KVM: s390: interfaces to manage guest's AP matrix Tony Krowiak
2018-05-11 16:08 ` Halil Pasic
2018-05-16 14:29 ` Tony Krowiak
2018-05-16 14:41 ` Pierre Morel
2018-05-21 15:23 ` Tony Krowiak
2018-05-15 14:55 ` Pierre Morel
2018-05-15 16:07 ` Tony Krowiak
2018-05-16 7:48 ` Pierre Morel
2018-05-16 13:12 ` Tony Krowiak
2018-05-16 13:15 ` Pierre Morel
2018-05-16 13:48 ` Tony Krowiak
2018-05-18 8:55 ` Pierre Morel
2018-05-23 14:29 ` Tony Krowiak
2018-05-24 7:46 ` Pierre Morel
2018-05-07 15:11 ` [PATCH v5 07/13] s390: vfio-ap: sysfs interfaces to configure adapters Tony Krowiak
2018-05-07 15:11 ` [PATCH v5 08/13] s390: vfio-ap: sysfs interfaces to configure domains Tony Krowiak
2018-05-07 15:11 ` [PATCH v5 09/13] s390: vfio-ap: sysfs interfaces to configure control domains Tony Krowiak
2018-05-07 15:11 ` [PATCH v5 10/13] s390: vfio-ap: sysfs interface to view matrix mdev matrix Tony Krowiak
2018-05-16 7:55 ` Pierre Morel
2018-05-23 14:38 ` Tony Krowiak
2018-05-24 9:10 ` Pierre Morel
2018-05-30 14:28 ` Tony Krowiak
2018-06-05 12:40 ` Pierre Morel
2018-06-06 14:24 ` Tony Krowiak
2018-06-06 15:10 ` Pierre Morel
2018-06-07 12:53 ` Tony Krowiak
2018-06-07 13:16 ` Halil Pasic
2018-06-07 14:33 ` Tony Krowiak
2018-05-07 15:11 ` [PATCH v5 11/13] KVM: s390: implement mediated device open callback Tony Krowiak
2018-05-16 8:03 ` Pierre Morel
2018-05-23 14:45 ` Tony Krowiak
2018-05-24 9:08 ` Pierre Morel
2018-05-30 14:33 ` Tony Krowiak
2018-06-05 12:19 ` Pierre Morel
2018-06-06 14:28 ` Tony Krowiak
2018-06-06 16:08 ` Pierre Morel
2018-06-06 17:40 ` Pierre Morel
2018-06-07 13:54 ` Tony Krowiak
2018-06-07 15:20 ` Pierre Morel
2018-06-07 16:30 ` Tony Krowiak
2018-06-07 17:15 ` Pierre Morel
2018-06-08 21:59 ` Tony Krowiak
2018-06-11 9:23 ` Pierre Morel
2018-06-11 11:32 ` Halil Pasic
2018-06-11 11:49 ` Janosch Frank
2018-06-11 16:26 ` Tony Krowiak
2018-06-11 16:50 ` Halil Pasic
2018-06-11 16:54 ` Tony Krowiak
2018-06-11 12:50 ` Tony Krowiak
2018-06-11 12:56 ` Tony Krowiak
2018-06-07 13:52 ` Tony Krowiak
2018-05-07 15:11 ` [PATCH v5 12/13] s390: vfio-ap: implement VFIO_DEVICE_GET_INFO ioctl Tony Krowiak
2018-05-07 15:11 ` [PATCH v5 13/13] s390: doc: detailed specifications for AP virtualization Tony Krowiak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1525705912-12815-1-git-send-email-akrowiak@linux.vnet.ibm.com \
--to=akrowiak@linux.vnet.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=alifm@linux.vnet.ibm.com \
--cc=berrange@redhat.com \
--cc=bjsdjshi@linux.vnet.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=buendgen@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=fiuczy@linux.vnet.ibm.com \
--cc=freude@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=jjherne@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mjrosato@linux.vnet.ibm.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=pmorel@linux.vnet.ibm.com \
--cc=schwidefsky@de.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox