* [PATCH] arch/s390/kernel/ipl.c: correct error detection check
@ 2011-08-22 11:46 Julia Lawall
2011-08-22 12:27 ` Heiko Carstens
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2011-08-22 11:46 UTC (permalink / raw)
To: Martin Schwidefsky
Cc: kernel-janitors, Heiko Carstens, linux390, Michael Holzheu,
linux-s390, linux-kernel, sumsaha
From: Julia Lawall <julia@diku.dk>
reipl_fcp_kset was just initialized, so it appears that it should be tested
instead of reipl_kset.
Signed-off-by: Julia Lawall <julia@diku.dk>
Reported-by: Suman Saha <sumsaha@gmail.com>
---
arch/s390/kernel/ipl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/s390/kernel/ipl.c b/arch/s390/kernel/ipl.c
index 04361d5..ee28e06 100644
--- a/arch/s390/kernel/ipl.c
+++ b/arch/s390/kernel/ipl.c
@@ -1220,7 +1220,7 @@ static int __init reipl_fcp_init(void)
/* sysfs: create fcp kset for mixing attr group and bin attrs */
reipl_fcp_kset = kset_create_and_add(IPL_FCP_STR, NULL,
&reipl_kset->kobj);
- if (!reipl_kset) {
+ if (!reipl_fcp_kset) {
free_page((unsigned long) reipl_block_fcp);
return -ENOMEM;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] arch/s390/kernel/ipl.c: correct error detection check
2011-08-22 11:46 [PATCH] arch/s390/kernel/ipl.c: correct error detection check Julia Lawall
@ 2011-08-22 12:27 ` Heiko Carstens
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Carstens @ 2011-08-22 12:27 UTC (permalink / raw)
To: Julia Lawall
Cc: Martin Schwidefsky, kernel-janitors, linux390, Michael Holzheu,
linux-s390, linux-kernel, sumsaha
On Mon, Aug 22, 2011 at 01:46:34PM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> reipl_fcp_kset was just initialized, so it appears that it should be tested
> instead of reipl_kset.
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
> Reported-by: Suman Saha <sumsaha@gmail.com>
Applied. Thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-22 12:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-22 11:46 [PATCH] arch/s390/kernel/ipl.c: correct error detection check Julia Lawall
2011-08-22 12:27 ` Heiko Carstens
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox