[PATCH] s390/ptrace: add missing linux/const.h include

[PATCH] s390/ptrace: add missing linux/const.h include

[Heiko Carstens]

Adrian Reber reported the following CRIU build bug after
commit b8af5999779d ("s390/ptrace: make all psw related
defines also available for asm"):

compel/arch/s390/src/lib/infect.c: In function 'arch_can_dump_task':
compel/arch/s390/src/lib/infect.c:523:25: error: 'UL' undeclared (first use in this function)
  523 |         if (psw->mask & PSW_MASK_RI) {
      |                         ^~~~~~~~~~~

Add the missing linux/const.h include to fix this.

Reported-by: Adrian Reber <areber@redhat.com>
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2225745
Link: https://github.com/checkpoint-restore/criu/pull/2232
Fixes: b8af5999779d ("s390/ptrace: make all psw related defines also available for asm")
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
---
 arch/s390/include/uapi/asm/ptrace.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/s390/include/uapi/asm/ptrace.h b/arch/s390/include/uapi/asm/ptrace.h
index f0fe3bcc78a8..bb0826024bb9 100644
--- a/arch/s390/include/uapi/asm/ptrace.h
+++ b/arch/s390/include/uapi/asm/ptrace.h
@@ -8,6 +8,8 @@
 #ifndef _UAPI_S390_PTRACE_H
 #define _UAPI_S390_PTRACE_H
 
+#include <linux/const.h>
+
 /*
  * Offsets in the user_regs_struct. They are used for the ptrace
  * system call and in entry.S
-- 
2.39.2

Re: [PATCH] s390/ptrace: add missing linux/const.h include

[Adrian Reber]

On Mon, Jul 31, 2023 at 08:39:26PM +0200, Heiko Carstens wrote:
> Adrian Reber reported the following CRIU build bug after
> commit b8af5999779d ("s390/ptrace: make all psw related
> defines also available for asm"):
> 
> compel/arch/s390/src/lib/infect.c: In function 'arch_can_dump_task':
> compel/arch/s390/src/lib/infect.c:523:25: error: 'UL' undeclared (first use in this function)
>   523 |         if (psw->mask & PSW_MASK_RI) {
>       |                         ^~~~~~~~~~~
> 
> Add the missing linux/const.h include to fix this.

Thanks. That fixes the build failure for me.

		Adrian

> Reported-by: Adrian Reber <areber@redhat.com>
> Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2225745
> Link: https://github.com/checkpoint-restore/criu/pull/2232
> Fixes: b8af5999779d ("s390/ptrace: make all psw related defines also available for asm")
> Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
> ---
>  arch/s390/include/uapi/asm/ptrace.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/s390/include/uapi/asm/ptrace.h b/arch/s390/include/uapi/asm/ptrace.h
> index f0fe3bcc78a8..bb0826024bb9 100644
> --- a/arch/s390/include/uapi/asm/ptrace.h
> +++ b/arch/s390/include/uapi/asm/ptrace.h
> @@ -8,6 +8,8 @@
>  #ifndef _UAPI_S390_PTRACE_H
>  #define _UAPI_S390_PTRACE_H
>  
> +#include <linux/const.h>
> +
>  /*
>   * Offsets in the user_regs_struct. They are used for the ptrace
>   * system call and in entry.S
> -- 
> 2.39.2
> 

Re: [PATCH] s390/ptrace: add missing linux/const.h include

[Heiko Carstens]

On Tue, Aug 01, 2023 at 04:11:39PM +0200, Adrian Reber wrote:
> On Mon, Jul 31, 2023 at 08:39:26PM +0200, Heiko Carstens wrote:
> > Adrian Reber reported the following CRIU build bug after
> > commit b8af5999779d ("s390/ptrace: make all psw related
> > defines also available for asm"):
> > 
> > compel/arch/s390/src/lib/infect.c: In function 'arch_can_dump_task':
> > compel/arch/s390/src/lib/infect.c:523:25: error: 'UL' undeclared (first use in this function)
> >   523 |         if (psw->mask & PSW_MASK_RI) {
> >       |                         ^~~~~~~~~~~
> > 
> > Add the missing linux/const.h include to fix this.
> 
> Thanks. That fixes the build failure for me.

Thanks for verifying. This should make it into rc5.