* Re: [PATCH 1/1] s390: remove extra check of task_stack_page()
2026-04-28 10:56 ` [PATCH 1/1] s390: remove extra check of task_stack_page() Maninder Singh
@ 2026-04-28 12:54 ` Heiko Carstens
2026-04-28 13:31 ` Alexander Gordeev
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Carstens @ 2026-04-28 12:54 UTC (permalink / raw)
To: Maninder Singh
Cc: gor, agordeev, borntraeger, svens, linux-s390, linux-kernel
On Tue, Apr 28, 2026 at 04:26:07PM +0530, Maninder Singh wrote:
> There is no need to call task_stack_page(),
> because try_get_task_stack() already takes care of that.
>
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> ---
> arch/s390/kernel/process.c | 3 ---
> 1 file changed, 3 deletions(-)
Reviewed-by: Heiko Carstens <hca@linux.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] s390: remove extra check of task_stack_page()
2026-04-28 10:56 ` [PATCH 1/1] s390: remove extra check of task_stack_page() Maninder Singh
2026-04-28 12:54 ` Heiko Carstens
@ 2026-04-28 13:31 ` Alexander Gordeev
1 sibling, 0 replies; 3+ messages in thread
From: Alexander Gordeev @ 2026-04-28 13:31 UTC (permalink / raw)
To: Maninder Singh; +Cc: hca, gor, borntraeger, svens, linux-s390, linux-kernel
On Tue, Apr 28, 2026 at 04:26:07PM +0530, Maninder Singh wrote:
> There is no need to call task_stack_page(),
> because try_get_task_stack() already takes care of that.
>
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> ---
> arch/s390/kernel/process.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/s390/kernel/process.c b/arch/s390/kernel/process.c
> index 0df95dcb2101..dabd569dbba8 100644
> --- a/arch/s390/kernel/process.c
> +++ b/arch/s390/kernel/process.c
> @@ -203,9 +203,6 @@ unsigned long __get_wchan(struct task_struct *p)
> struct unwind_state state;
> unsigned long ip = 0;
>
> - if (!task_stack_page(p))
> - return 0;
> -
> if (!try_get_task_stack(p))
> return 0;
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread