Re: [PATCH v4 14/27] KVM: s390: Move s390 kvm code into a subdirectory

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The files `pci.c` and `pci.h` were moved from `arch/s390/kvm/` to the `s390/` subdirectory (`arch/s390/kvm/s390/`), but their specific entry in the `MAINTAINERS` file was not updated to reflect this change.
--

commit c2f3b449a0f094fa44a079aff2968b331a351e17
Author: Steffen Eiden <seiden@linux.ibm.com>

KVM: s390: Move s390 kvm code into a subdirectory
    
Move all the code required to run s390 KVM guests on s390 to a s390
subdirectory. Move gmap related code into a gmap directory to later
share gmap code between KVM implementations.
    
No functional change.

[ ... ]

> diff --git a/arch/s390/kvm/pci.c b/arch/s390/kvm/s390/pci.c
> similarity index 100%
> rename from arch/s390/kvm/pci.c
> rename to arch/s390/kvm/s390/pci.c

[Severity: Low]
Since these files are moving to the new s390/ subdirectory, should the
MAINTAINERS file also be updated?

The current maintainers entry tracks this path:
F:      arch/s390/kvm/pci*

Because the path has changed, the get_maintainer script might fail to include
the subsystem reviewers on future patches for these files. Is it worth
updating the pattern to arch/s390/kvm/s390/pci* in this commit?

> diff --git a/arch/s390/kvm/pci.h b/arch/s390/kvm/s390/pci.h
> similarity index 100%
> rename from arch/s390/kvm/pci.h
> rename to arch/s390/kvm/s390/pci.h

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260706085229.979525-1-seiden@linux.ibm.com?part=14