* [PATCH] s390/cio: use assign_bit() where applicable
@ 2026-09-19 13:08 Peng Fan (OSS)
2026-09-19 13:14 ` sashiko-bot
0 siblings, 1 reply; 2+ messages in thread
From: Peng Fan (OSS) @ 2026-09-19 13:08 UTC (permalink / raw)
To: Vineeth Vijayan, Peter Oberparleiter, Heiko Carstens,
Vasily Gorbik, Alexander Gordeev, Christian Borntraeger,
Sven Schnelle
Cc: linux-kernel, Peng Fan, linux-s390
From: Peng Fan <peng.fan@nxp.com>
Convert open-coded if/else with set_bit/clear_bit to the assign_bit API.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/s390/cio/blacklist.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/s390/cio/blacklist.c b/drivers/s390/cio/blacklist.c
index 020d210bde9f..c80c1f527bb1 100644
--- a/drivers/s390/cio/blacklist.c
+++ b/drivers/s390/cio/blacklist.c
@@ -60,10 +60,7 @@ static int blacklist_range(range_action action, unsigned int from_ssid,
while ((from_ssid < to_ssid) || ((from_ssid == to_ssid) &&
(from <= to))) {
- if (action == add)
- set_bit(from, bl_dev[from_ssid]);
- else
- clear_bit(from, bl_dev[from_ssid]);
+ assign_bit(from, bl_dev[from_ssid], action == add);
from++;
if (from > __MAX_SUBCHANNEL) {
from_ssid++;
--
2.51.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] s390/cio: use assign_bit() where applicable
2026-09-19 13:08 [PATCH] s390/cio: use assign_bit() where applicable Peng Fan (OSS)
@ 2026-09-19 13:14 ` sashiko-bot
0 siblings, 0 replies; 2+ messages in thread
From: sashiko-bot @ 2026-09-19 13:14 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: linux-s390, Vasily Gorbik, Heiko Carstens, Alexander Gordeev,
Christian Borntraeger
> From: Peng Fan <peng.fan@nxp.com>
>
> Convert open-coded if/else with set_bit/clear_bit to the assign_bit API.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260919130844.3041591-1-peng.fan@oss.nxp.com?part=1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-19 13:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-19 13:08 [PATCH] s390/cio: use assign_bit() where applicable Peng Fan (OSS)
2026-09-19 13:14 ` sashiko-bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox