Re: [PATCH v7 14/17] target/s390x: Support protected key AES XTS for cpacf km instruction

[Harald Freudenberger <freude@linux.ibm.com>]

On 2026-06-18 08:22, Finn Callies wrote:
> On 17.06.26 11:48, Harald Freudenberger wrote:
>> Support the subfunctions CPACF_KM_PXTS_128 and CPACF_KM_PAES_256
>> for the cpacf km instruction.
>> 
>> Signed-off-by: Harald Freudenberger <freude@linux.ibm.com>
>> Tested-by: Holger Dengler <dengler@linux.ibm.com>
> 
> With the suggestion:
> 
> Reviewed-by: Finn Callies <fcallies@linux.ibm.com>
> 
>> ---
>>   target/s390x/gen-features.c      |   2 +
>>   target/s390x/tcg/cpacf.h         |   4 ++
>>   target/s390x/tcg/cpacf_aes.c     | 106 
>> +++++++++++++++++++++++++++++++
>>   target/s390x/tcg/crypto_helper.c |   6 ++
>>   4 files changed, 118 insertions(+)
>> 
>> diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c
>> index 126bacb281..c4c59c3504 100644
>> --- a/target/s390x/gen-features.c
>> +++ b/target/s390x/gen-features.c
>> @@ -929,6 +929,8 @@ static uint16_t qemu_MAX[] = {
>>       S390_FEAT_KM_EAES_256,
>>       S390_FEAT_KM_XTS_AES_128,
>>       S390_FEAT_KM_XTS_AES_256,
>> +    S390_FEAT_KM_XTS_EAES_128,
>> +    S390_FEAT_KM_XTS_EAES_256,
> 
> PAES or ENCRYPTED_AES

Again - not within this patch series.

> 
>>       S390_FEAT_KMC_AES_128,
>>       S390_FEAT_KMC_AES_192,
>>       S390_FEAT_KMC_AES_256,
> 
> [ snip ]