Re: [PATCH v7 16/17] crypto: Add aes-helpers file to support some AES modes

[Harald Freudenberger <freude@linux.ibm.com>]

On 2026-06-18 08:31, Finn Callies wrote:
> On 17.06.26 11:48, Harald Freudenberger wrote:
>> Add a new file crypto/aes-helpers.c with simple functions
>> to support some AES modes:
>> - AES cbc: AES_cbc_encrypt() AES_cbc_decrypt()
>> - AES ctr: AES_ctr_encrypt()
>> - AES xts: AES_xts_encrypt() AES_xts_decrypt()
>> and some AES related helpers:
>> - AES_xor()
>> - AES_xts_prep_next_tweak()
>> 
>> Signed-off-by: Harald Freudenberger <freude@linux.ibm.com>
> 
> I like this, but why do you do this so late in the series instead of
> implementing it directly like that? Otherwise:
> 
> Reviewed-by: Finn Callies <fcallies@linux.ibm.com>

This was a suggestion by Holger. And I want to have this separate to
be able to remove this and the next patch without the need to rework
the implementation.

> 
>> ---
>>   crypto/aes-helpers.c | 101 
>> +++++++++++++++++++++++++++++++++++++++++++
>>   crypto/meson.build   |   1 +
>>   include/crypto/aes.h |  14 ++++++
>>   3 files changed, 116 insertions(+)
>>   create mode 100644 crypto/aes-helpers.c
> 
> [ snip ]