[PATCH net-next] net/smc: add the max value of fallback reason count

[PATCH net-next] net/smc: add the max value of fallback reason count

[Zhengchao Shao]

The number of fallback reasons defined in the smc_clc.h file has reached
36. For historical reasons, some are no longer quoted, and there's 33
actually in use. So, add the max value of fallback reason count to 50.

Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
---
 net/smc/smc_stats.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/smc/smc_stats.h b/net/smc/smc_stats.h
index 9d32058db2b5..ab5aafc6f44c 100644
--- a/net/smc/smc_stats.h
+++ b/net/smc/smc_stats.h
@@ -19,7 +19,7 @@
 
 #include "smc_clc.h"
 
-#define SMC_MAX_FBACK_RSN_CNT 30
+#define SMC_MAX_FBACK_RSN_CNT 50
 
 enum {
 	SMC_BUF_8K,
-- 
2.34.1

Re: [PATCH net-next] net/smc: add the max value of fallback reason count

[D. Wythe]

On 8/1/24 7:35 PM, Zhengchao Shao wrote:
> The number of fallback reasons defined in the smc_clc.h file has reached
> 36. For historical reasons, some are no longer quoted, and there's 33
> actually in use. So, add the max value of fallback reason count to 50.
>
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
> ---
>   net/smc/smc_stats.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/smc/smc_stats.h b/net/smc/smc_stats.h
> index 9d32058db2b5..ab5aafc6f44c 100644
> --- a/net/smc/smc_stats.h
> +++ b/net/smc/smc_stats.h
> @@ -19,7 +19,7 @@
>   
>   #include "smc_clc.h"
>   
> -#define SMC_MAX_FBACK_RSN_CNT 30
> +#define SMC_MAX_FBACK_RSN_CNT 50
>   
It feels more like a fix ？

>   enum {
>   	SMC_BUF_8K,

Re: [PATCH net-next] net/smc: add the max value of fallback reason count

[Wenjia Zhang]

On 02.08.24 04:38, D. Wythe wrote:
> 
> 
> On 8/1/24 7:35 PM, Zhengchao Shao wrote:
>> The number of fallback reasons defined in the smc_clc.h file has reached
>> 36. For historical reasons, some are no longer quoted, and there's 33
>> actually in use. So, add the max value of fallback reason count to 50.
>>
>> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
>> ---
>>   net/smc/smc_stats.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/smc/smc_stats.h b/net/smc/smc_stats.h
>> index 9d32058db2b5..ab5aafc6f44c 100644
>> --- a/net/smc/smc_stats.h
>> +++ b/net/smc/smc_stats.h
>> @@ -19,7 +19,7 @@
>>   #include "smc_clc.h"
>> -#define SMC_MAX_FBACK_RSN_CNT 30
>> +#define SMC_MAX_FBACK_RSN_CNT 50
> It feels more like a fix ？
> 
>>   enum {
>>       SMC_BUF_8K,
> 

Hi Zhengchao,

IMO It should be 36 instead of 50 because of unnecessary smc_stats_fback 
element and  unnecessary scanning e.g. in smc_stat_inc_fback_rsn_cnt(). 
If there is any new reason code coming later, the one who are 
introducing the new reason code should update the the value correspondingly.
Btw, I also it is a bug fix other than feature.

Thanks,
Wenjia

Re: [PATCH net-next] net/smc: add the max value of fallback reason count

[Wen Gu]

On 2024/8/2 19:17, Wenjia Zhang wrote:
> 
> 
> On 02.08.24 04:38, D. Wythe wrote:
>>
>>
>> On 8/1/24 7:35 PM, Zhengchao Shao wrote:
>>> The number of fallback reasons defined in the smc_clc.h file has reached
>>> 36. For historical reasons, some are no longer quoted, and there's 33
>>> actually in use. So, add the max value of fallback reason count to 50.
>>>
>>> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
>>> ---
>>>   net/smc/smc_stats.h | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/net/smc/smc_stats.h b/net/smc/smc_stats.h
>>> index 9d32058db2b5..ab5aafc6f44c 100644
>>> --- a/net/smc/smc_stats.h
>>> +++ b/net/smc/smc_stats.h
>>> @@ -19,7 +19,7 @@
>>>   #include "smc_clc.h"
>>> -#define SMC_MAX_FBACK_RSN_CNT 30
>>> +#define SMC_MAX_FBACK_RSN_CNT 50
>> It feels more like a fix ？
>>
>>>   enum {
>>>       SMC_BUF_8K,
>>
> 
> Hi Zhengchao,
> 
> IMO It should be 36 instead of 50 because of unnecessary smc_stats_fback element and  unnecessary scanning e.g. in smc_stat_inc_fback_rsn_cnt(). If there is any new reason code coming later, the one who are introducing the new reason code should update the the value correspondingly.

I wonder if it is really necessary to expand to 50, since generally
the reasons for fallback in a machine will be concentrated into a few,
normally less than 10, so there is almost no case of using up all 30
reason slots.

Thanks!

> Btw, I also it is a bug fix other than feature.
> 
> Thanks,
> Wenjia

Re: [PATCH net-next] net/smc: add the max value of fallback reason count

[shaozhengchao]

On 2024/8/2 22:05, Wen Gu wrote:
> 
> 
> On 2024/8/2 19:17, Wenjia Zhang wrote:
>>
>>
>> On 02.08.24 04:38, D. Wythe wrote:
>>>
>>>
>>> On 8/1/24 7:35 PM, Zhengchao Shao wrote:
>>>> The number of fallback reasons defined in the smc_clc.h file has 
>>>> reached
>>>> 36. For historical reasons, some are no longer quoted, and there's 33
>>>> actually in use. So, add the max value of fallback reason count to 50.
>>>>
>>>> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
>>>> ---
>>>>   net/smc/smc_stats.h | 2 +-
>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/net/smc/smc_stats.h b/net/smc/smc_stats.h
>>>> index 9d32058db2b5..ab5aafc6f44c 100644
>>>> --- a/net/smc/smc_stats.h
>>>> +++ b/net/smc/smc_stats.h
>>>> @@ -19,7 +19,7 @@
>>>>   #include "smc_clc.h"
>>>> -#define SMC_MAX_FBACK_RSN_CNT 30
>>>> +#define SMC_MAX_FBACK_RSN_CNT 50
>>> It feels more like a fix ？
>>>
>>>>   enum {
>>>>       SMC_BUF_8K,
>>>
>>
Hi Wen Gu:
     Thank you for you reply. As long as there are enough scenarios and
enough complexity, some unusual errors will be tested. :)

Thank you

Zhengchao Shao
>> Hi Zhengchao,
>>
>> IMO It should be 36 instead of 50 because of unnecessary 
>> smc_stats_fback element and  unnecessary scanning e.g. in 
>> smc_stat_inc_fback_rsn_cnt(). If there is any new reason code coming 
>> later, the one who are introducing the new reason code should update 
>> the the value correspondingly.
> 
> I wonder if it is really necessary to expand to 50, since generally
> the reasons for fallback in a machine will be concentrated into a few,
> normally less than 10, so there is almost no case of using up all 30
> reason slots.
> 
> Thanks!
> 
>> Btw, I also it is a bug fix other than feature.
>>
>> Thanks,
>> Wenjia

Re: [PATCH net-next] net/smc: add the max value of fallback reason count

[shaozhengchao]

Hi Wenjia:
     I will fix it in V2.

Thank you

Zhengchao Shao

On 2024/8/2 19:17, Wenjia Zhang wrote:
> 
> 
> On 02.08.24 04:38, D. Wythe wrote:
>>
>>
>> On 8/1/24 7:35 PM, Zhengchao Shao wrote:
>>> The number of fallback reasons defined in the smc_clc.h file has reached
>>> 36. For historical reasons, some are no longer quoted, and there's 33
>>> actually in use. So, add the max value of fallback reason count to 50.
>>>
>>> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
>>> ---
>>>   net/smc/smc_stats.h | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/net/smc/smc_stats.h b/net/smc/smc_stats.h
>>> index 9d32058db2b5..ab5aafc6f44c 100644
>>> --- a/net/smc/smc_stats.h
>>> +++ b/net/smc/smc_stats.h
>>> @@ -19,7 +19,7 @@
>>>   #include "smc_clc.h"
>>> -#define SMC_MAX_FBACK_RSN_CNT 30
>>> +#define SMC_MAX_FBACK_RSN_CNT 50
>> It feels more like a fix ？
>>
>>>   enum {
>>>       SMC_BUF_8K,
>>
> 
> Hi Zhengchao,
> 
> IMO It should be 36 instead of 50 because of unnecessary smc_stats_fback 
> element and  unnecessary scanning e.g. in smc_stat_inc_fback_rsn_cnt(). 
> If there is any new reason code coming later, the one who are 
> introducing the new reason code should update the the value 
> correspondingly.
> Btw, I also it is a bug fix other than feature.
> 
> Thanks,
> Wenjia