From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: Justin Sanders <justin@coraid.com>,
Josef Bacik <josef@toxicpanda.com>,
Xianting Tian <xianting_tian@126.com>,
linux-block@vger.kernel.org, dm-devel@redhat.com,
Stefan Haberland <sth@linux.ibm.com>,
Jan Hoeppner <hoeppner@linux.ibm.com>,
linux-kernel@vger.kernel.org, nbd@other.debian.org,
linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH 3/3] nvme: don't call revalidate_disk from nvme_set_queue_dying
Date: Mon, 24 Aug 2020 09:37:56 +0200 [thread overview]
Message-ID: <bec1889c-5e0f-cd33-f74a-a7d44161a0ee@suse.de> (raw)
In-Reply-To: <20200823091043.2600261-4-hch@lst.de>
On 8/23/20 11:10 AM, Christoph Hellwig wrote:
> In nvme_set_queue_dying we really just want to ensure the disk and bdev
> sizes are set to zero. Going through revalidate_disk leads to a somewhat
> arcance and complex callchain relying on special behavior in a few
> places. Instead just lift the set_capacity directly to
> nvme_set_queue_dying, and rename and move the nvme_mpath_update_disk_size
> helper so that we can use it in nvme_set_queue_dying to propagate the
> size to the bdev without detours.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/nvme/host/core.c | 33 +++++++++++++++++++++++----------
> drivers/nvme/host/nvme.h | 13 -------------
> 2 files changed, 23 insertions(+), 23 deletions(-)
>
YES!
I've been bitten by this far too often.
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
next prev parent reply other threads:[~2020-08-24 7:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-23 9:10 fix block device size update serialization v2 Christoph Hellwig
2020-08-23 9:10 ` [PATCH 1/3] block: replace bd_set_size with bd_set_nr_sectors Christoph Hellwig
2020-08-24 8:25 ` Sagi Grimberg
2020-08-23 9:10 ` [PATCH 2/3] block: fix locking for struct block_device size updates Christoph Hellwig
2020-08-24 7:36 ` Hannes Reinecke
2020-08-24 8:26 ` Sagi Grimberg
2020-08-23 9:10 ` [PATCH 3/3] nvme: don't call revalidate_disk from nvme_set_queue_dying Christoph Hellwig
2020-08-24 7:37 ` Hannes Reinecke [this message]
2020-08-24 8:26 ` Sagi Grimberg
2020-08-27 7:47 ` fix block device size update serialization v2 Christoph Hellwig
2020-08-29 16:47 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bec1889c-5e0f-cd33-f74a-a7d44161a0ee@suse.de \
--to=hare@suse.de \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=hoeppner@linux.ibm.com \
--cc=josef@toxicpanda.com \
--cc=justin@coraid.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=nbd@other.debian.org \
--cc=sth@linux.ibm.com \
--cc=xianting_tian@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox