* [PATCH] drm/exynos/fimc: fix runtime pm support
@ 2015-04-09 8:46 Marek Szyprowski
2015-07-12 16:24 ` Tobias Jakobi
2015-08-06 10:13 ` Marek Szyprowski
0 siblings, 2 replies; 4+ messages in thread
From: Marek Szyprowski @ 2015-04-09 8:46 UTC (permalink / raw)
To: linux-samsung-soc
Cc: dri-devel, Marek Szyprowski, Andrzej Hajda, Inki Dae, jy0922.shim
Once pm_runtime_set_active() gets called, the kernel assumes that given
device has already enabled runtime pm and will call pm_runtime_suspend()
without matching pm_runtime_resume(). In case of DRM FIMC IPP driver,
this will result in calling clk_disable() without respective call to
clk_enable(). This patch removes call to pm_runtime_set_active() to
ensure that pm_runtime_suspend/resume calls will match.
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c b/drivers/gpu/drm/exynos/exynos_drm_fimc.c
index 842d6b8dc3c4..2a652359af64 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fimc.c
@@ -1745,7 +1745,6 @@ static int fimc_probe(struct platform_device *pdev)
spin_lock_init(&ctx->lock);
platform_set_drvdata(pdev, ctx);
- pm_runtime_set_active(dev);
pm_runtime_enable(dev);
ret = exynos_drm_ippdrv_register(ippdrv);
--
1.9.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/exynos/fimc: fix runtime pm support
2015-04-09 8:46 [PATCH] drm/exynos/fimc: fix runtime pm support Marek Szyprowski
@ 2015-07-12 16:24 ` Tobias Jakobi
2015-08-06 10:13 ` Marek Szyprowski
1 sibling, 0 replies; 4+ messages in thread
From: Tobias Jakobi @ 2015-07-12 16:24 UTC (permalink / raw)
To: Marek Szyprowski, linux-samsung-soc; +Cc: Andrzej Hajda, dri-devel
Hello,
looks like this patch was forgotten. At least I can't find it in 4.2-rc1.
With best wishes,
Tobias
Marek Szyprowski wrote:
> Once pm_runtime_set_active() gets called, the kernel assumes that given
> device has already enabled runtime pm and will call pm_runtime_suspend()
> without matching pm_runtime_resume(). In case of DRM FIMC IPP driver,
> this will result in calling clk_disable() without respective call to
> clk_enable(). This patch removes call to pm_runtime_set_active() to
> ensure that pm_runtime_suspend/resume calls will match.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> drivers/gpu/drm/exynos/exynos_drm_fimc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c b/drivers/gpu/drm/exynos/exynos_drm_fimc.c
> index 842d6b8dc3c4..2a652359af64 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimc.c
> @@ -1745,7 +1745,6 @@ static int fimc_probe(struct platform_device *pdev)
> spin_lock_init(&ctx->lock);
> platform_set_drvdata(pdev, ctx);
>
> - pm_runtime_set_active(dev);
> pm_runtime_enable(dev);
>
> ret = exynos_drm_ippdrv_register(ippdrv);
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/exynos/fimc: fix runtime pm support
2015-04-09 8:46 [PATCH] drm/exynos/fimc: fix runtime pm support Marek Szyprowski
2015-07-12 16:24 ` Tobias Jakobi
@ 2015-08-06 10:13 ` Marek Szyprowski
2015-08-06 11:57 ` Inki Dae
1 sibling, 1 reply; 4+ messages in thread
From: Marek Szyprowski @ 2015-08-06 10:13 UTC (permalink / raw)
To: linux-samsung-soc; +Cc: dri-devel, Andrzej Hajda, Inki Dae, jy0922.shim
Hello,
On 2015-04-09 10:46, Marek Szyprowski wrote:
> Once pm_runtime_set_active() gets called, the kernel assumes that given
> device has already enabled runtime pm and will call pm_runtime_suspend()
> without matching pm_runtime_resume(). In case of DRM FIMC IPP driver,
> this will result in calling clk_disable() without respective call to
> clk_enable(). This patch removes call to pm_runtime_set_active() to
> ensure that pm_runtime_suspend/resume calls will match.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Gentle ping...
> ---
> drivers/gpu/drm/exynos/exynos_drm_fimc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c b/drivers/gpu/drm/exynos/exynos_drm_fimc.c
> index 842d6b8dc3c4..2a652359af64 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimc.c
> @@ -1745,7 +1745,6 @@ static int fimc_probe(struct platform_device *pdev)
> spin_lock_init(&ctx->lock);
> platform_set_drvdata(pdev, ctx);
>
> - pm_runtime_set_active(dev);
> pm_runtime_enable(dev);
>
> ret = exynos_drm_ippdrv_register(ippdrv);
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/exynos/fimc: fix runtime pm support
2015-08-06 10:13 ` Marek Szyprowski
@ 2015-08-06 11:57 ` Inki Dae
0 siblings, 0 replies; 4+ messages in thread
From: Inki Dae @ 2015-08-06 11:57 UTC (permalink / raw)
To: Marek Szyprowski, linux-samsung-soc; +Cc: dri-devel, Andrzej Hajda, jy0922.shim
On 2015년 08월 06일 19:13, Marek Szyprowski wrote:
> Hello,
>
> On 2015-04-09 10:46, Marek Szyprowski wrote:
>> Once pm_runtime_set_active() gets called, the kernel assumes that given
>> device has already enabled runtime pm and will call pm_runtime_suspend()
>> without matching pm_runtime_resume(). In case of DRM FIMC IPP driver,
>> this will result in calling clk_disable() without respective call to
>> clk_enable(). This patch removes call to pm_runtime_set_active() to
>> ensure that pm_runtime_suspend/resume calls will match.
>>
>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>
> Gentle ping...
Sorry, I missed it. Merged.
Thanks,
Inki Dae
>
>> ---
>> drivers/gpu/drm/exynos/exynos_drm_fimc.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
>> b/drivers/gpu/drm/exynos/exynos_drm_fimc.c
>> index 842d6b8dc3c4..2a652359af64 100644
>> --- a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
>> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimc.c
>> @@ -1745,7 +1745,6 @@ static int fimc_probe(struct platform_device *pdev)
>> spin_lock_init(&ctx->lock);
>> platform_set_drvdata(pdev, ctx);
>> - pm_runtime_set_active(dev);
>> pm_runtime_enable(dev);
>> ret = exynos_drm_ippdrv_register(ippdrv);
>
> Best regards
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-08-06 11:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-09 8:46 [PATCH] drm/exynos/fimc: fix runtime pm support Marek Szyprowski
2015-07-12 16:24 ` Tobias Jakobi
2015-08-06 10:13 ` Marek Szyprowski
2015-08-06 11:57 ` Inki Dae
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox