Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, John Garry <john.g.garry@oracle.com>
Subject: Re: [PATCH v2 0/5] Change the return type of the .queuecommand() callback
Date: Tue, 20 Jan 2026 10:00:21 -0800	[thread overview]
Message-ID: <03cfe069-fa2d-42c9-bb29-5bbee63f3e6e@acm.org> (raw)
In-Reply-To: <yq1ecnoj1wr.fsf@ca-mkp.ca.oracle.com>

On 1/16/26 8:32 PM, Martin K. Petersen wrote:
> In file included from drivers/scsi/pcmcia/aha152x_core.c:3:
> ./drivers/scsi/aha152x.c:927:28: error: return type is an incomplete type
>    927 | static enum scsi_qc_status aha152x_internal_queue(struct scsi_cmnd *SCpnt,
>        |                            ^~~~~~~~~~~~~~~~~~~~~~
> In file included from ./drivers/scsi/aha152x.c:247:
> ./drivers/scsi/aha152x.c: In function ‘aha152x_internal_queue’:
> ./include/scsi/scsi.h:111:34: error: ‘return’ with a value, in function returning void [-Wreturn-mismatch]
> [...]

Hi Martin,

Thanks for having reported this. Unfortunately I haven't been able to
reproduce this build failure. My script for rebuilding all SCSI drivers
builds the PCMCIA AHA152X driver fine for the x86-32 architecture
(https://github.com/bvanassche/build-scsi-drivers). Can you please share
the kernel configuration file and the architecture for which the above
build failure has been observed?

Thanks,

Bart.



  reply	other threads:[~2026-01-20 18:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-15 21:03 [PATCH v2 0/5] Change the return type of the .queuecommand() callback Bart Van Assche
2026-01-15 21:03 ` [PATCH v2 1/5] scsi: aha152x: Return SCSI_MLQUEUE_HOST_BUSY instead of 0x2003 Bart Van Assche
2026-01-16 11:38   ` John Garry
2026-01-15 21:03 ` [PATCH v2 2/5] scsi: megaraid: Return SCSI_MLQUEUE_HOST_BUSY instead of 1 Bart Van Assche
2026-01-16 11:39   ` John Garry
2026-01-16 16:52     ` Bart Van Assche
2026-01-20 18:20       ` John Garry
2026-01-15 21:03 ` [PATCH v2 3/5] scsi: megaraid_sas: " Bart Van Assche
2026-01-15 21:03 ` [PATCH v2 4/5] qla2xxx: Declare qla2xxx_mqueuecommand() static Bart Van Assche
2026-01-16 11:40   ` John Garry
2026-01-15 21:03 ` [PATCH v2 5/5] scsi: Change the return type of the .queuecommand() callback Bart Van Assche
2026-01-17  4:32 ` [PATCH v2 0/5] " Martin K. Petersen
2026-01-20 18:00   ` Bart Van Assche [this message]
2026-01-24  2:53     ` Martin K. Petersen
2026-02-04  3:52 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=03cfe069-fa2d-42c9-bb29-5bbee63f3e6e@acm.org \
    --to=bvanassche@acm.org \
    --cc=john.g.garry@oracle.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox