From: Bart Van Assche <bvanassche@acm.org>
To: John Garry <john.g.garry@oracle.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org,
Kashyap Desai <kashyap.desai@broadcom.com>,
Sumit Saxena <sumit.saxena@broadcom.com>,
Shivasharan S <shivasharan.srikanteshwara@broadcom.com>,
Chandrakanth patil <chandrakanth.patil@broadcom.com>,
megaraidlinux.pdl@broadcom.com,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Subject: Re: [PATCH v2 2/5] scsi: megaraid: Return SCSI_MLQUEUE_HOST_BUSY instead of 1
Date: Fri, 16 Jan 2026 08:52:54 -0800 [thread overview]
Message-ID: <b4d3246f-0c48-43cc-9897-804da65ea546@acm.org> (raw)
In-Reply-To: <4247de59-248f-4e77-b3cb-7bb0ee712761@oracle.com>
On 1/16/26 4:39 AM, John Garry wrote:
> On 15/01/2026 21:03, Bart Van Assche wrote:
>> diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c
>> index a00622c0c526..54ed0ba3f48a 100644
>> --- a/drivers/scsi/megaraid.c
>> +++ b/drivers/scsi/megaraid.c
>> @@ -640,7 +640,7 @@ mega_build_cmd(adapter_t *adapter, struct
>> scsi_cmnd *cmd, int *busy)
>> }
>> if(!(scb = mega_allocate_scb(adapter, cmd))) {
>> - *busy = 1;
>> + *busy = SCSI_MLQUEUE_HOST_BUSY;
>> return NULL;
>> }
>> @@ -688,7 +688,7 @@ mega_build_cmd(adapter_t *adapter, struct
>> scsi_cmnd *cmd, int *busy)
>
> should @busy still be a pointer to an int?
The next patch changes it into a pointer to 'enum scsi_qc_status`. Do
you perhaps want me to move that change into this patch?
Thanks,
Bart.
next prev parent reply other threads:[~2026-01-16 16:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 21:03 [PATCH v2 0/5] Change the return type of the .queuecommand() callback Bart Van Assche
2026-01-15 21:03 ` [PATCH v2 1/5] scsi: aha152x: Return SCSI_MLQUEUE_HOST_BUSY instead of 0x2003 Bart Van Assche
2026-01-16 11:38 ` John Garry
2026-01-15 21:03 ` [PATCH v2 2/5] scsi: megaraid: Return SCSI_MLQUEUE_HOST_BUSY instead of 1 Bart Van Assche
2026-01-16 11:39 ` John Garry
2026-01-16 16:52 ` Bart Van Assche [this message]
2026-01-20 18:20 ` John Garry
2026-01-15 21:03 ` [PATCH v2 3/5] scsi: megaraid_sas: " Bart Van Assche
2026-01-15 21:03 ` [PATCH v2 4/5] qla2xxx: Declare qla2xxx_mqueuecommand() static Bart Van Assche
2026-01-16 11:40 ` John Garry
2026-01-15 21:03 ` [PATCH v2 5/5] scsi: Change the return type of the .queuecommand() callback Bart Van Assche
2026-01-17 4:32 ` [PATCH v2 0/5] " Martin K. Petersen
2026-01-20 18:00 ` Bart Van Assche
2026-01-24 2:53 ` Martin K. Petersen
2026-02-04 3:52 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4d3246f-0c48-43cc-9897-804da65ea546@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=chandrakanth.patil@broadcom.com \
--cc=john.g.garry@oracle.com \
--cc=kashyap.desai@broadcom.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=megaraidlinux.pdl@broadcom.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox