Re: [PATCH v2 4/5] qla2xxx: Declare qla2xxx_mqueuecommand() static

[John Garry <john.g.garry@oracle.com>]

On 15/01/2026 21:03, Bart Van Assche wrote:
> Prevent that a later patch that modifies the qla2xxx_mqueuecommand()
> declaration triggers the following checkpatch warning: "externs should be
> avoided in .c files".
> 
> Cc: Nilesh Javali <njavali@marvell.com>
> Cc: GR-QLogic-Storage-Upstream@marvell.com
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>

Reviewed-by: John Garry <john.g.garry@oracle.com>

> ---
>   drivers/scsi/qla2xxx/qla_os.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
> index c9aff70e7357..fb0b689cbacd 100644
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -402,7 +402,7 @@ static int qla2x00_mem_alloc(struct qla_hw_data *, uint16_t, uint16_t,
>   	struct req_que **, struct rsp_que **);
>   static void qla2x00_free_fw_dump(struct qla_hw_data *);
>   static void qla2x00_mem_free(struct qla_hw_data *);
> -int qla2xxx_mqueuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd,
> +static int qla2xxx_mqueuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd,
>   	struct qla_qpair *qpair);
>   
>   /* -------------------------------------------------------------------------- */
> @@ -981,7 +981,7 @@ qla2xxx_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd)
>   }
>   
>   /* For MQ supported I/O */
> -int
> +static int
>   qla2xxx_mqueuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd,
>       struct qla_qpair *qpair)
>   {
>